Felix Rieseberg
3dcde82485
🔧 Make this easier to read
2017-11-07 18:26:10 -08:00
Felix Rieseberg
07dea13c77
👷 Let’s add a spec!
2017-11-07 13:29:37 -08:00
Felix Rieseberg
1454783450
🔧 Check menu for being falsy
2017-11-07 13:29:14 -08:00
Zeke Sikelianos
8eb38be153
Merge pull request #11000 from sdj01044/fix-korean-styleguide
...
Fix Korean grammatic mistakes
2017-11-07 07:33:35 -08:00
Samuel Attard
5e50a9ab8f
Merge pull request #11009 from electron/docs-aumi-link
...
fix: Documentation: Add link to App User Model Id
2017-11-08 01:15:24 +11:00
Samuel Attard
bf42426acc
Merge pull request #11048 from Toinane/fix-doc
...
fix(documentation): link in browserwindows.md
2017-11-08 01:14:36 +11:00
Samuel Attard
6b9e67c972
Merge pull request #11004 from electron/upgrade-ts-defs
...
Upgrade electron-typescript-definitions to latest
2017-11-08 01:04:55 +11:00
Toinane
247af376fe
fix(documentation): link in browserwindows.md
2017-11-07 14:17:00 +01:00
Samuel Attard
43aa555d64
Merge pull request #11038 from dashersw/master
...
Make ScrubberItem width dynamic
2017-11-07 18:18:52 +11:00
Armagan Amcalar
edd113548a
Make ScrubberItem width dynamic
...
Depending on whether a ScrubberItem has text or an icon, this changeset
calculates the actual width and sizes the TouchBar items accordingly.
Previously, all ScrubberItems, regardless of their content, had a static
width of 50px.
This commit also fixes #10539 .
2017-11-07 00:09:14 +01:00
John Kleinschmidt
5383b4809f
v1.8.2-beta.2
2017-11-06 16:11:34 -05:00
Charles Kerr
083b6e2bbe
Merge pull request #11022 from ChangJoo-Park/patch-2
...
Fix typo inspector to inspect
2017-11-06 10:32:07 -06:00
ChangJoo Park(박창주)
859bb81b29
Fix typo inspector to inspect
2017-11-06 09:23:18 +09:00
Samuel Attard
ca480948aa
Merge pull request #11005 from electron/revert-electron-download-version
...
revert electron-download dependency to ^3.0.1
2017-11-06 12:55:34 +13:00
Vanessa Yuen
f01e5bee92
Merge pull request #11001 from electron/ci-release-build-api
...
Decouple building electron for release from the actual release cutting process
2017-11-05 10:22:04 +08:00
Shelley Vohr
d1cdcc5760
Merge pull request #11007 from electron/silly-typo-change
...
fix: One-character typo change
2017-11-04 20:36:55 -04:00
Samuel Attard
fa795ff4cd
Merge pull request #11013 from electron/temporary-remove-a-deprecation-warning-from-crashreporter-setextraparameter
...
Disable deprecation warning of `crashReported.setExtraParameter()`
2017-11-05 03:41:37 +13:00
Aleksei Kuzmin
bd766067ac
Remove unused deprecate var to make linter happy
2017-11-04 07:52:47 +03:00
Aleksei Kuzmin
b3a1fc65e5
Disable deprecation warning of crashReported.setExtraParameter()
...
It caused a couple of Crash Reported tests to timeout on Mac.
Task to enable it back:
https://github.com/electron/electron/issues/11012
2017-11-04 07:48:39 +03:00
Vanessa Yuen
2063af8ac6
a few changes as per code review comments ✨
2017-11-04 10:53:42 +08:00
Charles Kerr
0aaf961f17
empty commit for CI
2017-11-03 16:33:06 -05:00
Felix Rieseberg
067662b304
📝 Oh look, another typo
2017-11-03 13:02:12 -07:00
Felix Rieseberg
8b85a3be23
📝 Add link to App User Model Id
2017-11-03 11:52:27 -07:00
Felix Rieseberg
43bb74cb13
📝 One-character typo change
2017-11-03 10:54:17 -07:00
Charles Kerr
6f3fdb6ae6
revert electron-download dependency to ^3.0.1
...
undo last week's dependency bump as per discussion at https://github.com/electron/electron/pull/10922
dependency was bumped @ 0c9e106502
2017-11-03 09:45:09 -05:00
Shelley Vohr
8736a41cfb
Merge pull request #10909 from electron/update_remote
...
Simplify and remove excess code from remote module
2017-11-03 09:16:28 -04:00
Shelley Vohr
803fa35484
fix null value check
2017-11-03 08:47:21 -04:00
Birunthan Mohanathas
ecb11b3a4c
Upgrade electron-typescript-definitions to latest for electron/electron-typescript-definitions#80
2017-11-03 14:35:19 +02:00
Vanessa Yuen
85a811db55
make target branch name mandatory and specific ci job optional
...
add it as an npm script `npm run mock-release -- TARGET_BRANCH`
2017-11-03 14:56:16 +08:00
Vanessa Yuen
63632f1137
fix circle config
2017-11-03 14:36:25 +08:00
Cheng Zhao
42d6fe209c
Merge pull request #10936 from robinwassen/tray-docs-update
...
Removed incorrect optional labels from tray.displayBalloon(options) docs
2017-11-03 15:08:43 +09:00
Dongjo Seo
9c8fcfb723
Fix Korean grammatic mistakes
...
I fixed wrong words & wrong translations.
2017-11-03 14:45:10 +09:00
Vanessa Yuen
3bd38bd1fd
add API flags to all other circle jobs
2017-11-03 12:45:30 +08:00
Shelley Vohr
2b2c7d7f9f
fix object serialization test issue
2017-11-02 21:29:17 -04:00
Shelley Vohr
41fa61b446
Merge pull request #10995 from electron/initialize-retroactive-event-emitters
...
singletons that are retroactively turned into EventEmitters should ca…
2017-11-02 21:22:27 -04:00
Shelley Vohr
5c318932c2
add some structural changes
2017-11-02 21:07:40 -04:00
Vanessa Yuen
7cb408838f
skip headers and pdbs for fake release builds
2017-11-03 08:12:54 +08:00
Shelley Vohr
c3930f235a
Merge pull request #10992 from electron/address_crash_done
...
remove function invocation from crash test
2017-11-02 19:51:28 -04:00
Shelley Vohr
18a69b8c48
kick ci
2017-11-02 18:36:33 -04:00
Charles Kerr
4ceeddc09f
Merge pull request #10972 from electron/dpi-issues
...
Workaround for Windows DPI issues
2017-11-02 10:16:11 -05:00
Shelley Vohr
498742d6b3
remove function invocation from crash test
2017-11-02 07:07:19 -04:00
Vanessa Yuen
4cc8008cfc
derp.. why did I make a separate parse_args()
2017-11-02 16:42:09 +08:00
Vanessa Yuen
bf5b9e70bb
fix linting errors
2017-11-02 16:20:41 +08:00
Vanessa Yuen
b23fa34470
modify upload script to allow uploading release assets to s3
2017-11-02 16:06:28 +08:00
Vanessa Yuen
f937f971c1
make script to hit circle ci api point to build for release
2017-11-02 15:26:37 +08:00
Shelley Vohr
9727717839
Merge pull request #10974 from electron/add_crashreport_tests
...
Update Crash Report Tests
2017-11-02 01:45:39 -04:00
Shelley Vohr
a7f059d951
switch from set to add in paramater test
2017-11-02 01:02:16 -04:00
Shelley Vohr
1d6803b234
remove deprecated tests
2017-11-02 00:16:51 -04:00
Charles Kerr
1c09dede1a
singletons that are retroactively turned into EventEmitters should call the EventEmitter ctor
2017-11-01 23:05:27 -05:00
Shelley Vohr
65f125a245
wrap deprecation warning
2017-11-01 23:27:20 -04:00
