Shelley Vohr
7588bb7425
fix: DCHECK entering fullscreen while loading url ( #35111 )
...
* fix: DCHECK entering fullscreen while loading url
* spec: fixup test
2022-08-01 16:52:58 -04:00
Shelley Vohr
eb8c9452cb
fix: crash on BrowserWindow.setEnabled() ( #34904 )
...
fix: crash on BrowserWindow.setEnabled()
2022-07-19 12:31:49 +02:00
Shelley Vohr
2eb0e5dcab
fix: safer check for WCO button updates ( #34833 )
2022-07-11 11:45:01 +02:00
David Sanders
8238cca87b
test: use maximize event instead of resize event ( #34740 )
2022-06-27 10:29:55 +02:00
David Sanders
e2c58d164d
chore: replace Object.assign with object spread syntax ( #34739 )
2022-06-27 10:29:18 +02:00
Jeremy Rose
5895296239
test: disable flaky transparent window test ( #34660 )
2022-06-22 10:37:32 -07:00
Shelley Vohr
530a022b05
fix: window button visibility fullscreen interaction ( #34530 )
2022-06-21 16:35:53 +09:00
Josh Soref
ea4278754c
chore: fix spelling errors in multiple files ( #34574 )
...
* chore: fix spelling in .circleci
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in BUILD.gn
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in appveyor.yml
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in build
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in docs
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in lib
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in script
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in shell
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in spec
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in spec-main
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-06-16 16:46:11 +09:00
Jeremy Rose
bad8d5e08a
fix: make preload calculation identical between sandbox & non-sandboxed ( #34531 )
2022-06-15 13:22:28 -07:00
Milan Burda
16cd22ff6a
test: use webContents.setWindowOpenHandler() in specs ( #34514 )
...
* test: use webContents.setWindowOpenHandler() in specs
* test: use browser-window-created instead of new-window for visibility spec
2022-06-13 13:07:47 -04:00
Shelley Vohr
37d93b0482
fix: update normal bounds prior to minimizing ( #34473 )
2022-06-09 10:48:50 +02:00
Shelley Vohr
16db5a112e
fix: html fullscreen transitions stacking ( #32905 )
...
* fix: html fullscreen transitions stacking
* spec: move webview test to spec-main
2022-06-07 12:59:50 -04:00
Shelley Vohr
6038e42c23
fix: fullscreen windows aren't resizable on macOS ( #34379 )
2022-06-03 09:47:19 +02:00
John Kleinschmidt
887b5a7dc7
fix: crash on navigator.serial.getPorts() ( #34280 )
...
* fix: crash on navigator.serial.getPorts()
* test: fixup BrowserWindow.setTitlebarOverlay test
2022-05-23 10:33:39 -04:00
Shelley Vohr
97c9451efc
fix: WCO crash on bad titlebarStyle ( #34140 )
...
fix: WCO crash on bad titlebarStyle
2022-05-17 11:50:27 -04:00
Shelley Vohr
7af0b58c98
test: add setTitlebarOverlay spec ( #34221 )
...
spec: add setTitlebarOverlay spec
2022-05-16 12:14:27 -04:00
Samuel Attard
ba3aca8200
test: fix background transparency flake ( #34190 )
2022-05-12 09:41:58 +02:00
Shelley Vohr
dd6ce91f57
fix: call loadUrl when opening new windows from links ( #34159 )
...
* fix: call loadUrl when opening new windows from links
* spec: add regression test
2022-05-11 11:34:33 -07:00
John Kleinschmidt
6f8a36f404
test: fixup done being called multiple times ( #34175 )
2022-05-11 10:23:24 -07:00
Samuel Attard
60f1e5e008
test: unflake some focus tests ( #34061 )
...
* spec: unflake some focus tests
* test: disable flaky webFrame visibiilty spec
2022-05-04 01:29:30 -07:00
Darshan Sen
f887000d50
fix: make BrowserWindow#isFocused() return false when blur() is called on macOS ( #33734 )
...
The isFocused() method on macOS works by checking if the selected
BrowserWindow is a key window. Unfortunately, this didn't work well
with blur() because it wasn't calling any macOS APIs that would change
the key status of the window. Hence, this changes the implementation of
blur() to call orderOut first, which removes the key
status of the window. Then when the orderBack function is called, it
moves the window to the back of its level in the screen list, without
changing the key window.
Fixes: https://github.com/electron/electron/issues/33732
Signed-off-by: Darshan Sen <raisinten@gmail.com>
2022-05-03 16:39:18 +09:00
Shelley Vohr
8c8642634d
fix: don't unmaximize on macOS if user set max bounds ( #33480 )
2022-03-31 00:29:02 +02:00
David Sanders
9c3b159b95
fix: on macOS show BrowserWindow on maximize if not currently shown ( #32949 )
2022-03-29 19:08:34 -04:00
Shelley Vohr
d1ea62c3e8
fix: getting focused window with destroyed webContents ( #33404 )
...
* fix: getting focused window with destroyed webContents
* fix: add extra safeguards
2022-03-29 12:22:58 -04:00
zeeker999
108ee7037f
fix: IncrementCapturerCount doesn't increase the capturer count ( #32973 )
2022-03-22 08:38:03 +09:00
Shelley Vohr
db79734bfb
feat: support more color formats for backgroundColor ( #31868 )
2022-03-21 18:35:54 +01:00
Jeremy Rose
e904486076
fix: BrowserWindow.fromWebContents should work in browser-window-created ( #33257 )
2022-03-16 16:23:14 -07:00
David Sanders
e589e9b259
fix: fire show event when BrowserWindow shown via maximize() ( #32979 )
2022-03-09 17:30:42 -05:00
John Kleinschmidt
f45aaea537
test: disable newly added tests on WOA ( #33143 )
...
* tests: disable newly added tests on WOA
* test: also disable test on arm64 macOS
2022-03-07 09:18:58 -05:00
Samuel Maddock
7cb62bfc22
test: BrowserWindow backgroundColor and transparency ( #31017 )
...
* test: BrowserWindow backgroundColor
* test: allow similar colors
* test: disable linux capturing
* refactor: split screen capture from reading pixel color
2022-03-01 14:14:11 -08:00
David Sanders
069cde09fb
fix: don't restore maximized BrowserWindow when calling showInactive ( #32870 )
2022-02-21 10:23:55 +01:00
Shelley Vohr
81fcd732c2
fix: savePage throw on relative paths ( #32728 )
2022-02-07 09:51:59 +01:00
Shelley Vohr
fb3f5e490e
test: improve webContents.savePage() specs ( #32727 )
2022-02-03 16:56:50 -05:00
Shelley Vohr
f5dc2a6535
fix: transparent window max/unmax event firing ( #32643 )
2022-01-31 22:10:57 +01:00
Shelley Vohr
3768a7b25f
fix: css transparent background being lost ( #32593 )
2022-01-27 15:56:35 +01:00
Cheng Zhao
1cf36822e3
fix: make window without rounded corners closable ( #32597 )
2022-01-25 09:51:53 -05:00
Michaela Laurencin
2f0d5651a9
feat: add WCO height option ( #31222 )
...
* feat: add WCO height option
* add docs and mac functionality
* add macOS functionality and height lowerbound
* Update docs/api/browser-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* update macOS functionality
* add chromium related notes
* add test and fix pixel under button bug and fix typo
* revert changes to docs/api/frameless-window.md
* modify `useCustomHeight` calls
* update `useCustomHeight` and `getCurrentMargin`
* modify margin calculation
* fix minimum custom height on macOS
* Update window_buttons_proxy.mm
* fix specified traffic light positions
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2022-01-24 17:09:21 -05:00
David Sanders
0c75b3b2ea
fix: check for maximized window before unmaximizings ( #32438 )
2022-01-17 16:47:14 +09:00
Jeremy Rose
d44a187d0b
feat: remove nativeWindowOpen option ( #29405 )
...
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2022-01-06 09:28:03 -08:00
electron-roller[bot]
bd10b19b0c
chore: bump chromium to 98.0.4706.0 (main) ( #31555 )
...
* chore: bump chromium in DEPS to 97.0.4678.0
* chore: bump chromium in DEPS to 97.0.4679.0
* chore: bump chromium in DEPS to 97.0.4680.0
* chore: bump chromium in DEPS to 97.0.4681.0
* chore: bump chromium in DEPS to 97.0.4682.0
* chore: update patches
* 3234737: Disable -Wunused-but-set-variable
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3234737
* 3216953: Reland "Move task-related files from base/ to base/task/"
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3216953
* 3202710: TimeDelta factory function migration.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3202710
* 3226841: Rename WCO::RenderProcessGone to PrimaryMainFrameRenderProcessGone
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3226841
* 3212165: blink/gin: changes blink to load snapshot based on runtime information
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3212165
* 3220292: Deprecate returning a GURL from GURL::GetOrigin()
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3220292
* 3231995: build: Enable -Wbitwise-instead-of-logical everywhere except iOS and Windows
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3231995
* 3205121: Remove base::DictionaryValue::GetDouble
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3205121
* 3208413: [flags] Make --js-flags settings have priority over V8 features
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3208413
* chore: bump chromium in DEPS to 97.0.4683.0
* chore: update patches
* 3188834: Combine RWHVBase GetCurrentDeviceScaleFactor/GetDeviceScaleFactor
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3188834
* chore: update process_singleton patches
* chore: bump chromium in DEPS to 97.0.4684.0
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4685.0
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4686.0
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4687.0
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4688.0
* chore: update patches
* 3247722: Use correct source_site_instance if navigating via context menu
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3247722
Update signature of HandleContextMenu()
* 3247722: Use correct source_site_instance if navigating via context menu
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3247722
Update signature of HandleContextMenu()
* 3223422: Remove PP_ISOLATEDFILESYSTEMTYPE_PRIVATE_PLUGINPRIVATE enum option
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3223422
sync pepper_plugin_support.patch with upstream
* chore: bump chromium in DEPS to 97.0.4689.0
* 3247791: ax_mac_merge: Merge AX Math attribute implementations
Xref: ax_mac_merge: Merge AX Math attribute implementations
chore: fix minor patch shear in #includes
* 3243425: Add VisibleTimeRequestTrigger helper class
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3243425
chore: fix minor patch shear in #includes
* chore: regen chromium patches
* fixup! 3247722: Use correct source_site_instance if navigating via context menu
* chore: bump chromium in DEPS to 97.0.4690.0
* 3188659: Window Placement: make GetScreenInfo(s) const
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3188659
simple sync GetScreenInfo with upstream refactor
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4690.4
* chore: bump chromium in DEPS to 97.0.4692.0
* 3198073: ozone: //content: clean up from USE_X11
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3198073
Fixing patch shear. Nothing to see here.
* 3252338: Remove label images checkbox from chrome://accessibility page
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3252338
Part of our a11y patch is no longer needed due to upstream label removal
* 3258183: Remove DISALLOW_IMPLICIT_CONSTRUCTORS() definition
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3258183
Replace our use of the macro with explicitly-deleted class methods.
See https://chromium-review.googlesource.com/c/chromium/src/+/3256952
for upstream examples of this same replacement.
* chore: update patches
* 3247295: Unwind SecurityStyleExplanations
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3247295
update GetSecurityStyle() signature and impl to match upstream changes
* 3259578: media: grabs lock to ensure video output when occluded
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3259578
Add stub for new upstream virtual method OnCapturerCountChanged()
* fixup! 3247295: Unwind SecurityStyleExplanations
* 3238504: Fix up drag image is not shown from bookmark bar
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3238504
SetDragImage() no longer takes a widget argument
* 3217452: [devtools] Add getSyncInformation host binding
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3217452
Add stub for new upstream method GetSyncInformation(). Stub sends info back to caller saying that syncing is disabled.
* chore: bump chromium in DEPS to 98.0.4693.0
* chore: bump chromium in DEPS to 98.0.4694.0
* chore: bump chromium in DEPS to 98.0.4695.0
* chore: bump chromium in DEPS to 98.0.4696.0
* chore: bump chromium in DEPS to 98.0.4697.0
* chore: bump chromium in DEPS to 98.0.4699.0
* chore: bump chromium in DEPS to 98.0.4701.0
* chore: bump chromium in DEPS to 98.0.4703.0
* chore: bump chromium in DEPS to 98.0.4705.0
* chore: bump chromium in DEPS to 98.0.4706.0
* chore: update patches
* 3279210: Rename "base/macros.h" => "base/ignore_result.h"
https://chromium-review.googlesource.com/c/chromium/src/+/3279210
* 3259964: Remove all DISALLOW_COPY_AND_ASSIGNs
https://chromium-review.googlesource.com/c/chromium/src/+/3259964
* 3269029: blink/gin: sets histogram callbacks during isolate creation
https://chromium-review.googlesource.com/c/chromium/src/+/3269029
* fixup after rebase
* [content] Make ContentMainParams and MainFunctionParams move-only
https://chromium-review.googlesource.com/c/chromium/src/+/3244976
* 3255305: Stop sending the securityStateChanged event and unwind
https://chromium-review.googlesource.com/c/chromium/src/+/3255305
* [Blink] Add promise support to WebLocalFrame::RequestExecuteScript()
https://chromium-review.googlesource.com/c/chromium/src/+/3230010
* 3256162: Simplify RWHV Show and ShowWithVisibility handling
https://chromium-review.googlesource.com/c/chromium/src/+/3256162
* 3263824: ozone: //ui/base: clean up from USE_X11 1/*
https://chromium-review.googlesource.com/c/chromium/src/+/3263824
* Request or cancel RecordContentToPresentationTimeRequest during capture
https://chromium-review.googlesource.com/c/chromium/src/+/3256802
* appcache: remove BrowsingData/quota references
https://chromium-review.googlesource.com/c/chromium/src/+/3255725
* [Autofill] Don't show Autofill dropdown if overlaps with permissions
https://chromium-review.googlesource.com/c/chromium/src/+/3236729
* Rename to_different_document to should_show_loading_ui in LoadingStateChanged() callbacks
https://chromium-review.googlesource.com/c/chromium/src/+/3268574
* cleanup patch
* fixup [content] Make ContentMainParams and MainFunctionParams move-only
* 3279210: Rename "base/macros.h" => "base/ignore_result.h"
https://chromium-review.googlesource.com/c/chromium/src/+/3279210
* ozone: //chrome/browser clean up from USE_X11
https://chromium-review.googlesource.com/c/chromium/src/+/3186490
Refs: https://github.com/electron/electron/issues/31382
* chore: update support_mixed_sandbox_with_zygote.patch
* Enable -Wunused-but-set-variable.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3234737
* fixup! ozone: //ui/base: clean up from USE_X11 1/*
* fixup! ozone: //chrome/browser clean up from USE_X11
* chore: fix deprecation warning in libuv
* chore: fixup for lint
* 3251161: Reland "Make the Clang update.py script require Python 3"
https://chromium-review.googlesource.com/c/chromium/src/+/3251161
* fixup: Enable -Wunused-but-set-variable.
* [base][win] Rename DIR_APP_DATA to DIR_ROAMING_APP_DATA
https://chromium-review.googlesource.com/c/chromium/src/+/3262369
* Replace sandbox::policy::SandboxType with mojom Sandbox enum
https://chromium-review.googlesource.com/c/chromium/src/+/3213677
* fixup: [content] Make ContentMainParams and MainFunctionParams move-only
* build: ensure angle has a full git checkout available to it
* fixup: [base][win] Rename DIR_APP_DATA to DIR_ROAMING_APP_DATA
* fixup lint
* [unseasoned-pdf] Dispatch 'afterprint' event in PDF plugin frame
https://chromium-review.googlesource.com/c/chromium/src/+/3223434
* fixup: [Autofill] Don't show Autofill dropdown if overlaps with permissions
* 3217591: Move browser UI CSS color parsing to own file part 2/2
https://chromium-review.googlesource.com/c/chromium/src/+/3217591
* Make kNoSandboxAndElevatedPrivileges only available to utilities
https://chromium-review.googlesource.com/c/chromium/src/+/3276784
* 3211575: [modules] Change ScriptOrModule to custom Struct
https://chromium-review.googlesource.com/c/v8/v8/+/3211575
* Address review feedback
* chore: update patches
* 3211575: [modules] Change ScriptOrModule to custom Struct
https://chromium-review.googlesource.com/c/v8/v8/+/3211575
* fix: unused variable compat
* chore: remove redundant patch
* fixup for 3262517: Re-enable WindowCaptureMacV2
https://chromium-review.googlesource.com/c/chromium/src/+/3262517
* chore: cleanup todo
The functions added in https://chromium-review.googlesource.com/c/chromium/src/+/3256802 are not used by offscreen rendering.
* fixup: update mas_no_private_api.patch
* 3216879: [PA] Make features::kPartitionAllocLazyCommit to be PartitionOptions::LazyCommit
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3216879 Fixes up commit b2f1aca95604ec61649808c846657454097e6935
* chore: cleanup support_mixed_sandbox_with_zygote.patch
* test: use window focus event instead of delay to wait for webContents focus
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <khammond@slack-corp.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2021-11-24 09:45:59 +01:00
CezaryKulakowski
557e586667
fix: fix aspect ratio when max width/height is set ( #29101 )
...
Add the native frame border size to the minimum and maximum size if
the view reports its size as the client size. It allows to enlarge
window to proper values when aspect ratio and max width/height are
set. It also fixes DCHECK which was triggered when user tried to
enlarge window above dimensions set during creation of the
BrowserWindow.
2021-11-22 18:31:21 +09:00
John Kleinschmidt
4b3aed503f
test: fix crash in electron::NativeWindowMac::Close() ( #31750 )
...
* test: fix crash in electron::NativeWindowMac::Close()
* remove extra close
2021-11-08 19:27:32 -08:00
Shelley Vohr
20b4813cf8
fix: crash on close window when webContents destroyed ( #31620 )
2021-11-01 13:32:54 +09:00
Milan Burda
3332420886
docs: win.getParentWindow() returns BrowserWindow | null ( #31548 )
2021-10-25 11:10:33 -04:00
Shelley Vohr
629d8913f6
fix: maximized state calculation for non-resizable windows ( #30989 )
2021-09-21 12:04:32 +02:00
Shelley Vohr
6fdf350bea
fix: disabling and enabling resizability on macOS ( #30999 )
2021-09-17 15:54:15 +02:00
Samuel Maddock
fb40065c1e
fix: show maximized frameless window ( #30804 )
2021-09-07 10:18:43 +02:00
Michaela Laurencin
41646d1168
feat: enable windows control overlay on Windows ( #29600 )
...
* rebase "feat: enable windows control overlay on Windows"
* correct compilation error
* fix linting errors
* modify includes and build file
* change `hidden` option to `overlay`
* add patch to fix visual layout
* add button background color parameter
* add button text color parameter
* modify `overlay` in docs and modify button hover/press transition color
* change `text` to `symbol`
* remove todo and fix `text` replacement
* add new titleBarOverlay property and remove titleBarStyle `overlay`
* update browser and frameless window docs
* remove chromium patches
* chore: update patches
* change button hover color, update trailing `_`, update test file
* add dchecks, update title bar drawing checks, update test file
* modify for mac and linux builds
* update docs with overlayColor and overlaySymbolColor
* add corner and side hit test info
* modify docs and copyright info
* modify `titlebar_overlay_` as boolean or object
* move `title_bar_style_ to `NativeWindow`
* update docs with boolean and object titlebar_overlay_
* add `IsEmpty` checks
* move get options for boolean and object checks
* fix linting error
* disable `use_lld` for macos
* Update docs/api/frameless-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Update docs/api/frameless-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Update docs/api/frameless-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Apply docs suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* modify `true` option description `titleBarOverlay`
* ci: cleanup keychain after tests on arm64 mac (#30472 )
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-08-11 14:07:36 -04:00
Cheng Zhao
97929eab5f
fix: move window buttons in-place on macOS ( #30322 )
2021-08-04 09:31:12 +09:00
Jeremy Rose
385d0f590f
refactor: remove base::Value from WebContentsPreferences ( #30193 )
2021-07-26 09:04:09 -07:00
