Shelley Vohr
7c7543cb39
spec: re-enable app.getAppMetric API ( #13962 )
2018-08-09 13:35:29 -05:00
Milan Burda
271d582aac
refactor: make methods const, cleanup ( #13937 )
2018-08-09 10:15:23 -07:00
GhostlyDark
9005803667
Fix typos ( #13999 )
2018-08-09 10:04:03 -05:00
Milan Burda
9a1ad2b93f
fix: ipcRemote.sendSync regression after moving away from JSON for return values ( #13941 )
2018-08-09 19:45:10 +10:00
Dominic
a7052efaf4
fix: make menu.popup options optional ( #13977 )
...
* add empty object as default param for options
* update docs
* add spec for optional options
* fix: add null check for options
2018-08-08 17:38:52 -05:00
Jeremy Apthorp
fc4499ebd4
chore: roll libcc
2018-08-08 09:33:02 -07:00
Charles Kerr
29f07889e6
feat: add location url to "Node.js Integration with Remote Content" warning ( #13973 )
...
* docs: fix typo
* feat: add location url to Node+Remote warning
2018-08-07 20:40:21 -05:00
Jeremy Apthorp
e6e621515f
chore: disable flaky isCurrentlyAudible test ( #13970 )
2018-08-07 14:23:48 -05:00
John Kleinschmidt
06786e7bb8
Merge pull request #13828 from nornagon/gn-ci-mac
...
ci: [gn] add Mac support to VSTS build
2018-08-06 10:54:22 -04:00
Jeremy Apthorp
2551837ffb
docs: min windows server version for building is 2012 ( #13935 )
2018-08-03 17:32:07 -07:00
Jeremy Apthorp
379998e2f6
docs: recommend windows 10 as the minimum build OS
...
I'm pretty sure building on windows 7 doesn't work.
2018-08-03 15:42:12 -07:00
Shelley Vohr
9f328abe19
refactor: remove instances of createDeepCopy ( #13703 )
...
* add new native_mate converters for base::Value
* fix converter swapping
* remove createDeepCopy from browser/api
* replace missing ListValue converter
* convert bulk of remaining createDeepCopy instances
* convert last remaining instances of createDeepCopy
* incremental progress and helper methods for value conversion
* convert Get and add template function for GetString
* final DictionaryValue method conversions
* remove usage of base::DictionaryValue in web_contents_preferences
* use IsEnabled helper where possible
* Update atom_api_web_view_manager.cc
2018-08-04 07:23:07 +10:00
Jeremy Apthorp
cecb8fb0c4
chore: roll libcc and node DEPS ( #13931 )
2018-08-03 12:36:56 -07:00
Milan Burda
f904057104
fix: add missing "simple" property in several APIs to prevent proxying of return values ( #13905 )
...
* fix: add missing "simple" property in several APIs to prevent proxying of return values
* add tests
2018-08-03 12:07:27 -07:00
deepak1556
e0735baff2
docs: [gn] update build instructions
2018-08-03 11:54:21 -07:00
Jeremy Apthorp
96c39923b6
ci: [gn] add builders for 32-bit linux
2018-08-03 11:08:12 -07:00
Milan Burda
fceed0fcbc
fix: dipToScreenRect / screenToDipRect - window can be null ( #13903 )
2018-08-03 13:08:42 +10:00
Jeremy Apthorp
03293d78a2
chore: roll libcc DEPS ( #13917 )
2018-08-03 10:55:49 +10:00
Birunthan Mohanathas
23440a5ec3
fix: Improve --enable-features/--disable-features handling ( #13920 )
...
As it turns out, we can reinitialize the feature list directly after the
user JS script has been executed instead of much later. This allows
modifications to `--enable-features`/`--disable-features` to work with a
greater set of features.
2018-08-03 10:53:54 +10:00
Shelley Vohr
48ae9b7a9c
docs: update node upgrade doc ( #13891 )
...
Updates the node upgrade doc to take path changes into account as well as to incorporate the new `get-patch` script which simplifies work significantly.
2018-08-01 23:33:37 -07:00
Jeremy Apthorp
c068bc7d3d
test: make nativeImage relative path test robust to different cwd
2018-08-01 15:19:26 -07:00
Jeremy Apthorp
651e7d21c4
Try setting npm_config_msvs_version
2018-08-01 10:35:03 -07:00
Jeremy Apthorp
63604278ec
Add env var to skip native module tests
2018-08-01 10:29:35 -07:00
Jeremy Apthorp
00b2d94785
ci: start the dbus mock server in GN CI
2018-08-01 10:08:02 -07:00
Jeremy Apthorp
a4f02724bf
refactor: use env var to skip native module tests on win32/debug ( #13890 )
2018-08-01 13:33:13 +10:00
Samuel Attard
4990b3990b
spec: add more assertions to help smoke out the close all window failures ( #13868 )
2018-08-01 13:32:07 +10:00
Milan Burda
c52b3d921e
fix: some APIs modified for ASAR support cannot be util.promisify'ed ( #13845 )
2018-08-01 13:06:48 +10:00
Jeremy Apthorp
80d22e8dc0
test out build matrix for debug/release
2018-07-31 17:28:32 -07:00
Jeremy Apthorp
083ec2f60a
ci: [gn] add ci build for gn on windows
2018-07-31 15:28:12 -07:00
Samuel Attard
eb79ad4dab
fix: handle SIGINT and SIGTERM from the Electron CLI helper ( #13867 )
...
Fixes #12840
2018-07-31 13:44:04 -05:00
Felix Rieseberg
a99cc969b5
📝 Update security docs: will-navigate, new-window ( #13884 )
2018-07-31 13:40:26 -05:00
Jeremy Apthorp
31ac89fa2f
ci: gn linux release builds ( #13809 )
2018-07-31 11:18:36 -07:00
Jeremy Apthorp
e22a80b210
chore: [gn] run 'gn format' over BUILD.gn
2018-07-31 09:55:27 -07:00
Jeremy Apthorp
32f456de07
chore: [gn] run 'gn format' over build/node/BUILD.gn
2018-07-31 09:55:27 -07:00
Jeremy Apthorp
260f7775e7
ci: more lenient check for is_ci in lib.util.download
...
AppVeyor sets CI=True or CI=true, not CI=1
2018-07-31 09:51:40 -07:00
Jeremy Apthorp
28b6f2f46d
build: [gn] fix rpath when building with component ffmpeg ( #13874 )
2018-07-30 15:46:04 -07:00
Jeremy Apthorp
ae29d562eb
build: [gn] add //ui/strings:app_locale_settings to locale pak
...
Fixes a crash on Windows when accessing IDS_UI_FONT_FAMILY
2018-07-30 13:59:00 -07:00
Jeremy Apthorp
d0a9c2c77f
build: [gn] build release with is_cfi = false
...
When is_cfi = true (the default on Linux Release), Electron crashes at
boot with SIGILL in V8::InitializePlatform.
2018-07-30 13:58:38 -07:00
Jeremy Apthorp
3bdff2d238
feat: allow setting window shape ( #13789 )
...
This binds Widget::SetShape, an API that already exists in Chromium (for
Windows and Linux). It's a more reliable method of having some parts of
your window be "click-through" than the current `setIgnoreMouseEvents`
API, which messes around with the `WS_EX_LAYERED` window style on
Windows, causing strange bugs and incompatibility with hardware
acceleration.
2018-07-30 13:37:40 -07:00
Jeremy Apthorp
6e224df00e
[wip] ci: add Mac support to VSTS build
2018-07-30 12:50:16 -07:00
Samuel Attard
b22ac5f0a2
build: commit changes to the package-lock.json file ( #13864 )
2018-07-30 15:09:06 +10:00
Alexandre Lacheze
2bba11c5b0
docs: warning unicity of webRequest event listener ( #13482 )
2018-07-30 11:38:59 +10:00
Gellert Hegyi
4bcf0e34c5
fix: window.setVibrancy parameter passing ( #13627 )
...
* fix: setVibrancy parameter passing
* fix: uses correct parameter types for setVibrancy
2018-07-30 11:29:18 +10:00
Alexey Kuzmin
69f6bd921b
chore(tests): allow usage of deprecated APIs in tests ( #13659 )
2018-07-30 11:27:58 +10:00
Felix Rieseberg
c2218cc414
📝 First draft: Here be dragons ( #13835 )
2018-07-30 11:19:23 +10:00
Milan Burda
39c5c200ba
fix: util.promisify(setTimeout) ( #13840 )
2018-07-30 11:14:04 +10:00
Milan Burda
db38c8b620
Fix process.execPath returning parent process path instead of the helper in sandboxed renderer ( #13839 )
2018-07-30 11:13:42 +10:00
Milan Burda
aacbd76baa
docs: fix electron.d.ts typings ( #13841 )
2018-07-30 11:11:23 +10:00
Jeremy Apthorp
a6bc8030ea
build: [gn win] fix path names in js2asar
2018-07-27 12:08:39 -07:00
Jeremy Apthorp
27e6805889
build: [gn] pack ui_strings in locales ( #13827 )
...
Fixes a crash when running the tests on linux:
[15860:0726/132247.086106:WARNING:resource_bundle.cc(586)] unable to find resource: 27282
[15860:0726/132247.086189:FATAL:resource_bundle.cc(587)] Check failed: false.
0 0x7f1cad88ed7d base::debug::StackTrace::StackTrace()
1 0x7f1cad88eccc base::debug::StackTrace::StackTrace()
2 0x7f1cad9327ba logging::LogMessage::~LogMessage()
3 0x7f1ca4dea3ae ui::ResourceBundle::GetLocalizedString()
4 0x7f1ca4db5113 l10n_util::GetStringUTF16()
5 0x7f1ca3753bdd views::(anonymous namespace)::EmptyMenuMenuItem::EmptyMenuMenuItem()
2018-07-27 08:05:36 -07:00