mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
28519 commits 1 branch 183 tags 5.3 GiB
Commit graph

28519 commits

This branch
This branch
All branches
Author SHA1 Message Date
Charles Kerr
2d868ecb8d
perf: use v8::Local<v8::Object> as the key in ObjectCache (#43519) 
* perf: use v8::Object* as direct keys instead of using hash + a linked list

* refactor: use v8::Local<v8::Object> as the key
 2024-09-04 22:53:06 -05:00
Charles Kerr
0467790aee
chore: migrate to v8::Object::SetPrototypeV2() (#43535) 
chore: migrate to v8::Object::SetPrototypeV2().

Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5600627

[api] Mark v8::Object::GetPrototype() for deprecation

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-09-04 20:30:54 -05:00
Charles Kerr
8ae5aacc8c
refactor: declare gin::Wrapper subclasses as final (#43527) 
As per the gin docs: "Wrappable<T> explicitly does not support further
subclassing of T. Subclasses of Wrappable<T> should be declared final."
 2024-09-04 18:40:02 -05:00
Keeley Hammond
94f2722fa3
build: don't run symbol generation on PS (#43554) 
fix: don't run symbol generation on PS
 2024-09-04 17:18:57 +01:00
Charles Kerr
054cbcd6eb
fix: don't use deprecate-soon class v8::String::Value (#43518) 
* fix: remove use of deprecated v8::String::Value

Upstream marked v8::String::Value as `V8_DEPRECATE_SOON` last month,
so let's stop using it.

The replacement code mostly does the same as v8::String::Value();
but since our test only cares about the length and not the contents,
we get a small perf win of not needing to allocate a char array and
not needing to call Local::String::Write().

Upstream V8_DEPRECATE_SOON:
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5667299kkk

v8::String::Value() implementation:
20226b740b/src/api/api.cc (10883)

History on why we used it:
80c1a9739d
f49ed30f72

* Update shell/common/gin_converters/file_path_converter.h

Co-authored-by: Robo <hop2deep@gmail.com>

* fixup! Update shell/common/gin_converters/file_path_converter.h

do not return success for all non-Null non-Strings

---------

Co-authored-by: Robo <hop2deep@gmail.com>
 2024-09-04 08:56:14 -05:00
dependabot[bot]
4c83016cf3
build(deps): bump github/codeql-action from 3.26.3 to 3.26.6 (#43529) 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.3 to 3.26.6.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](883d8588e5...4dd16135b6)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-09-04 09:35:09 -04:00
Orko Garai
53dcda1fe9
fix: Use XDG_ACTIVATION_TOKEN in wayland when launched by other app (#43481) 
When an electron app is launched by another app ensure that the
XDG_ACTIVATION_TOKEN env var is read and used for activation using
xdg_activation_v1 protocol.
 2024-09-04 12:54:00 +02:00
George Xu
635d421123
fix: systemMediaPermissionDenied should not check camera perms when the request is asking for screen share (#43517) 
* fix: systemMediaPermissionDenied: should check for screen capture perms instead of camera

* Revert "fix: systemMediaPermissionDenied: should check for screen capture perms instead of camera"

This reverts commit e9cc67216558263402867056ed332f8781da3153.

* should only do these checks for audio or video, but not screenshare

* no service

* oops

---------

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-09-04 09:56:26 +01:00
Charles Kerr
b42c0ae00d
fix: -Wunsafe-buffer-usage warnings in IsUrlArg() (#43477) 
* fix: -Wunsafe-buffer-usage warnings in IsUrlArg()

* chore: improve code comments for CheckCommandLineArguments()

* chore: reduce diffs from main

* refactor: CheckCommandLineArguments takes a StringVector arg

Fixes another buffer warning!
 2024-09-03 21:51:39 -04:00
John Kleinschmidt
90ba2df4fa
build: free up macos disk space as soon as possible (#43533) 
* chore: free up macos disk space as soon as possible

* build: free up disk space on gn check too
 2024-09-03 21:32:05 -04:00
John Kleinschmidt
c41a28d7c8
chore: speed up cache only reclient for fork PRs (#43497) 2024-08-29 13:51:06 -04:00
Robo
41b8fdca5c
fix: devtools dock state with WCO on linux (#43490) 2024-08-29 09:17:00 +09:00
electron-roller[bot]
38512efd25
chore: bump node to v20.17.0 (main) (#43428) 
* chore: bump node in DEPS to v20.17.0

* module: disallow CJS <-> ESM edges in a cycle from require(esm)

https://github.com/nodejs/node/pull/52264

* src: expose LookupAndCompile with parameters

https://github.com/nodejs/node/pull/53886

* src: fix -Wshadow warning

https://github.com/nodejs/node/pull/53885

* lib: convert WeakMaps in cjs loader with symbol properties

https://github.com/nodejs/node/pull/52095

* src: reduce unnecessary serialization of CLI options in C++

https://github.com/nodejs/node/pull/52451

* build: ensure v8_pointer_compression_sandbox is enabled on 64bit

https://github.com/nodejs/node/pull/53884

* lib: improve error message when index not found on cjs

https://github.com/nodejs/node/pull/53859

* src,lib: expose getCategoryEnabledBuffer to use on node.http

https://github.com/nodejs/node/pull/53602

* deps: update c-ares to v1.32.2

https://github.com/nodejs/node/pull/53865

* chore: fixup patch indices

* deps: update V8 to 12.2

https://github.com/nodejs/node/pull/51362

* stream: Expose DuplexPair API

https://github.com/nodejs/node/pull/34111

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-26 15:09:33 -04:00
Charles Kerr
7cea992926
refactor: simplify KeyWeakMap impl (#43461) 2024-08-26 13:19:05 -05:00
Charles Kerr
2390706030
refactor: prefer std::ranges over begin() and end() (#43464) 2024-08-26 10:58:32 -04:00
David Sanders
56829f75c1
chore: cleanup include groupings (#43478) 2024-08-26 10:44:20 -04:00
Charles Kerr
5994b34a5d
chore: remove unused WinFrameView::kInactiveTitlebarFeatureAlpha (#43448) 
added in Aug 2021 (41646d11, #29600) but never used
 2024-08-23 20:59:41 -05:00
electron-appveyor-updater[bot]
e6555ac5e1
build: update appveyor image to latest version (#43451) 
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
 2024-08-23 18:36:32 -04:00
Charles Kerr
5a1eeea102
perf: prefer GURL string_view getters (#43443) 
* chore: avoid double-call to url.scheme() in WebContentsZoomController::SetZoomMode()

* perf: use gurl.scheme_piece() in GetAppInfoHelperForProtocol()

* perf: use gurl.scheme_piece() in Browser::GetApplicationNameForProtocol()

* refactor: add std::less<> to HandlersMap

This lets us search it using string_view keys

* refactor: ProtocolRegistry::FindRegistered() now takes a std::string_view

* perf: use gurl.scheme_piece() in InspectableWebContents::LoadNetworkResource()

* refactor: ProtocolRegistry::FindIntercepted() now takes a std::string_view

* perf: use gurl.scheme_piece() in SimpleURLLoaderWrapper::GetURLLoaderFactoryForURL()

* perf: use gurl.scheme_piece() in ProxyingURLLoaderFactory::CreateLoaderAndStart()

* perf: use gurl.host_piece() in ElectronWebUIControllerFactory::GetWebUIType()

* perf: use gurl.host_piece() in ElectronWebUIControllerFactory::CreateWebUIControllerForURL()
 2024-08-23 17:15:45 -05:00
Charles Kerr
7f34b0e6f5
chore: remove unused method asar::ClearArchives() (#43442) 
chore: remove unused asar::ClearArchives()

last use removed in Jun 2021 (b1d1ac65, #29293)
 2024-08-23 14:53:01 -05:00
John Kleinschmidt
c1eee18e41
test: add -pdf-ready-to-print event to WebContents for testing (#43436) 2024-08-23 12:34:26 -05:00
Charles Kerr
9ce0ca74c3
build: remove fix_disable_scope_reuse_associated_dchecks.patch (#43441) 
chore: remove fix_disable_scope_reuse_associated_dchecks.patch
 2024-08-23 11:04:20 -04:00
Shelley Vohr
3a5a1ea7bd
docs: titleBarOverlay is defined as a BaseWindow ctor option (#43430) 
docs: titleBarOverlay is defined as a BaseWindow ctor option
 2024-08-23 11:02:43 -04:00
Shelley Vohr
6e4d90fcdb
fix: ensure bounds stability in OnWidgetBoundsChanged (#43431) 
* fix: ensure bounds stability in OnWidgetBoundsChanged

* Update shell/browser/native_window_views.cc

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-08-23 11:02:05 -04:00
Erick Zhao
fd8d9f06fd
chore: mention signed commit requirement (#43406) 
chore: mentioned signed commit requirement
 2024-08-23 15:52:33 +02:00
Alexander Cyon
ca0837c852
chore: fix typos in 'shell/' folder. (#43373) 2024-08-22 19:48:32 -05:00
reito
1aeca6fd0e
feat: GPU shared texture offscreen rendering (#42953) 
* feat: GPU shared texture offscreen rendering

* docs: clarify texture infos that passed by the paint event.

* feat: make gpu osr spec test optional

* fix: osr image compare

* fix: remove duplicate test

* fix: update patch file

* fix: code review

* feat: expose more metadata

* feat: use better switch design

* feat: add warning when user forget to release the texture.

* fix: typo

* chore: update patch

* fix: update patch

* fix: update patch description

* fix: update docs

* fix: apply suggestions from code review

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* fix: apply suggested fixes

---------

Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-08-22 19:23:13 -05:00
electron-roller[bot]
b481966f02
chore: bump chromium to 130.0.6672.0 (main) (#43445) 
chore: bump chromium in DEPS to 130.0.6672.0

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
 2024-08-22 18:27:25 -05:00
electron-roller[bot]
baf0182a42
chore: bump chromium to 130.0.6671.0 (main) (#43429) 
* chore: bump chromium in DEPS to 130.0.6671.0

* 5802591: [Partitioned Popins] (6) Add permissions policy for popin

https://chromium-review.googlesource.com/c/chromium/src/+/5802591

* 5794132: [video pip] Move back to tab button to the header

https://chromium-review.googlesource.com/c/chromium/src/+/5794132

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-22 13:16:40 -05:00
Shelley Vohr
50ce448556
fix: menu should allow focused BaseWindow where possible (#43404) 
fix: menu should allow focused BaseWindow
 2024-08-22 14:13:30 -04:00
Shelley Vohr
7391db93e2
build: roll sysroots (#43261) 2024-08-22 16:22:12 +02:00
Alexander Cyon
b27dc7514e
fix: documentation spelling errors (#43366) 
chore: fix typos in 'docs/' folder.
 2024-08-22 15:44:55 +02:00
Alexander Cyon
ae0c8881c3
chore: fix typos in 'spec/' folder (and one in 'lib/' folder) (#43374) 2024-08-22 15:44:15 +02:00
Shelley Vohr
4ae43dcb3b
fix: touch bar functionality on BaseWindow (#43353) 
* fix: touch bar functionality on BaseWindow

* test: add test for BaseWindow.setTouchBar
 2024-08-22 12:48:25 +02:00
electron-appveyor-updater[bot]
46bed807ca
build: update appveyor image to latest version (#43369) 
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
 2024-08-22 10:12:57 +02:00
Shelley Vohr
755c6640fd
docs: clarify icon value in Notification (#43377) 
* docs: clarify icon value in Notification

* Update docs/api/notification.md

Co-authored-by: Erick Zhao <erick@hotmail.ca>

---------

Co-authored-by: Erick Zhao <erick@hotmail.ca>
 2024-08-21 19:38:06 -05:00
Charles Kerr
4fbf18a021
refactor: move impl functions into private namespace (#43372) 2024-08-21 15:26:06 -05:00
electron-roller[bot]
f366caac84
chore: bump chromium to 130.0.6669.0 (main) (#43397) 
* chore: bump chromium in DEPS to 130.0.6669.0

* 5789734: Consolidate all the accessibility scale factor utility code into one file

https://chromium-review.googlesource.com/c/chromium/src/+/5789734

* 5798543: [autofill] Don't emit autofill audit reports if inspector not connected

https://chromium-review.googlesource.com/c/chromium/src/+/5798543

* 5797073: [wasm] Spill all loop inputs before entering loop

https://chromium-review.googlesource.com/c/v8/v8/+/5797073

* chore: fixup patch indices

* 5795224: Version 13.0.0

https://chromium-review.googlesource.com/c/v8/v8/+/5795224

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-21 12:34:18 -04:00
David Sanders
4874233aae
chore: set wg-infra as CODEOWNER for GHA build configs (#43223) 
* chore: set wg-releases as CODEOWNER for GHA build configs

* chore: change to wg-infra
 2024-08-21 10:49:22 +02:00
David Sanders
b7af0537c8
docs: update timelines for E33 (#43389) 2024-08-20 15:47:32 -07:00
Keeley Hammond
7da9c0b2f7
docs: update window customization tutorial (#43388) 2024-08-20 15:29:01 -07:00
Shelley Vohr
46af43db49
chore: cherry-pick 9797576 from v8 (#43376) 2024-08-20 16:49:02 -04:00
Charles Kerr
93a6f3e607
refactor: NodeBindings::Create() returns a unique_ptr (#43361) 
* refactor: NodeBindings::Create() returns a unique_ptr

* empty commit
 2024-08-20 15:34:59 -04:00
Charles Kerr
a2de94dda1
chore: remove unused ConvertableToTraceFormatWrapper (#43356) 
* chore: remove unused ConvertableToTraceFormatWrapper

Last use removed in Apr 2024 (39bf441b, #41880)

* fixup! chore: remove unused ConvertableToTraceFormatWrapper

remove now-unused trace_event.h header, too
 2024-08-20 15:21:43 -04:00
electron-roller[bot]
2cc14c6e8f
chore: bump chromium to 129.0.6668.0 (main) (#43368) 
* chore: bump chromium in DEPS to 129.0.6668.0

* 5787687: [Extensions] Remove EventRouterForwarder from BrowserProcess

https://chromium-review.googlesource.com/c/chromium/src/+/5787687

* 5788808: Resolve Blob URL's origin using info from browser process

https://chromium-review.googlesource.com/c/chromium/src/+/5788808

* chore: fixup patch indices

* 5786747: Remove "int WriteFile"

https://chromium-review.googlesource.com/c/chromium/src/+/5786747

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-20 16:54:27 +02:00
dependabot[bot]
945aabfaee
build(deps): bump github/codeql-action from 3.26.0 to 3.26.3 (#43365) 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.0 to 3.26.3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](eb055d739a...883d8588e5)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-08-20 13:11:50 +02:00
Charles Kerr
3186c2f0ef
refactor: remove unused SetWMSpecState (#43347) 
last use removed in Aug 2022 by 53cd2315 #35179
 2024-08-19 17:15:19 -04:00
Charles Kerr
44e4e4521c
chore: remove unused method Erase() (#43348) 
Last use removed in Mar 2018 by 4b39d17e
 2024-08-19 17:14:57 -04:00
Vít Černý
189675575c
feat: extend navigationHistory API (#42014) 
* feat: extend navigationHistory API

* refactor: simplify index checking

* refactor: rename 'getHistory' and 'replaceHistory' methods of navigationHistory

* refactor: rename delete*() methods to remove*()

* feat: remove navigationHistory.replaceHistory()

* tests: add tests for removeEntryAtIndex and getAllEntries
 2024-08-19 15:46:04 -04:00
electron-roller[bot]
4c3014944c
chore: bump chromium to 129.0.6664.0 (main) (#43329) 
* chore: bump chromium in DEPS to 129.0.6657.0

* chore: update patches

* chore: bump chromium in DEPS to 129.0.6658.0

* chore: update patches

* 5743786: [ServiceWorker] Populate service worker start token to WorkerId.

https://chromium-review.googlesource.com/c/chromium/src/+/5743786

* 5784424: [Extensions] Move ownership of Dispatcher to ExtensionsRendererClient

https://chromium-review.googlesource.com/c/chromium/src/+/5784424

* chore: bump chromium in DEPS to 129.0.6659.0

* chore: bump chromium in DEPS to 129.0.6660.0

* chore: update patches

* chore: bump chromium in DEPS to 129.0.6662.0

* chore: bump chromium in DEPS to 129.0.6664.0

* 5789627: [Partitioned Popins] (3) `popin` feature triggers third-party storage partitioning

https://chromium-review.googlesource.com/c/chromium/src/+/5789627

* 5791367: Remove some chrome:: namespace from chrome/browser/app_mode/*

https://chromium-review.googlesource.com/c/chromium/src/+/5791367

* 5791522: [SCK] Skip redundant getShareableContentWithCompletionHandler

https://chromium-review.googlesource.com/c/chromium/src/+/5791522

* 5761330: Send refresh rate prefs b/w RefreshRateController and DisplayPrivate

https://chromium-review.googlesource.com/c/chromium/src/+/5761330

* chore: fixup patch indices

* 5793591: Remove unused GetHeader overload

https://chromium-review.googlesource.com/c/chromium/src/+/5793591

* 5787624: [Extensions] Simplify ExtensionsRendererClient::RenderThreadStarted()

https://chromium-review.googlesource.com/c/chromium/src/+/5787624

* 5721709: Fix Incorrect last_accessed_time Tracking for Tabs

https://chromium-review.googlesource.com/c/chromium/src/+/5721709

* 5789215: [Extensions] Add a //chrome/common/extensions build target

https://chromium-review.googlesource.com/c/chromium/src/+/5789215

* Roll V8 from 48f669a0758c to eee3eb91d01c

48f669a075..eee3eb91d0

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-08-19 14:52:53 -04:00