dependabot[bot]
2c5514d0fe
build(deps): bump github/codeql-action from 3.25.7 to 3.26.8 ( #43912 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.25.7 to 3.26.8.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f079b84933...294a9d9291
2024-09-23 23:26:05 -07:00
Charles Kerr
4e74793433
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() ( #43894 )
...
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() (#43803 )
2024-09-23 22:36:51 -07:00
dependabot[bot]
9d438e594f
build(deps): bump actions/download-artifact from 4.1.7 to 4.1.8 ( #43913 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.1.7 to 4.1.8.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](65a9edc588...fa0a91b85d
2024-09-23 22:31:12 -07:00
dependabot[bot]
7ad6b192a0
build(deps): bump actions/upload-artifact from 4.3.3 to 4.4.0 ( #43914 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.3 to 4.4.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v4.3.3...50769540e7f4bd5e21e526ee35c689e35e0d6874 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 21:27:56 -07:00
dependabot[bot]
e4bdff6cc1
build(deps): bump dsanders11/github-app-commit-action from 1.4.0 to 1.5.0 ( #43915 )
...
build(deps): bump dsanders11/github-app-commit-action
Bumps [dsanders11/github-app-commit-action](https://github.com/dsanders11/github-app-commit-action ) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/dsanders11/github-app-commit-action/releases )
- [Changelog](https://github.com/dsanders11/github-app-commit-action/blob/main/.releaserc.json )
- [Commits](48d2ff8c1a...43de6da2f4
2024-09-23 21:27:32 -07:00
Shelley Vohr
8b7f96057c
fix: createWindow shouldn't load URL for webContents ( #43877 )
2024-09-23 21:55:08 +02:00
trop[bot]
8d6a5fa522
build: add support for fetching github token from sudowoodo ( #43885 )
...
* build: add support for fetching github token from sudowoodo
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* chore: update release notes cache for tests
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* build: support nightlies repo correctly
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* build: post token
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-09-23 11:07:16 -07:00
trop[bot]
19b70a4cb4
docs: add advanced specification for Squirrel updater ( #43891 )
...
* docs: add advanced specification for Squirrel updater
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
* address feedback
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
2024-09-23 11:02:31 -07:00
dependabot[bot]
8b229743d5
build(deps): bump actions/setup-node from 4.0.2 to 4.0.4 ( #43842 )
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.2 to 4.0.4.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](60edb5dd54...0a44ba7841
2024-09-23 06:55:00 -07:00
dependabot[bot]
199bc0968b
build(deps): bump actions/checkout from 4.1.6 to 4.1.7 ( #43838 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.6 to 4.1.7.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.6...692973e3d937129bcbf40652eb9f2f61becf3332 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-23 06:53:54 -07:00
dependabot[bot]
fe2af7b9cd
build(deps): bump ossf/scorecard-action from 2.3.3 to 2.4.0 ( #43834 )
...
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action ) from 2.3.3 to 2.4.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases )
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md )
- [Commits](dc50aa9510...62b2cac7ed
2024-09-23 06:51:16 -07:00
dependabot[bot]
1e2b2f52a1
build(deps): bump amannn/action-semantic-pull-request from 5.5.2 to 5.5.3 ( #43832 )
...
build(deps): bump amannn/action-semantic-pull-request
Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request ) from 5.5.2 to 5.5.3.
- [Release notes](https://github.com/amannn/action-semantic-pull-request/releases )
- [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md )
- [Commits](cfb60706e1...0723387faa
2024-09-23 06:50:13 -07:00
dependabot[bot]
5c72872230
build(deps): bump slackapi/slack-github-action from 1.26.0 to 1.27.0 ( #43828 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 1.26.0 to 1.27.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](70cd7be8e4...37ebaef184
2024-09-23 06:46:47 -07:00
trop[bot]
192226d793
fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer() ( #43811 )
...
* fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: add a DCHECK to confirm the BigBuffer is full
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-20 08:48:14 -05:00
trop[bot]
8ac9d16162
fix: third time screen sharing on macOS ( #43809 )
...
Because we used decrementing negative source ids for fake video id when
instantating a native macOS screen share picker, we eventually hit the
`DesktopMediaID::kFakeId = -3` in Chromium source code which displayed a
test green screen.
In this change we reserve our own fake id of `-4` and decrement the
window id integer for uniqueness instead.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Fedor Indutny <238531+indutny@users.noreply.github.com>
2024-09-19 20:33:41 -07:00
trop[bot]
2bc8797fed
refactor: NotificationPresenter::Create() returns a std::unique_ptr<> ( #43806 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-19 22:11:59 -05:00
trop[bot]
08579bdcd5
chore: fix compile issue about ambiguous error of multiple methods named 'highlight'. ( #43801 )
...
chore: fix ambiguous error of multiple methods named 'highlight'
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: bill.shen <shenyb32768@gmail.com>
2024-09-19 09:33:28 -05:00
Charles Kerr
bd9e00968b
refactor: remove use of deprecated API BuildServiceInstanceFor() (32-x-y) ( #43780 )
...
* refactor: remove use of deprecated API BuildServiceInstanceFor() (#43690 )
* refactor: update BadgeManagerFactory
* refactor: update NetworkContextServiceFactory
* refactor: update ElectronExtensionSystemFactory
* refactor: update UsbChooserContextFactory
* refactor: update UsbHidChooserContextFactory
* refactor: update SerialChooserContextFactory
* refactor: update FileSystemAccessPermissionContextFactory
* empty commit
2024-09-19 09:59:57 +02:00
Charles Kerr
0f11dd958f
build: compile Node.js with C++20 support (32-x-y) ( #43785 )
...
build: compile Node.js with C++20 support (#43555 )
* build: compile with C++20 support
* build: update build-image-sha for gcc 10
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-19 09:56:04 +02:00
Charles Kerr
8b49ba1084
fix: EyeDropper working in devtools (32-x-y) ( #43786 )
...
fix: EyeDropper working in devtools (#43685 )
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-19 09:55:54 +02:00
trop[bot]
9c88da38f2
build: let darwin/mas run concurrently ( #43791 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-09-18 20:51:21 -04:00
electron-roller[bot]
8ab4d240d8
chore: bump chromium to 128.0.6613.162 (32-x-y) ( #43768 )
...
chore: bump chromium in DEPS to 128.0.6613.162
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-09-18 09:28:19 -07:00
trop[bot]
95ae0aa8a4
build: split darwin/mas macOS publish jobs ( #43766 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2024-09-17 20:07:32 -07:00
trop[bot]
ca3234064f
build: improve logging on http errors during release process ( #43762 )
...
* build: improve logging on http errors during release process (#43756 )
Co-authored-by: Samuel Attard <sam@electronjs.org>
* build: improve logging on http errors during release process (again) (#43757 )
Co-authored-by: Samuel Attard <sam@electronjs.org>
* build: improve logging on http errors during release process (again, but more) (#43758 )
Co-authored-by: Samuel Attard <sam@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sam@electronjs.org>
2024-09-17 20:06:08 -07:00
trop[bot]
3329bb6a86
ci: move Archaeologist to GHA ( #43733 )
...
* chore: move Archaeologist to GHA
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: test archaelogist changes
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Revert "chore: test archaelogist changes"
This reverts commit a575d6ef3a6495a71c03e9e2d15ec9bb329c5033.
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* chore: properly name steps in archaeologist-dig
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-09-17 09:52:44 -07:00
trop[bot]
3b29efb232
fix: in Emit(), don't leak converted Arg Local<Values> into caller's scope ( #43747 )
...
fix: Emit() should not leak converted arg handles into caller's HandleScope
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-17 11:16:53 -05:00
trop[bot]
42048ddc57
fix: resizing border on Linux WCO caption buttons ( #43743 )
...
Closes https://github.com/electron/electron/issues/43714 .
Fixes an issue where the resizing border was not being handled correctly on Linux WCO
caption buttons. This is now taken into account as a part of the NonClientHitTest.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-17 11:21:41 -04:00
trop[bot]
71d4bb8801
docs: document View.removeChildView edge case ( #43726 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2024-09-16 12:53:01 +02:00
trop[bot]
6c670c3f1f
refactor: avoid minor code repetition in native_image.cc ( #43703 )
...
chore: delegate handle creation in NativeImage::Resize()
chore: delegate handle creation in NativeImage::Crop()
chore: delegate handle creation in NativeImage::CreateEmpty()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-12 17:10:01 -05:00
trop[bot]
763d3983a1
fix: native View wrapper crash missing when adding child view ( #43698 )
...
fix: native View wrapper crash missing when adding child view
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-12 12:48:12 +02:00
electron-roller[bot]
8ca3b8f84e
chore: bump chromium to 128.0.6613.137 (32-x-y) ( #43683 )
...
chore: bump chromium in DEPS to 128.0.6613.137
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-09-11 19:28:35 +02:00
trop[bot]
097c6b796d
feat: add support for system picker in setDisplayMediaRequestHandler ( #43679 )
...
* tmp
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* feat: add support for system picker in setDisplayMediaRequestHandler
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* oops
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* Apply suggestions from code review
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Samuel Attard <sam@electronjs.org>
* stuff
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* well...
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* seems legit
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
* chore: update patch to handle screenCapturer
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* feat: modify API to use useSystemPicker
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* fix: gate ScreenCaptureKitPicker to macos 15 or higher
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* fix: don't use native picker with legacy media selection
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* chore: code review, boolean set & docs update
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* fix: add cancelCallback
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* docs: clarify session & desktopCapturer docs
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
* chore: remove incorrect backport patches
* chore: update SCKP patch
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
Co-authored-by: Samuel Attard <sam@electronjs.org>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2024-09-11 09:56:47 -07:00
trop[bot]
fa1311e550
fix: ensure SetPluginCanSave updated in PDFs ( #43687 )
...
fix: ensure SetPluginCanSave updated in PDFs
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-11 17:56:26 +02:00
trop[bot]
5b933e941e
fix: -Wunsafe-buffer-usage warning in V8Serializer::Serialize() ( #43676 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-10 19:00:33 -05:00
trop[bot]
017ba5bf46
fix: restore Chromium default Content-Disposition header parsing ( #43668 )
...
* fix: restore Chromium default Content-Disposition header parsing
Co-authored-by: Milan Burda <milan.burda@gmail.com>
* Update api-web-request-spec.ts
Co-authored-by: Milan Burda <milan.burda@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2024-09-10 16:15:18 -04:00
Shelley Vohr
7034537852
perf: use v8::Local<v8::Object> as the key in ObjectCache ( #43662 )
...
* perf: use v8::Object* as direct keys instead of using hash + a linked list
* refactor: use v8::Local<v8::Object> as the key
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-10 09:21:21 -05:00
electron-roller[bot]
57cca46286
chore: bump node to v20.17.0 (32-x-y) ( #43424 )
...
* chore: bump node in DEPS to v20.17.0
* module: disallow CJS <-> ESM edges in a cycle from require(esm)
https://github.com/nodejs/node/pull/52264
* src: expose LookupAndCompile with parameters
https://github.com/nodejs/node/pull/53886
* src: fix -Wshadow warning
https://github.com/nodejs/node/pull/53885
* lib: convert WeakMaps in cjs loader with symbol properties
https://github.com/nodejs/node/pull/52095
* src: reduce unnecessary serialization of CLI options in C++
https://github.com/nodejs/node/pull/52451
* build: ensure v8_pointer_compression_sandbox is enabled on 64bit
https://github.com/nodejs/node/pull/53884
* lib: improve error message when index not found on cjs
https://github.com/nodejs/node/pull/53859
* src,lib: expose getCategoryEnabledBuffer to use on node.http
https://github.com/nodejs/node/pull/53602
* deps: update c-ares to v1.32.2
https://github.com/nodejs/node/pull/53865
* chore: fixup patch indices
* deps: update V8 to 12.2
https://github.com/nodejs/node/pull/51362
* stream: Expose DuplexPair API
https://github.com/nodejs/node/pull/34111
* chore: fix patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-10 10:58:42 +02:00
trop[bot]
7097afb7f0
docs: update window customization tutorial ( #43660 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2024-09-10 10:12:14 +02:00
Shelley Vohr
aead35a833
fix: printing occasionally showing failed when cancelled ( #43643 )
2024-09-09 19:35:56 -05:00
Shelley Vohr
01ef05580f
fix: ensure bounds stability in OnWidgetBoundsChanged ( #43644 )
...
fix: ensure bounds stability in OnWidgetBoundsChanged
2024-09-09 19:35:29 -05:00
trop[bot]
f74c353abf
fix: out-of-scope Local handle in node::CallbackScope ( #43639 )
...
refactor: use an EscapableHandleScope
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-09 18:27:39 -05:00
Shelley Vohr
88c70ceee2
build: fix patchup logic only running on one platform ( #43645 )
2024-09-09 18:00:49 -05:00
Shelley Vohr
5e2e8feb9e
chore: remove unused ConvertableToTraceFormatWrapper ( #43646 )
2024-09-09 18:00:37 -05:00
Shelley Vohr
a4938311cd
test: add -pdf-ready-to-print event to WebContents for testing ( #43647 )
2024-09-09 17:59:19 -05:00
trop[bot]
f427e05d82
fix: -Wunsafe-buffer-usage warnings in asar file IO ( #43648 )
...
* fix: -Wunsafe-buffer-usage warnings in ScopedTemporaryFile::InitFromFile()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fix: -Wunsafe-buffer-usage warnings in Archive::Init()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-09 17:58:57 -05:00
Shelley Vohr
e8389927c8
fix: ensure version of xdg-dialog-portal with defaultPath support ( #43629 )
...
fix: ensure version of xdg-dialog-portal with defaultPath support
2024-09-09 17:40:48 +02:00
trop[bot]
6ec798d5fe
fix: update BrowserView#lastWindowSize after window resize ( #43637 )
...
fix: update BrowserView#lastWindowSize after window resize (#43462 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Zonglong Liu <83216456+mai-121@users.noreply.github.com>
2024-09-09 17:40:18 +02:00
trop[bot]
8cb44915d8
fix: UvHandle move semantics ( #43633 )
...
reassign the uv_handle_t of the source
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-09 10:36:11 -05:00
trop[bot]
15aeb87370
perf: avoid redundant Promise.GetContext calls ( #43619 )
...
refactor: avoid redundant Promise.GetContext calls
Several Promise methods call `GetContext()` multiple times. From looking
at the assembly in obj/electron/electron_lib/promise.o, these redundant
calls are actually being made -- they aren't optmized out.
This PR keeps the return value in a local variable to avoid extra calls.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-08 10:37:34 -05:00
trop[bot]
39258d20d4
refactor: take a uint8_t span in ValidateIntegrityOrDie() ( #43613 )
...
refactor: take a uint8_t span in ValidateIntegrityOrDie()
Doing some groundwork for fixing unsafe base::File() APIs:
- Change ValidateIntegrityOrDie() to take a span<const uint8_t> arg.
We'll need this to migrate asar's base::File API calls away from the
ones tagged `UNSAFE_BUFFER_USAGE` because the safe counterparts use
span<uint8_t> too.
- Simplify ValidateIntegrityOrDie()'s implementation by using
crypto::SHA256Hash() instead of reinventing the wheel.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-06 22:17:03 -05:00
