Samuel Attard
2bf740d2fe
fix: remove enable_data_url_support from OnNetworkServiceCreated
...
data URLs are _always_ enabled in the network service now and this is
enforced in the Content layer.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1512337
2019-04-02 14:43:04 -07:00
Samuel Attard
406ceaabd1
chore: update permission_status.h include for new path
2019-04-02 14:43:03 -07:00
Jeremy Apthorp
e44b5263a1
add extra arguments to HandleExternalProtocol
...
https://chromium-review.googlesource.com/c/chromium/src/+/1491812
2019-04-02 14:43:03 -07:00
Samuel Attard
75442b794f
fix: make devtools extensions load correctly ( #17614 )
2019-03-30 17:36:13 -07:00
Samuel Attard
b8dbe4bc15
spec: add tests for the autoUpdater on macOS that actually test if it works ( #17442 )
...
* spec: add tests for the autoUpdater on macOS that actually test if it works
* spec: add express as dep
* spec: add logic to auto-trust self-signed certificate and not run autoupdate specs on MAS
* build: fix the step name for importing the codesign cert
* chore: update updater spec PR as per feedback
* fix: s/atomBinding/electronBinding
* build: use spawn instead of exec
2019-03-29 17:32:52 -07:00
Samuel Attard
3475cd168e
fix: handle a race condition between preload scripts executing and ( #17577 )
...
navigations
There is a race condition between DidCreateScriptContext and another
navigation occuring in the main process. If the navigation occurs while
the preload script is running, the same process is re-used. This
ensures that any pending navigations are completely removed / ignored
when we trigger a new navigation.
Fixes #17576
2019-03-28 11:13:05 -07:00
Richard Townsend
3d307e5610
fix: correct crash reporter for Windows on Arm ( #17533 )
...
ARM64 cleans up and moves around RUNTIME_FUNCTION structure fields.
With this patch applied, electron should build cleanly for Windows on Arm.
2019-03-27 11:30:11 -07:00
Samuel Attard
f4434763fe
fix: use file path as key for safeDialogs on filesystem ( #17546 )
2019-03-27 11:21:10 -07:00
Samuel Attard
2188a6ea99
fix: set default_id and cancel_id correctly on confirm dialogs ( #17547 )
2019-03-27 11:15:58 -07:00
Shelley Vohr
4e57a732a8
feat: allow windows to be excluded from the windows menu ( #17404 )
...
* feat: allow windows to be excluded from the windows menu
* excludedfromWindowsMenu => excludedFromShownWindowsMenu
* implement no-op for win & linux
2019-03-27 08:10:23 -04:00
Milan Burda
95df531b33
fix: add missing buffer size check in nativeImage ( #17465 )
2019-03-26 10:13:39 +09:00
Robo
6c20c6e668
refactor: Enable network service (Part 1) ( #17431 )
...
* Convert InspectableWebContentsImpl::LoadNetworkResource to SimpleURLLoader
https://bugs.chromium.org/p/chromium/issues/detail?id=721408
* Plumb creation of network context with the service
2019-03-26 10:10:48 +09:00
Cheng Zhao
49f13e38f9
fix: close context menu before popup ( #17474 )
2019-03-21 21:56:22 -07:00
Jeremy Apthorp
6555be2636
chore: bump chromium to 74.0.3729.27 (master) ( #17345 )
...
* chore: bump chromium to 74.0.3729.5 (master)
* Remove ScopedBlockingCall constructor without location
https://chromium-review.googlesource.com/c/chromium/src/+/1496560
* Use XCode 9.4.1 for Mac SDK 10.13
* chore: roll chromium 74.0.3729.27
2019-03-21 11:45:22 -04:00
Shelley Vohr
b140a82fe8
fix: take foreground visibility into account for isVisible on macOS ( #17463 )
2019-03-20 15:33:59 -07:00
Samuel Attard
45d90e77b7
fix: use a more unique identifier for NSUserNotification instances ( #17469 )
...
So although apple has it documented that notifications with duplicate identifiers in the same session won't be presented. They apparently forgot to mention that macOS also non-deterministically and without any errors, logs or warnings will also not present some notifications in future sessions if they have a previously used identifier.
As such, we're going to truly randomize these identifiers so they are
unique between apps and sessions. The identifier now consists of a
randomly generated UUID and the app bundle id.
2019-03-20 09:53:20 -07:00
Cheng Zhao
671533f7d2
fix: check the result when calling js function ( #17443 )
...
* fix: check the result when calling js function
* test: should not crash when callback returns nothing
2019-03-20 08:27:06 -07:00
Shelley Vohr
1d93bc76cd
feat: expose colorSpace to display object ( #17405 )
...
* feat: expose colorSpace to display object
* update doc
* add a spec
2019-03-19 15:12:03 -07:00
Milan Burda
4c51fa93f5
feat: add systemPreferences.getAnimationSettings() ( #17382 )
2019-03-19 12:15:40 -07:00
Shelley Vohr
2fb9085e5b
feat: add tray.getTitle() ( #17385 )
...
* feat: add tray.getTitle
* fix spec
2019-03-18 12:40:34 -07:00
Shelley Vohr
38d75010c7
chore: rename atomBinding to electronBinding ( #17419 )
2019-03-18 12:37:06 -07:00
Samuel Attard
5025c991ee
fix: pass the correct HostPort into the node inspector ( #17380 )
...
Fixes #17348
2019-03-18 09:19:33 -07:00
Milan Burda
3a091cdea4
refactor: implement clipboard APIs without the remote module ( #17200 )
2019-03-15 17:32:04 -07:00
Shelley Vohr
961c9a88a8
feat: promisify dialog.showCertificateTrustDialog() ( #17181 )
...
* feat: promisify dialog.showCertificateTrustDialog()
* update promisification doc
2019-03-15 09:02:50 +09:00
Shelley Vohr
12b6a0f5b2
feat: add native emoji picker ( #17359 )
2019-03-14 13:39:52 -07:00
Milan Burda
2e89348541
feat: promisify executeJavaScript ( #17312 )
2019-03-14 12:08:54 -07:00
Milan Burda
878538f2e8
feat: add safer nativeImage.createFromBitmap(), which does not decode PNG/JPEG ( #17337 )
2019-03-14 11:00:38 -07:00
Shelley Vohr
aa8b66aae1
feat: promisify session.getBlobData() ( #17303 )
2019-03-14 08:11:01 -07:00
Shelley Vohr
d9234798d3
chore: clean up promise resoution with helpers ( #17268 )
2019-03-13 14:30:21 -07:00
Shelley Vohr
3e5a98b5f4
feat: promisify In-App Purchase ( #17355 )
...
* feat: promisify In-App Purchase
* use mate::Arguments in GetProducts
2019-03-13 13:56:01 -07:00
Milan Burda
df7dc9396e
fix: don't crash when nativeImage.createFromBuffer() called with invalid buffer ( #17344 )
2019-03-13 08:26:11 -07:00
Heilig Benedek
14cc8a1808
fix: improve focused menu bar item visibility ( #17291 )
2019-03-12 15:29:45 -07:00
Shelley Vohr
8991c0056e
feat: promisify dialog.showMessageBox() ( #17298 )
...
* feat: promisify dialog.showMessageBox()
* address feedback from review
2019-03-12 11:06:59 -07:00
Nitish Sakhawalkar
e77d065875
chore: node_includes header no longer needs to be at the end of the list ( #17090 )
...
Until one of the latest version of node, the definition of the DISALLOW_COPY_AND_ASSIGN macro in node was different than in chromium. That is no longer the case, so just undefining the macro in node_includes.h works.
2019-03-11 17:13:43 -07:00
Samuel Maddock
f943db7ad5
feat: Add content script world isolation ( #17032 )
...
* Execute content script in isolated world
* Inject script into newly created extension worlds
* Create new content_script_bundle for extension scripts
* Initialize chrome API in content script bundle
* Define Chrome extension isolated world ID range
1 << 20 was chosen as it provides a sufficiently large range of IDs for extensions, but also provides a large enough buffer for any user worlds in [1000, 1 << 20).
Ultimately this range can be changed if any user application raises it as an issue.
* Insert content script CSS into document
This now avoids a script wrapper to inject the style sheet. This closely matches the code used by chromium in `ScriptInjection::InjectCss`.
* Pass extension ID to isolated world via v8 private
2019-03-11 16:27:57 -07:00
Samuel Attard
c7a453226d
fix: remove label/image from segment if they are mutated to undefined/null ( #17323 )
2019-03-11 11:13:36 -07:00
Electron Bot
b43e4b8e0e
Bump v6.0.0-nightly.20190311
2019-03-11 10:56:01 -07:00
Electron Bot
a958eb9c44
Bump v6.0.0-nightly.20190308
2019-03-08 19:38:21 -08:00
Electron Bot
7343a2f232
Revert "Bump v6.0.0-nightly.20190308"
...
This reverts commit 40af881844
.
2019-03-08 19:36:24 -08:00
Electron Bot
40af881844
Bump v6.0.0-nightly.20190308
2019-03-08 19:36:08 -08:00
Shelley Vohr
9ea6c01e02
feat: promisify session.clearAuthCache() ( #17259 )
...
* feat: promisify session.clearAuthCache()
* remove unused callback runner helpers
2019-03-08 18:41:42 -08:00
Electron Bot
58a9a81895
Revert "Bump v6.0.0-nightly.20190308"
...
This reverts commit 4728cebd9e
.
2019-03-08 17:46:53 -08:00
Electron Bot
4728cebd9e
Bump v6.0.0-nightly.20190308
2019-03-08 17:13:26 -08:00
Samuel Attard
e185057ef9
chore: fix linting issues in atom_api_cookies.cc
2019-03-08 15:13:22 -08:00
deepak1556
457ff0687c
device/fido/mac: add more specific check for TouchID availability
...
https://chromium-review.googlesource.com/c/chromium/src/+/1487811
2019-03-08 15:13:12 -08:00
Jeremy Apthorp
bf6fea3b59
AttachToOuterWebContentsFrame => AttachInnerWebContents
...
https://chromium-review.googlesource.com/c/1492653
2019-03-08 15:13:12 -08:00
Jeremy Apthorp
0d534b3c52
fix: compile error in frame_subscriber.h
...
https://chromium-review.googlesource.com/c/1460096
2019-03-08 15:13:12 -08:00
Jeremy Apthorp
69bf9aa605
fix extra-semi warnings
2019-03-08 15:10:52 -08:00
deepak1556
e8f6f31fe4
Disable network service
...
https://github.com/electron/electron/issues/15791
2019-03-08 15:06:16 -08:00
deepak1556
0243b0ffc1
Change base::JSONReader::ReadToValue() to return Optional.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1476186
2019-03-08 15:06:16 -08:00