Commit graph

77 commits

Author SHA1 Message Date
Charles Kerr
d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
Milan Burda
7253c7f843 refactor: move SpecialStoragePolicy from brightray to atom (#13944) 2018-08-21 08:51:04 -07:00
Robo
9989195f19 fix: notify request context shutdown on IO before cleanup (#14058) 2018-08-14 14:07:53 -07:00
Charles Kerr
b9490177da Revert "[WIP] refactor: (Part I) make the ownership of URLRequestContextGetter more clear (#13956)"
This reverts commit 1c0bb06d4a.
2018-08-13 16:16:04 -07:00
Robo
1c0bb06d4a [WIP] refactor: (Part I) make the ownership of URLRequestContextGetter more clear (#13956)
* refactor: desttroy URLRequestContextGetter on IO thread

* Accepts a factory class that can customize the creation of URLRequestContext
* Use a separate request context for media which is derived from the default
* Notify URLRequestContextGetter observers and cleanup on IO thread
* Move most of brightray net/ classes into atom net/

* refactor: remove refs to URLRequestContextGetter on shutdown

* refactor: remove brigtray switches.{cc|h}

* refactor: remove brightray network_delegate.{cc|h}

* refactor: make AtomURLRequestJobFactory the top level factory.

* Allows to use the default handler from content/ for http{s}, ws{s} schemes.
* Removes the storage of job factory in URLRequestContextGetter.
2018-08-13 15:22:45 -07:00
deepak1556
01fdfc4574 Remove Permission manager from brightray
Electron manages its own implementation, this was
missed out when merging the brightray/ component.
2018-06-19 11:46:59 +10:00
Shelley Vohr
284aca68c0
clang-format brightray 2018-04-17 21:46:27 -04:00
deepak1556
007ea500d0 REVIEW: Re-use devtools network throttling from content layer
https://chromium-review.googlesource.com/c/chromium/src/+/664356
2018-03-20 10:13:15 +03:00
Samuel Attard
e65815e34c Implement GetBackgroundFetchDelegate in brightray::BrowserContext 2018-03-20 10:08:58 +03:00
deepak1556
ebb0e46380 REVIEW: create AtomNetworkDelegate on the IO thread 2018-01-02 16:37:08 +09:00
Aleksei Kuzmin
7d1c1700f8 Implement GetBrowsingDataRemoverDelegate() for BrowserContext subclasses
https://codereview.chromium.org/2898443002
2017-11-24 10:58:16 +09:00
Aleksei Kuzmin
b81ae1c36f REVIEW: Move MediaDeviceIDSalt from ProfileIOData to ProfileImpl.
https://codereview.chromium.org/2820163002
2017-11-24 10:58:15 +09:00
Kevin Sawicki
c43c3b3d80 Revert "protocol: use streaming interface between fetcher and requestjob"
This reverts commit 71b5d946e0.
2017-05-26 09:47:22 -07:00
Kevin Sawicki
d7321ed980 Add brightray prefix to include paths from within brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
c4608c0f37 Fix build/include_alpha linter violations in brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
f193b2b2a6 Fix build/include_what_you_use linter violations in brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
cfb5b6ac89 Fix build/header_guard linter violations in brightray 2017-05-19 08:46:15 -07:00
deepak1556
71b5d946e0 protocol: use streaming interface between fetcher and requestjob 2017-05-11 22:52:49 +05:30
deepak1556
dbf4e52e05 persist media device id salt across sessions 2016-12-03 16:47:31 +05:30
Cheng Zhao
4f3e9df055 Merge remote-tracking branch 'origin/master' into chrome52 2016-07-21 05:34:20 -06:00
Cheng Zhao
6413a4c516 Move the ability to create BrowserContext to embedder 2016-07-12 21:39:23 +09:00
Cheng Zhao
4afa3f7206 Add BrowserContext::GetRequestContext 2016-07-04 15:29:43 +09:00
Cheng Zhao
4e9782897c Update to API changes of Chrome 52 2016-07-04 15:06:05 +09:00
Cheng Zhao
d37a120a6a Provide access to JobFactory in URLRequestContextGetter 2016-06-15 20:31:11 +09:00
Cheng Zhao
f5bfbada97 NetLog should be managed by BrowserClient 2016-05-23 19:02:13 +09:00
Cheng Zhao
76d180a80d Adapt to changes of Chrome 51 API changes (Part 2) 2016-05-23 12:28:41 +09:00
Cheng Zhao
851ef398fb Adapt to changes of Chrome 51 API changes 2016-05-23 10:59:07 +09:00
deepak1556
de60acbfde Fix race initialising DevtoolsNetworkController 2016-04-14 08:57:20 +05:30
Cheng Zhao
d3a39540b5 Fix compilation errors on OS X 2016-03-08 23:28:28 +09:00
Haojian Wu
2981a7e256 Remove storage limitation of WebSQL. 2015-10-12 21:21:45 +08:00
Cheng Zhao
43bfdace86 Merge pull request #152 from atom/register-prefs
Fix RegisterPrefs not working in subclass.
2015-10-06 22:44:32 +08:00
Haojian Wu
73632d4189 Fix RegisterPrefs not working in subclass.
Don't call virtual function in subclass's constructor.
2015-10-06 16:11:28 +08:00
Robo
a1e646f1b3 enabling network emulation in devtools 2015-09-27 21:38:38 +05:30
Cheng Zhao
87a1b68c47 Fix typo 2015-09-06 10:29:59 +08:00
Cheng Zhao
d2ea3b496d Only store weak ref to BrowserContext 2015-09-05 22:34:42 +08:00
Cheng Zhao
1a8dc77951 Move management of browser context to BrowserContext 2015-09-05 20:52:50 +08:00
Cheng Zhao
dc1e50c62e Store BrowserContext in ref-counted ptr 2015-09-05 20:03:18 +08:00
Cheng Zhao
58fb166b0b Pass partition name instead of path to BrowserContext 2015-09-05 19:46:55 +08:00
Robo
0e956c497d use browser context from webcontents for registering datasource 2015-08-31 21:04:48 +05:30
Robo
fa5c8fc943 handle partition config in browser context 2015-08-27 17:31:31 +05:30
Cheng Zhao
8a92ef34a7 Store NetLog in BrowserClient 2015-08-11 18:29:55 +08:00
Robo
7496cb29fe create netlog for devtoolsnetlogobserver 2015-07-15 00:54:28 +05:30
Antonin Hildebrand
899c730ece Missing overrides
ninja compilation failed for me under OS X 10.11
2015-06-26 11:39:41 +02:00
Cheng Zhao
f477e6ca6a Don't hide methods of content::BrowserContext 2015-06-26 10:58:06 +08:00
Cheng Zhao
95d28c398e Update cpplint 2015-06-05 12:07:27 +08:00
Cheng Zhao
0cbf8b6cd2 Implement PermissionManager 2015-05-22 14:50:41 +08:00
Cheng Zhao
bb8da7ec7e Fix browser_context.cc 2015-03-08 19:56:45 -07:00
Cheng Zhao
dc86ab58a9 Remove DownloadManagerDelegate
Having a partial implemented DownloadManagerDelegate will cause crashes under
certain places.
2014-12-17 13:13:19 -08:00
Cheng Zhao
8ec5b5ad20 DevToolsClientHost is discarded 2014-12-09 22:39:44 -08:00
Cheng Zhao
f809fef22d OVERRIDE => override 2014-10-23 11:10:39 +08:00