Kevin Sawicki
883c4b63d0
temp_path -> temp_dir
2016-10-06 09:02:02 -07:00
Kevin Sawicki
0380d3ae50
Pass crashes directory to crash service process
2016-10-06 09:02:02 -07:00
Kevin Sawicki
43702e0f8e
Support calling getUploadedReports on unstarted crash reporter
2016-10-06 09:02:02 -07:00
Kevin Sawicki
a0db484510
Use app.getPath directly for temp path
2016-10-06 09:02:02 -07:00
Kevin Sawicki
f282b51c98
🎨 Use ES6 class, destructuring, and let/const
2016-10-06 09:02:01 -07:00
Kevin Sawicki
ac0658bbf1
Use PathService for temp dir path for crashes
2016-10-06 09:02:01 -07:00
Kevin Sawicki
e77d7e7f62
🎨
2016-09-16 11:41:53 -07:00
Kevin Sawicki
5d0f3534eb
Rethrow binding errors
2016-09-16 11:34:52 -07:00
Kevin Sawicki
902bd0564e
Require Buffer explicitly instead of relying on global
2016-09-08 10:17:06 -07:00
Kevin Sawicki
28b33074cf
Setup stdin in both processes on Windows
2016-09-07 14:45:56 -07:00
Kevin Sawicki
46fbb6ed61
Reset process.noAsar in finally block
2016-09-06 13:40:25 -07:00
Kevin Sawicki
8eca019157
Support paths as Buffers
2016-07-25 11:10:36 -07:00
Kevin Sawicki
30fbe92970
Add asar-supported fs.accessSync implementation
2016-07-25 11:05:18 -07:00
Kevin Sawicki
3ad5504194
Add asar-supported fs.access implementation
2016-07-25 10:50:30 -07:00
Kevin Sawicki
a518c47f4c
Use let/const instead of var
2016-07-25 10:43:38 -07:00
Cheng Zhao
1c9421bc89
Use ArrayBuffer.isView to detect Buffer and ArrayBuffer
2016-07-25 16:39:09 +09:00
haad
fac330fb50
Fix TypedArray check, add check when instanceof doesn't work for TypedArrays.
2016-07-23 12:43:49 +01:00
haad
2757046e71
Add isTypedArray to Electron exports
2016-07-23 11:30:14 +01:00
haad
e6c8900a18
Fix linting
2016-07-22 20:20:24 +01:00
haad
c717cd9192
🐛 Add support for TypedArrays in IPC.
...
Fixes https://github.com/electron/electron/issues/2104 .
2016-07-22 19:44:19 +01:00
Cheng Zhao
f792b6c752
Remove callbackId when callback is removed from registry
2016-06-24 11:22:48 +09:00
Kevin Sawicki
bac4d51169
Reuse root path variable
2016-06-23 15:56:29 -07:00
Kevin Sawicki
905e9e9645
Include trailing separator in comparisons
2016-06-23 15:45:08 -07:00
Kevin Sawicki
b273b70eee
Filter existing search paths instead reimplementing
2016-06-23 15:27:45 -07:00
Cheng Zhao
93b8237e1f
Merge pull request #5700 from felixrieseberg/standard-7
...
Implement JavaScript Standard Style 7
2016-05-26 04:57:36 +00:00
Cheng Zhao
8a4b7eb062
Merge pull request #5689 from cdaringe/master
...
Support non-native promises
2016-05-26 04:49:40 +00:00
Felix Rieseberg
bef6748c06
🎨 Implement JS Standard Code Style 7
...
Updates Standard Code Style to 7 (latest major) and ensures that code
is conform.
* camelCase is now enforced
* No assignments in return statements
2016-05-25 16:20:49 -07:00
cdaringe
32073fa079
🎨 Support non-native promises
2016-05-25 10:11:18 -06:00
Kevin Sawicki
7e209dd982
ATOM_SHELL_INTERNAL_CRASH_SERVICE -> ELECTRON_INTERNAL_CRASH_SERVICE
2016-05-25 09:08:09 -07:00
Kevin Sawicki
a4f94b89b4
Add comment about Module path
2016-05-23 15:15:39 -07:00
Kevin Sawicki
6ac0151e65
Remove lint warnings
2016-05-23 15:14:55 -07:00
Kevin Sawicki
19fd841c30
🎨
2016-05-23 15:14:55 -07:00
Kevin Sawicki
566b0676bc
Pre-resolve electron require path
2016-05-23 15:14:55 -07:00
Kevin Sawicki
daea448b61
.coffee -> .js
2016-05-23 15:14:55 -07:00
Cheng Zhao
4193fb1742
Merge pull request #5617 from electron/dont-return-from-on-functions
...
Remove returns from event listeners
2016-05-20 00:26:29 +00:00
Kevin Sawicki
cc7395eea8
Remove returns from event listeners
2016-05-19 15:28:08 -07:00
Juan Cruz Viotti
1a27ecdad4
Override child_process.execFile
asar patch for child_process.exec
...
NodeJS implements `child_process.exec` by simply passing the whole
command to `child_process.execFile`. See:
- https://github.com/nodejs/node/blob/master/lib/child_process.js#L90
- https://github.com/nodejs/node/blob/master/lib/child_process.js#L99
Electron patches `child_process.execFile` to add support for `asar`
archives by injecting logic that extracts the required files from the
`asar` to a temporary location before delegating the work to the
original `child_process.execFile`.
In order to decide whether to inject the custom `asar` extracting logic,
Electron makes use of a helper function called `splitPath()`. See:
- https://github.com/electron/electron/blob/master/lib/common/asar.js#L37
If the first argument of the returned array equals `true`, means that
the path is considered to be an `asar` archive, and thus the extraction
logic takes place. The problem is that if the command passed to
`child_process.execFile` *contains* a path to an asar archive, padded
with other commands/arguments, `splitPath()` will consider it to be an
`asar` archive, and will try to extract it, throwing a rightfully
`Invalid package` error.
Fixes: https://github.com/electron/electron/issues/5571
Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
2016-05-19 17:19:36 -04:00
Kevin Sawicki
d627ead273
Remove linter errors
2016-05-06 10:12:55 -07:00
Kevin Sawicki
16d4c436cb
Keep exporting deprecate/deprecations
2016-05-06 10:12:55 -07:00
Kevin Sawicki
2ce4237083
Remove hideInternalModules API
2016-05-06 10:12:54 -07:00
Kevin Sawicki
dafa14fe42
Don't export deprecate API
2016-05-06 10:12:54 -07:00
Kevin Sawicki
a6cf7a1095
Remove deprecated crashReporter.start options
2016-05-06 10:12:53 -07:00
Kevin Sawicki
dae68be2ce
Remove deprecated APIs
2016-05-06 10:12:53 -07:00
Felix Rieseberg
c0f63eed4e
🎨 Windows Store Camels
2016-04-21 19:11:25 -07:00
Felix Rieseberg
2a2a8d3263
Add Windows Store Detection
...
If we're running as a Windows Store appx package,
`process.windowsstore` will be `true`, otherwise
`undefined`.
2016-04-21 00:02:03 -07:00
Kevin Sawicki
732697a8a2
Rename ATOM_SHELL_ASAR to ELECTRON_ASAR
2016-04-08 08:53:58 -07:00
Kevin Sawicki
ce95747a25
atom.asar -> electron.asar
2016-04-01 16:12:12 -07:00
Zeke Sikelianos
6f845373a7
do not return and assign
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
42e7ee2b4a
finish standardizing!
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
e6698102c9
standardize by hand
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
c4b6cf4a8e
do more manual cleanup and specify globals
2016-03-30 17:00:32 -07:00
Zeke Sikelianos
3855a774ab
autoformat more easy files
2016-03-30 17:00:31 -07:00
Zeke Sikelianos
67fa250020
standardize asar.js by hand
2016-03-30 17:00:31 -07:00
Zeke Sikelianos
c845ea8372
autoformat more easy files
2016-03-30 17:00:31 -07:00
Zeke Sikelianos
80f7c82f93
finish standardizing crash reporter
2016-03-30 17:00:31 -07:00
Zeke Sikelianos
ca7b492b97
tiptoeing along, keeping the suite passing
2016-03-30 17:00:31 -07:00
Cheng Zhao
e5886dda9b
Avoid re-evaluating internal modules
2016-03-27 19:16:26 +09:00
Kevin Sawicki
4f4dc2f4d8
Use destructuring assigment
2016-03-22 13:11:42 -07:00
Kevin Sawicki
8889c29866
Use rest parameters
2016-03-18 11:51:02 -07:00
Kevin Sawicki
a3f08c9b51
Use arrow functions to replace old CoffeeScript => this wrappers
2016-03-11 11:25:56 -08:00
Kevin Sawicki
3a1e837f8b
Don't collect results in exit event callback
2016-03-11 08:55:47 -08:00
Kevin Sawicki
2e9fd7ce77
Update common api path
2016-03-08 11:22:13 -08:00
Kevin Sawicki
70aa9b06ee
Move JavaScript to root lib/ folder
2016-03-08 11:14:21 -08:00