Samuel Attard
777d0113d5
fix: create a window capturer correctly ( #13689 )
...
* fix: create a window capturer correctly
We were incorrectly creating two screen capturers instead of a window
capturer
* spec: ensure dc tests pass
* spec: enable all tests after verifying dc tests work
2018-07-17 14:20:50 +10:00
Shelley Vohr
6045d1218a
refactor: remove experimentalCanvasFeatures property ( #13684 )
2018-07-16 13:32:42 -07:00
Cheng Zhao
4a7c85f43e
fix: use InspectableWebContentsView as content view
2018-07-16 10:20:35 +09:00
John Kleinschmidt
539b554ecc
Merge pull request #13578 from electron/miniak/refactoring
...
refactor: statically link functions available on Windows 7+
2018-07-13 10:52:37 -04:00
Cheng Zhao
77ca5b7d64
fix: don't invoke callback after FrameSubscriber is destroyed ( #13657 )
2018-07-13 19:54:49 +10:00
Milan Burda
adaa32003d
refactor: DwmGetColorizationColor does not have to be dynamically resolved
2018-07-12 22:28:44 +02:00
Felix Rieseberg
deedf6c3f4
feat: Add isCurrentlyAudible() to WebContents ( #13614 )
...
* 🔧 Add isCurrentlyAudible() to WebContents
* ❤️ Implement feedback, use await to wait for event
* 👷 Add missing imports
2018-07-12 21:35:11 +10:00
Cheng Zhao
0ec4ad288d
fix: fallback to FullSizeContentView for frameless window on mac ( #13599 )
...
fix: draggable regions not working on macOS
2018-07-10 11:43:42 +10:00
Maxine Whitely
6cf68f8247
fix: tray setContextMenu crash ( #13513 )
...
Co-authored-by: Zhuo Lu <sethlu@mintkit.net>
Co-authored-by: Kristine Zhang <kzhang@slack-corp.com>
2018-06-29 14:48:26 -07:00
Jeremy Apthorp
3d4487ccfd
Merge pull request #13463 from electron/remove_wtl
...
refactor: Using win32 file open api instead of WTL
2018-06-29 10:00:50 -07:00
Jeremy Apthorp
733e495e91
chore: use full path for ui_unscaled_resources.h ( #13492 )
...
This is the path that resolves in Chromium, it also works fine in the gyp build.
2018-06-28 14:41:37 -07:00
Jeremy Apthorp
d6af3bfcd2
chore: fix more chromium-style errors in windows code ( #13487 )
...
Finding more chromium-style linting errors as I build more of the windows code :)
2018-06-28 14:20:11 -07:00
Shelley Vohr
003a92e099
refactor: remove deprecated GetAs methods ( #13425 )
...
* refactor: remove deprecated GetAs methods
* restructure URLRequestAsyncAsarJob on win
* fix: add string conversion header
2018-06-27 14:52:48 -07:00
Samuel Attard
92588be2bd
refactor: add promise helper and change whenReady to be native impl ( #13115 )
...
* Add promise helper and change whenReady to be native impl
* remove commented code
* add GetInner helper to dedupe promise code
* add Promise.reject helper to be consistent with JS
* fix linting
* update promise impl per feedback
* remove param name from unused isolate
* Use non-depreceated resolvers for promises
* Add thread dchecks for promise helper, intiialize promise pointer to nullptr
2018-06-27 16:06:08 -05:00
zacwalk
9db76394f7
Link gdi from gyp
2018-06-27 20:58:37 +02:00
Zac Walker
8151c90c6b
Fix warnings as error fixes.
2018-06-27 16:28:12 +02:00
Zac Walker
f122c44b07
Using win32 file open dialogs instead of WTL
2018-06-27 13:09:18 +02:00
Jeremy Apthorp
4b60efcaf8
chore: [gn] fix WTL include paths and namespace include ( #13433 )
...
As of libchromiumcontent#576, the WTL namespace isn't included by
default in the GN build.
2018-06-26 22:57:40 +02:00
Jeremy Apthorp
78bc1081fd
chore: fix some more warnings in windows build ( #13431 )
...
Remove an unused function and fix an int type comparison warning. Only showed up when building with GN.
2018-06-26 02:00:20 +02:00
Jeremy Apthorp
6f91af9343
chore: fix various chromium-style errors in windows ( #13394 )
...
These errors weren't previously picked up because the GN build wasn't running on Windows.
2018-06-25 22:30:00 +02:00
deepak1556
5e2406081e
build: move pepper flash behind feature flag
2018-06-21 17:02:12 +05:30
Jeremy Apthorp
8ccb5cc6eb
chore: Annotate fallthrough switch paths with FALLTHROUGH
...
The compiler was throwing errors about unannotated fallthroughs when
building with GN.
2018-06-20 14:38:18 -07:00
Jeremy Apthorp
3f40e93ba7
chore: fix chromium-style errors in frame_subscriber
...
The chromium-style linter we run in the GN build was throwing errors
about these issues.
2018-06-20 14:14:11 -07:00
Milan Burda
122d00f415
Revert "Drop support of Mac OS 10.9" ( #13348 )
...
This reverts commit efa0ec0263481ae188f206625bec6f4a4e5d3ecf.
2018-06-20 13:40:18 -07:00
Samuel Attard
79fbd6bab1
Revert "fix: Drop support for OS X Mavericks (version 10.9)" ( #13333 )
2018-06-20 07:27:55 -05:00
Husayn
1a8c986fb1
set mac protocol to none ( #13302 )
2018-06-20 13:16:37 +10:00
Shelley Vohr
c20e0c30a2
src: base::Value::HasKey(key) => base::Value::FindKey(key) ( #13312 )
2018-06-20 13:07:10 +10:00
John Kleinschmidt
04a7a34c42
Merge pull request #13301 from electron/revert-frame-sub-deprecation
...
fix: revert frame subscriber deprecation and re-enable tests
2018-06-19 14:26:14 -04:00
Heilig Benedek
f643ce4f66
revert: frame subscriber deprecation and re-enable tests
2018-06-19 19:49:44 +02:00
John Kleinschmidt
d367b75680
Merge pull request #13296 from electron/miniak/drop-macos-10.9
...
fix: Drop support for OS X Mavericks (version 10.9)
2018-06-19 13:19:24 -04:00
Milan Burda
794fe741e9
fix: Drop support for OS X Mavericks (version 10.9)
2018-06-19 17:49:27 +02:00
Justin Guze
137aaf2429
fix: pass down the bool value of enableAutoSize to setSize ( #13282 )
...
* fix: pass the boolean value of enableAutoSize to setSize
The webContents setSize API takes in an optional enableAutoSize boolean.
Looking in the code, if that property is set, regardless if you pass in
true or false, it will always set it to true. This change passes the
appropriate boolean value down properly.
* creating new bool for autosize
2018-06-19 10:38:55 -05:00
Jeremy Apthorp
9e8f83e25c
refactor: fix chromium-style in url_request_asar_job ( #13284 )
2018-06-19 10:31:55 -05:00
Milan Burda
d5d5386017
use std::make_unique<T>
2018-06-19 10:20:39 +02:00
Samuel Attard
2720fa751b
Fix windows desktop_capturer build
2018-06-19 15:29:16 +10:00
Samuel Attard
9d18be8fde
Remove removed variable popup_bounds_in_view_
2018-06-19 11:58:26 +10:00
Samuel Attard
5a28759fea
post all desktop capturer apis to worker threads
2018-06-19 11:49:46 +10:00
Samuel Attard
8200a132be
Re-enable cookie specs and add custom cookie name/url validation
2018-06-19 11:49:46 +10:00
Aleksei Kuzmin
f4a9575193
Drop support of Mac OS 10.9
...
- set minimum deployment target to 10.10
- set minimum system version to 10.10
2018-06-19 11:49:45 +10:00
Heilig Benedek
65b8dd48d8
Update OSR code
2018-06-19 11:49:44 +10:00
Heilig Benedek
60ba2013c4
Re-add dirtyOnly to FrameSubscriber and document API change
2018-06-19 11:49:44 +10:00
Heilig Benedek
b9413fe59d
Update FrameSubscriber implementation
2018-06-19 11:49:44 +10:00
Nitish Sakhawalkar
ca8843102a
Fix duplicate RTCDispatcher console error for debug build.
...
The solution was to call CreateScreenCapturer from content, and not link the static library in.
2018-06-19 11:49:44 +10:00
Aleksei Kuzmin
90c3d87e21
Rename LocalSurfaceIdAllocator
...
https://chromium-review.googlesource.com/809886
2018-06-19 11:49:44 +10:00
Tomas Rycl
1ac0ab2b71
Include missing "windows.h" and fix headers ordering
...
For PCWSTR on line 198.
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
d6ffbc0148
Use an int for wm::ShadowElevation. Pick semantic constants.
...
https://chromium-review.googlesource.com/899886
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
4a38c2d800
Remove deprecated View::SetLayoutManager
...
https://chromium-review.googlesource.com/844760
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
f6648a0d4d
Remove ScopedComPtr and scoped_comptr.h
...
https://chromium-review.googlesource.com/726461
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
82d204e932
Wrap X11 headers in ui/gfx/x/x11.h
...
https://chromium-review.googlesource.com/756711
2018-06-19 11:49:43 +10:00
Heilig Benedek
1de1ca906a
Reimplement FrameSubscriber with mojo VideoCapture APIs
2018-06-19 11:49:43 +10:00