mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 2
8763 commits 1 branch 364 tags 3.8 GiB
Commit graph

8763 commits

This branch
This branch
All branches
Author SHA1 Message Date
Juan Cruz Viotti
1a27ecdad4 Override child_process.execFile asar patch for child_process.exec 
NodeJS implements `child_process.exec` by simply passing the whole
command to `child_process.execFile`. See:

- https://github.com/nodejs/node/blob/master/lib/child_process.js#L90
- https://github.com/nodejs/node/blob/master/lib/child_process.js#L99

Electron patches `child_process.execFile` to add support for `asar`
archives by injecting logic that extracts the required files from the
`asar` to a temporary location before delegating the work to the
original `child_process.execFile`.

In order to decide whether to inject the custom `asar` extracting logic,
Electron makes use of a helper function called `splitPath()`. See:

- https://github.com/electron/electron/blob/master/lib/common/asar.js#L37

If the first argument of the returned array equals `true`, means that
the path is considered to be an `asar` archive, and thus the extraction
logic takes place. The problem is that if the command passed to
`child_process.execFile` *contains* a path to an asar archive, padded
with other commands/arguments, `splitPath()` will consider it to be an
`asar` archive, and will try to extract it, throwing a rightfully
`Invalid package` error.

Fixes: https://github.com/electron/electron/issues/5571
Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
 2016-05-19 17:19:36 -04:00
Cheng Zhao
242508e22f Merge pull request #5574 from electron/devtools-extension-test 
Add test that loads a devtools extension
 2016-05-18 01:46:44 +00:00
Cheng Zhao
5368da18ad Merge pull request #5575 from electron/link-to-spectron 
Add spectron to ChromeDriver doc
 2016-05-18 01:34:56 +00:00
Cheng Zhao
397d0e34ee Merge pull request #5559 from electron/disable-webview 
Disable webview when nodeIntegration is off
 2016-05-18 01:26:58 +00:00
Cheng Zhao
27da0f3338 Merge pull request #5576 from electron/title-tweaks 
Tweak doc headings
 2016-05-18 01:26:27 +00:00
Cheng Zhao
c7f5210b50 Merge pull request #5567 from felixrieseberg/versioning 
Add Information about Versioning
 2016-05-18 00:43:23 +00:00
Cheng Zhao
7bd11c14f6 Update brightray to fix linking problem on Linux 2016-05-18 09:42:38 +09:00
Kevin Sawicki
cee31ff67a Remove semicolon 2016-05-17 16:42:37 -07:00
Kevin Sawicki
9266f9abfc Update interval id variable name 2016-05-17 16:42:21 -07:00
Kevin Sawicki
f95c46d987 Show last panel by id 2016-05-17 16:40:34 -07:00
Kevin Sawicki
866260a2a6 with -> on 2016-05-17 16:05:47 -07:00
Kevin Sawicki
bfb75df49c Tweak doc headings 2016-05-17 16:02:54 -07:00
Kevin Sawicki
b301c473cd Simplify sentence 2016-05-17 15:14:50 -07:00
Kevin Sawicki
3f3871b1be Add spectron section 2016-05-17 15:13:26 -07:00
Kevin Sawicki
2043356fa3 Recommend electron-chromedriver 2016-05-17 15:09:09 -07:00
Kevin Sawicki
13cfc2d2a0 Add comment about panel switching via input event 2016-05-17 15:05:58 -07:00
Kevin Sawicki
8d0c5c30b8 Use consistent function styles 2016-05-17 15:05:27 -07:00
Kevin Sawicki
0b4b79d0a4 Use control on non-mac platforms 2016-05-17 15:01:32 -07:00
Kevin Sawicki
7db2601ea8 DRY up specs 2016-05-17 14:59:33 -07:00
Kevin Sawicki
77b074fbad Add spec for undocked devtools 2016-05-17 14:56:00 -07:00
Kevin Sawicki
189380d4ea Add spec for devtools extension 2016-05-17 14:52:45 -07:00
Felix Rieseberg
7e09b1664a 📝 Add Information about Versioning 2016-05-17 20:20:25 +02:00
Cheng Zhao
fb6f5320e7 Update brightray for #5348 2016-05-17 20:33:44 +09:00
Cheng Zhao
7ce87c470a docs: webview is only available with nodeIntegration on 2016-05-17 17:10:33 +09:00
Cheng Zhao
90f52169af No more need to check for nodeIntegration when creating guest view 2016-05-17 17:06:02 +09:00
Cheng Zhao
0140015500 spec: WebView is disabled when nodeIntegration is disabled 2016-05-17 17:04:13 +09:00
Cheng Zhao
c1399f9bdc Disable webview when nodeIntegration is off 2016-05-17 16:51:06 +09:00
Cheng Zhao
3fedea4b9e Merge pull request #5557 from electron/osx-buttons 
Implement titleBarStyle without using NSFullSizeContentViewWindowMask
 2016-05-17 16:48:45 +09:00
Cheng Zhao
13bfb099a2 Fix the toolbar showing when titleBarStyle is hidden-inset 2016-05-17 16:25:18 +09:00
Cheng Zhao
f53aabaef5 Implement titleBarStyle without using NSFullSizeContentViewWindowMask 2016-05-17 15:48:14 +09:00
Cheng Zhao
ecbb088ea6 Merge pull request #5542 from stevekinney/standardize-requires 
Standardize requires
 2016-05-16 10:42:12 +09:00
Cheng Zhao
f5442a4888 Merge pull request #5540 from kcrt/master 
Update: Japanese version of MAS submission guide
 2016-05-16 10:33:25 +09:00
Cheng Zhao
57f082055a Merge pull request #5509 from electron/bengotow/dialog-titles 
Add buttonLabel param to showOpen/showSave dialogs
 2016-05-16 10:27:28 +09:00
Cheng Zhao
e53bfad018 Fix building on Windows 2016-05-16 10:09:41 +09:00
Steve Kinney
0d3d097ce8 💄 Standarize requires in JavaScript API 2016-05-15 09:41:30 -04:00
Steve Kinney
2317b56ac4 💄 Make the power-save-blocker a bit more concise 2016-05-15 09:36:13 -04:00
TAKAHASHI Kyohei
16c870191f
Update: Japanese version of MAS submission-guide 2016-05-15 15:42:35 +09:00
Ben Gotow
54c654530e Fix linux support 2016-05-15 01:29:13 -05:00
Ben Gotow
6217d497ed Fix build issues 2016-05-15 01:03:32 -05:00
Ben Gotow
84cce6c2c1 Don't default to "Open", "Save", just let OS decide 2016-05-15 01:03:32 -05:00
Ben Gotow
40c531737d Add buttonLabel param to showOpen/showSave dialogs 2016-05-15 01:03:32 -05:00
Cheng Zhao
88f3c34412 Merge pull request #5532 from stevekinney/patch-2 
💄 Use ES6; clean up CoffeeScript conversion in BrowserWindow module
 2016-05-15 12:38:28 +09:00
Steve Kinney
fd9c9c3be7 💄 Use spread operator instead of arguments object 2016-05-14 22:33:21 -04:00
Steve Kinney
236810a923 💄 Use ES6; clean up CoffeeScript conversion 
💄 Destructure app module

Address linting errors
 2016-05-14 22:33:20 -04:00
Cheng Zhao
88dc73ec3f Merge pull request #5533 from stevekinney/patch-3 
💄 Destructure globalShortcut module
 2016-05-15 11:16:19 +09:00
Cheng Zhao
195a4bb3c1 Merge pull request #5538 from electron/vs2015-runtime 
Ship with runtime libraries of Visual Studio 2015
 2016-05-15 11:15:49 +09:00
Cheng Zhao
c540721bd3 Merge pull request #5537 from electron/suppress-more-tests 
Suppress the tests that need to call window.open on Travis CI
 2016-05-15 11:15:42 +09:00
Steve Kinney
c11d18fe06 💄 Destructure globalShortcut module 
💄 Remove globalShortcut property

Add back the globalShortcut property
 2016-05-14 21:53:42 -04:00
Cheng Zhao
8ed3659bb8 Link with libraries of Visual Studio 2015 2016-05-15 10:41:43 +09:00
Cheng Zhao
ba7a32b16e Sync submodule recursively 2016-05-15 10:33:23 +09:00