Kevin Sawicki
29a3e11893
Group sheet event methods with other macOS methods
2017-04-20 10:32:14 -07:00
Brendan Forster
dca08c208b
and use the same signature for Windows
2017-04-20 14:21:08 +10:00
Hari Krishna Reddy Juturu
fe88697348
fixup! fixup! Adding cookie flush store api
2017-04-18 09:05:13 -07:00
Hari Krishna Reddy Juturu
19709a50e9
Adding cookie flush store api
2017-04-18 09:05:13 -07:00
Ryohei Ikegami
8dff29185b
Merge branch 'master' into native-window-open
2017-04-18 21:59:22 +09:00
Alexandre Lachèze
9aff17afea
👕 alphabetical order
2017-04-18 13:44:31 +02:00
Alexandre Lachèze
f375e8a7db
Add OS process id to web-contents
2017-04-18 12:31:20 +02:00
Yuya Ochiai
75184046f6
Add events to manage sheets of macOS BrowserWindow
2017-04-15 16:26:45 +09:00
Ryohei Ikegami
ea6890aa5c
Use const
2017-04-13 23:26:42 +09:00
Ryohei Ikegami
9d62b196d3
Use base::FilePath
2017-04-13 10:59:12 +09:00
Birunthan Mohanathas
06fcf2c19d
Add support for BrowserView autoresizing
2017-04-13 01:27:31 +03:00
Birunthan Mohanathas
8b9f7e5b00
Implement initial, experimental BrowserView API
...
Right now, `<webview>` is the only way to embed additional content in a
`BrowserWindow`. Unfortunately `<webview>` suffers from a [number of
problems](https://github.com/electron/electron/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aopen%20label%3Awebview%20 ).
To make matters worse, many of these are upstream Chromium bugs instead
of Electron-specific bugs.
For us at [Figma](https://www.figma.com ), the main issue is very slow
performance.
Despite the upstream improvements to `<webview>` through the OOPIF work, it is
probable that there will continue to be `<webview>`-specific bugs in the
future.
Therefore, this introduces a `<webview>` alternative to called `BrowserView`,
which...
- is a thin wrapper around `api::WebContents` (so bugs in `BrowserView` will
likely also be bugs in `BrowserWindow` web contents)
- is instantiated in the main process like `BrowserWindow` (and unlike
`<webview>`, which lives in the DOM of a `BrowserWindow` web contents)
- needs to be added to a `BrowserWindow` to display something on the screen
This implements the most basic API. The API is expected to evolve and change in
the near future and has consequently been marked as experimental. Please do not
use this API in production unless you are prepared to deal with breaking
changes.
In the future, we will want to change the API to support multiple
`BrowserView`s per window. We will also want to consider z-ordering
auto-resizing, and possibly even nested views.
2017-04-13 01:27:27 +03:00
Kevin Sawicki
e7b679ead6
Add IsEmpty helper and remove GetInstance public usage
2017-04-11 09:09:17 -07:00
Kevin Sawicki
0883a9f966
Use CloseAllWindows helper
2017-04-11 09:09:17 -07:00
Ryohei Ikegami
34ed1a9ef8
Track child web contents
2017-04-06 12:15:27 +09:00
Ryohei Ikegami
526086d900
Improve RootWebContentsTracker
2017-04-06 11:37:21 +09:00
Samuel Attard
60cc862031
Make everything pointer like
2017-04-04 12:50:41 -07:00
Samuel Attard
4d6b0fc01b
Add a method to set the escape identifier on the touch bar
2017-04-04 12:50:41 -07:00
Kevin Sawicki
3e9014c371
Merge pull request #9099 from electron/certificate-trust
...
macOS: Add certificate trust API
2017-04-04 11:17:09 -07:00
joshaber
8d465234e4
Appease our linty overlords
2017-04-03 21:40:46 -04:00
joshaber
2badfbe04f
Remove the intermediate function
2017-04-03 21:22:37 -04:00
Ryohei Ikegami
4a7eec8f2d
Pass app path as command line argument
2017-04-04 09:36:01 +09:00
joshaber
74c0cbddae
Linebreak to keep the linter happy
2017-04-03 16:07:02 -04:00
joshaber
11f5c942ce
Conditionalize
2017-04-03 15:25:09 -04:00
joshaber
bcecba20e6
Fix indentation
2017-04-03 15:09:24 -04:00
joshaber
4ffaf2cd99
Remove old unnecssary change on app
2017-04-03 15:09:04 -04:00
joshaber
6e89cb9d7c
Move it into dialog
2017-04-03 15:05:24 -04:00
joshaber
4bbbcd093b
Handle the callback and cleanup properly
2017-04-03 14:01:48 -04:00
joshaber
1ed443ea29
Do the callback & release dance
2017-04-03 13:21:44 -04:00
Kevin Sawicki
f5a75c4e87
Merge pull request #9076 from electron/cleanup-cpp
...
Cleanup cpp codebase
2017-04-03 08:30:08 -07:00
joshaber
4f3d3557cc
Notify that the cert changed
2017-03-31 21:51:29 -04:00
Haojian Wu
8ae91682cb
Lines should be <= 80 characters.
2017-03-31 20:09:13 +02:00
joshaber
16cc79354c
Errrrybody's a scoped_refptr now
2017-03-31 13:53:42 -04:00
joshaber
653b2d15c3
Expose the certificate trust panel as part of app
2017-03-30 17:25:55 -04:00
joshaber
64369cd07f
Show a certificate trust panel
2017-03-30 17:25:44 -04:00
Haojian Wu
e8abee9ca9
Replace C-style casts with static_cast.
2017-03-30 23:05:47 +02:00
Haojian Wu
1b9780035c
Remove redundant calls to smart pointer's get method.
2017-03-30 22:22:40 +02:00
Haojian Wu
00693ba075
Replace "size()" with "empty()".
2017-03-30 21:59:18 +02:00
Haojian Wu
5f724e57bc
Avoid unnecessary copy of parameters.
2017-03-29 22:06:07 +02:00
deepak1556
3ae62615f4
net: allow controlling redirects
2017-03-28 18:46:21 +05:30
deepak1556
4ab2c92418
CommonWebContentsDelegate::DestroyWebContents => ResetManagedWebContents
2017-03-22 07:30:36 +05:30
deepak1556
72adbf7a2f
destroy guest webcontents before embedder
2017-03-19 10:25:13 +05:30
John Kleinschmidt
d5a658bbe4
Fixed pass by reference and added spec
2017-03-08 22:06:26 -05:00
John Kleinschmidt
1c2a78a896
Add WebRTCIPPolicy setting to webContents and webview
...
Resolves #8777
Code to set and get the policy come from the muon framework code:
https://github.com/brave/muon/blob/master/atom/browser/api/atom_api_web_
contents.cc#L1324...L1343
2017-03-08 10:15:48 -05:00
Kevin Sawicki
f549bda9fc
Merge pull request #8799 from nitsakh/baseURLForDataURL
...
Support base URL option to loadURL for data URLs
2017-03-06 10:25:53 -08:00
Kevin Sawicki
886b47e713
Merge pull request #8724 from electron/defer_load_url
...
webContents: defer url load when there is a pending navigation entry
2017-03-06 10:18:36 -08:00
Kevin Sawicki
479af3c9e2
Merge pull request #8678 from liusy182/download-item
...
only emit `download-item done` event once
2017-03-06 10:11:22 -08:00
deepak1556
e936143da2
listen for browser initiated pending nav entries too
2017-03-06 00:21:52 +05:30
deepak1556
dead1ae1ba
webContents: defer url load when there is a pending navigation entry
2017-03-06 00:10:46 +05:30
Kevin Sawicki
51f1c5a557
Use SetTouchBar withe empty vector instead of DestroyTouchBar
2017-03-03 14:00:39 -08:00
Kevin Sawicki
823b3baed0
Use vector of dictionaries instead of mate::Arguments
2017-03-03 14:00:38 -08:00
Kevin Sawicki
98f5858b11
Initial support for dynamic properties
2017-03-03 14:00:38 -08:00
Kevin Sawicki
cbb6f8c33e
Store event listeners in each TouchBar class
2017-03-03 14:00:38 -08:00
Samuel Attard
dd09c91cf2
initial work on updating touch bar item config without rerender
2017-03-03 14:00:38 -08:00
Samuel Attard
d1b3ba39bd
Fix cpp linting
2017-03-03 14:00:38 -08:00
Samuel Attard
18c7c3ece8
Make label and colorpicker types work
2017-03-03 14:00:38 -08:00
Samuel Attard
7857c83ea1
Make dynamic buttons work along with click events
2017-03-03 14:00:38 -08:00
Samuel Attard
703b5738c8
Initial TouchBar Magic
...
* Make the AtomNSWindow also a NSTouchbarDelegate
* Implement basic makeTouchBar and makeItemForIdentifier methods
* Initial sending of touch / update events through IPC to BrowserWindowObjects
TODO:
* JS API
* JS Object Converters
* Generalize methods so that popovers can work
2017-03-03 14:00:38 -08:00
Nitish Sakhawalkar
bcda67b8eb
No more extra whitespace.
2017-03-02 10:50:48 -08:00
Nitish Sakhawalkar
c06c4c0ccb
Reverting formatting changes made by clang format.
2017-03-01 14:04:41 -08:00
Nitish Sakhawalkar
879082b1a6
Issue #8735:Support base URL option to loadURL for data URLs
2017-02-28 16:49:03 -08:00
liusi
ff513f2a84
remove the call to download_item_->Remove() on cancel
2017-02-24 14:08:21 +08:00
Kevin Sawicki
a8d1a7aed4
Make variables private instead of protected
2017-02-22 10:30:28 -08:00
Kevin Sawicki
2006e22aa4
🎨
2017-02-22 10:30:28 -08:00
Kevin Sawicki
ce5ac1b056
Implement ClosePopupAt on Windows/Linux
2017-02-22 10:30:28 -08:00
Kevin Sawicki
91d1af053f
Implement Menu.closePopup on Windows/Linux
2017-02-22 10:30:28 -08:00
Kevin Sawicki
6a023dc4fe
Add Menu.closePopup API on macOS
2017-02-22 10:30:28 -08:00
Kevin Sawicki
66b6b4f1cb
Map async option to MenuRunner::ASYNC flag
2017-02-22 10:30:28 -08:00
Kevin Sawicki
4430927f98
Add async option to menu.popup
2017-02-22 10:30:28 -08:00
Kevin Sawicki
b091d104f5
Add async menu.popup on Windows/Linux
2017-02-22 10:30:28 -08:00
Kevin Sawicki
636ef0fd29
Add async menu.popup on macOS
2017-02-22 10:30:28 -08:00
deepak1556
203a920c64
fix signature of zoom getter apis
2017-02-18 01:34:32 +05:30
deepak1556
5687f8b3b7
Destroy icon manager after file thread is destroyed
2017-02-17 14:16:18 +05:30
Yury Solovyov
977abc6458
Update icon loading API implementation
2017-02-16 23:16:34 +03:00
Kevin Sawicki
36e6501c44
Rename variable for compiler error
2017-02-14 12:30:23 -08:00
Kevin Sawicki
9be42db8d5
Merge pull request #8628 from Spacetech/master
...
Implement invalidate for non-offscreen mode
2017-02-14 11:41:16 -08:00
Kevin Sawicki
5cb6648686
Use underscore variable name for consistency
2017-02-14 11:12:30 -08:00
Kevin Sawicki
82f452568c
🎨 Minor formatting tweaks
2017-02-14 11:09:15 -08:00
liusi
d56c1909df
only emit download-item done
event once.
2017-02-14 14:39:33 +08:00
Gary Wilber
f19924bcb0
Add Invalidate method to NativeWindow and add Mac implementation
2017-02-13 19:41:24 -08:00
deepak1556
7a0aff2bae
code cleanup
2017-02-12 01:48:24 +05:30
deepak1556
cbeaa6be87
simply handling temporary zoom levels of webview
2017-02-12 00:49:17 +05:30
deepak1556
e3fe3cc490
map webframe zoom api to use HostZoomMap
2017-02-12 00:49:17 +05:30
deepak1556
63c0e4cbb1
Add ZoomController to manager zoom changes for webcontents
2017-02-12 00:49:17 +05:30
deepak1556
07794a58aa
use zoom factor webpreference option when required.
...
* When setzoomlevel is not called for the host.
* When there is no zoom preference for the host.
2017-02-12 00:49:17 +05:30
deepak1556
b27c94368d
webContents: set zoom levels with HostZoomMap
2017-02-12 00:49:17 +05:30
Kevin Sawicki
f7f4de36af
Merge remote-tracking branch 'origin/master' into macos-open-save-panel
2017-02-09 11:25:05 -08:00
Kevin Sawicki
867bb5a94e
Add DialogSettings helper struct
2017-02-09 10:13:11 -08:00
Birunthan Mohanathas
c8c11e68c6
Add support for checkbox with dialog.showMessageBox
...
This adds the `checkboxLabel` and `checkboxChecked` options to display a
checkbox in the message box. Fixes #6048 .
2017-02-09 09:03:54 -08:00
Tan Wang Leng
a4a71a1dc9
Change qualifier of ShowSaveDialog() parameter
...
The normal convention in the codebase is to not use references
or 'const' for primitives like 'bool' and 'int'.
2017-02-09 21:50:55 +08:00
Tan Wang Leng
36209ddd90
🍎 Add additional options for Mac's open dialog
...
Support an additional attributes available in macOS's NSOpenPanel:
message.
2017-02-09 20:10:57 +08:00
Tan Wang Leng
1d612a12a1
🍎 Add additional options for Mac's save dialog
...
Support additional attributes available in macOS's NSSavePanel: message,
nameFieldLabel and showsTagField
2017-02-09 20:10:57 +08:00
Kevin Sawicki
1e581d6814
Use unique_ptr for passing VerifyRequestParams
2017-02-08 11:59:43 -08:00
Kevin Sawicki
70178adb6e
Use object for verification request
2017-02-08 11:59:43 -08:00
Greg Nolle
e29b64a18a
modify CertVerifier Class
...
* respond to multiple similar verification requests.
* accept net error result as callback response.
2017-02-08 11:59:43 -08:00
Gary Wilber
11e1f6b56c
Fix lint errors
2017-02-08 00:05:16 -08:00
Gary Wilber
ed44b32ff5
Convert indentation to spaces
2017-02-07 23:08:03 -08:00
Gary Wilber
148898fb75
Implement invalidate for non-offscreen mode
2017-02-07 23:03:42 -08:00
Yury Solovyov
bcf0964c61
Fix more review
2017-02-07 09:55:18 -08:00
Yury Solovyov
29452364f3
Use isolate() method to get isolate
2017-02-07 09:54:22 -08:00
Yury Solovyov
c2bf5bb986
Put locker and handle scope to the top of the function. Remove unneeded header
2017-02-07 09:53:34 -08:00
Yury Solovyov
5794138ed4
Normalize path
2017-02-07 09:53:34 -08:00
Yury
1b4ee6e0d8
Image from icon node-style callback ( #2 )
...
* Try implementing node-style callbacks
* Add locker and handle scope
2017-02-07 09:53:34 -08:00
deepak1556
2e85ff1f57
Fix code style
2017-02-07 09:53:34 -08:00
Yury Solovyov
3d47c9b71d
Fix lint
2017-02-07 09:53:34 -08:00
Yury Solovyov
05cb26a174
Use object for options
2017-02-07 09:53:34 -08:00
Yury Solovyov
bec671bac8
Make size optional
2017-02-07 09:52:11 -08:00
Robo
b25b141642
create iconmanager as singleton class and cleanup code ( #1 )
...
* create iconmanager as singleton class and cleanup code
2017-02-07 09:52:11 -08:00
renaesop
26135b412b
Merge remote-tracking branch 'upstream/master'
...
# Conflicts:
# atom/browser/api/atom_api_web_contents.cc
# chromium_src/chrome/browser/printing/print_job_worker.cc
# chromium_src/chrome/browser/printing/print_job_worker.h
# chromium_src/chrome/browser/printing/print_view_manager_base.cc
# chromium_src/chrome/browser/printing/print_view_manager_base.h
# chromium_src/chrome/browser/printing/printer_query.cc
# chromium_src/chrome/common/print_messages.cc
# chromium_src/chrome/renderer/printing/print_web_view_helper.cc
2017-02-07 09:30:36 +08:00
Cheng Zhao
86215d4300
Allow filter to use any scheme
2017-02-06 10:34:30 -08:00
Cheng Zhao
75627ba6ad
Fix sync printing not working
2017-02-06 10:34:29 -08:00
Cheng Zhao
820c0827c0
Fix cpplint warnings
2017-02-06 10:34:29 -08:00
Cheng Zhao
6165d36351
There is a new INSERTED type of ChangeCause
...
For the purpose of compatibility, we treat it as "explicit".
2017-02-06 10:34:29 -08:00
Cheng Zhao
6763977316
Update URLPattern to its latest version
2017-02-06 10:34:29 -08:00
Cheng Zhao
234e1bb811
base::Bind now prevents the case with no arguments
2017-02-06 10:34:29 -08:00
Cheng Zhao
411696ca19
Clear is replaced with ClearEntriesAddedWithin
2017-02-06 10:34:29 -08:00
Cheng Zhao
4a14b17255
WindowOpenDisposition has become enum class
2017-02-06 10:34:29 -08:00
Cheng Zhao
6d323dd6fe
web/WebInputEvent.h is moved to platform/WebInputEvent.h
2017-02-06 10:34:29 -08:00
Cheng Zhao
5cf2873b77
net::FtpProtocolHandler has changed its constructor
2017-02-06 10:34:29 -08:00
Cheng Zhao
13a1d79ca6
Deperecate AtomSecurityStateModelClient with SecurityStateTabHelper
2017-02-06 10:34:28 -08:00
Cheng Zhao
1d29b23662
Update api::WebContents
2017-02-06 10:34:28 -08:00
Cheng Zhao
231173aa90
Namespace of ChangeCause has changed
2017-02-06 10:34:28 -08:00
Cheng Zhao
d4e3dade39
WindowCapturer and ScreenCapturer are merged to DesktopCapturer
2017-02-06 10:34:28 -08:00
Cheng Zhao
c10eb73166
Signature of OnCreateWindow has changed
2017-02-06 10:34:28 -08:00
Cheng Zhao
d8e9432b0d
contentTracing.setWatchEvent/cancelWatchEvent is removed
2017-02-06 10:34:28 -08:00
Kevin Sawicki
e2501a80e4
Add path and args to LoginItemSettings struct
2017-02-06 08:34:35 -08:00
renaesop
023a3fd547
Print enhancement: add webContents.printerList And a print option to select printer
2017-02-06 17:18:04 +08:00
Kevin Sawicki
5973aa36ad
Initialize color listener after app is ready
2017-02-03 09:00:18 -08:00
Kevin Sawicki
dc1c11a841
Merge pull request #8487 from leethomas/feature/osx-relative-window-levels
...
Feature/macOS relative window levels
2017-01-30 15:34:24 -08:00
Kevin Sawicki
e683f28e32
Require a non-empty drag image to prevent crash
2017-01-26 15:46:04 -08:00
Kevin Sawicki
8ce1930f0d
Add specs for missing startDrag options
2017-01-26 15:46:04 -08:00
leethomas
1f5518b91e
throw an error for out of bounds window levels
2017-01-24 20:14:09 -08:00
leethomas
7a0a87a6f3
implement relative window levels, closes #8153
2017-01-23 23:42:33 -08:00
deepak1556
f9dc08baf6
emit did-fail-load event when the url char length exceeds limit
2017-01-21 14:59:20 +05:30
deepak1556
54559f99a0
Fix dereferencing nullptr
...
RenderWidgetHostView might not be available when
the navigator fails to load a url.
2017-01-21 14:56:58 +05:30
Kevin Sawicki
443040e8d7
Call InspectElement directly on InspectableWebContents
2017-01-19 09:05:59 +02:00
Kevin Sawicki
d6eb0d6629
Implement insertCSS on webFrame
2017-01-19 09:05:59 +02:00
Cheng Zhao
497f5a1199
Update files for Chrome 54 API changes
2017-01-19 09:05:59 +02:00
Kevin Sawicki
8f63fdb278
Destroy web contents when preventing default
2017-01-12 10:28:08 -08:00
Kevin Sawicki
fc75080c28
Merge pull request #8298 from electron/configure-throttling-on-created-callback
...
Configure background throttling on RenderViewCreated callback
2016-12-29 13:31:09 -08:00
Kevin Sawicki
6ea1bacc73
Merge pull request #8250 from gerhardberger/osr-window-size-fix
...
Always create offscreen window frameless
2016-12-29 09:10:14 -08:00
Kevin Sawicki
41afeb744a
Configure background throttling on RenderViewCreated callback
2016-12-28 15:52:47 -08:00
Kevin Sawicki
1308f790ad
Don't load URL if web contents is destroyed
2016-12-28 13:40:06 -08:00
gellert
f81908711b
use only one if statement
2016-12-21 23:15:05 +01:00
gellert
1ef0f6beff
creates offscreen window frameless
2016-12-20 23:43:52 +01:00
Kevin Sawicki
2a8b36c761
Merge pull request #8134 from deepak1556/empty_client_certificate_patch
...
app: select-client-certificate event callback can accept certificate optionally
2016-12-15 08:31:12 -08:00
Kevin Sawicki
590bde5e14
Remove unused include
2016-12-13 16:00:37 -08:00
Kevin Sawicki
7842040d9d
Add ToV8 converter for NativeWebKeyboardEvent
2016-12-13 15:54:13 -08:00
Kevin Sawicki
3237c6751a
Use DCHECK instead of assert
2016-12-13 15:54:13 -08:00
Birunthan Mohanathas
a3b65ad481
Add before-input-event event for webContents ( fixes #7586 )
...
Embedding arbitrary web content is problematic when it comes to keyboard
shortcuts because:
* Web content can steal app shortcuts (see e.g. brave/browser-laptop#4408 )
* Blocked web content (e.g. a focused <webview> performing expensive
computation) will also prevent app shortcuts from firing immediately
The new before-input-event event can be used to overcome these issues by
always handle certain keyboard events in the main process.
Note that this requires electron/brightray#261 to compile.
2016-12-13 15:54:13 -08:00