TechnicalSoup
0ea296b1cb
docs: specify string values for DownloadItem
...
Explicitly list the possible string return values for the updated and done events so that the typescript declaration file can model them more accurately. At present they are represented as a string type.
Fixes : https://github.com/electron/electron-typescript-definitions/issues/71
2018-01-03 13:34:19 +11:00
Cheng Zhao
249bd41e11
Merge pull request #11546 from electron/menu-callback
...
Add callback parameter for Menu.popup
2018-01-02 16:20:58 +09:00
Cheng Zhao
d04ae88426
The RenderWidgetHostView might not be available when showing menu
2018-01-01 19:37:59 +09:00
Cheng Zhao
bc61f2eafa
Copy the callback instead of reference
...
I don't really see how this could be a problem, likely a bug of VS 2017?
2018-01-01 19:37:59 +09:00
Cheng Zhao
46330ac2a9
Remove the closed event of Menu
...
The callback of Menu.popup does more things, and there is actually no
request for the closed event.
2018-01-01 17:22:07 +09:00
Cheng Zhao
73d78d345a
Make callback work for old-style Menu.popup call
...
While the old-style Menu.popup has been deprecated, it is still being
used widely in apps and even in Electron itself.
2018-01-01 17:17:01 +09:00
Cheng Zhao
2ec3b8ce76
spec: callback for Menu.popup
2018-01-01 16:56:22 +09:00
Cheng Zhao
c3eadd5b63
mac: Call callback when menu is programmely closed
2018-01-01 16:49:25 +09:00
Cheng Zhao
9c6aa9ce90
docs: callback of Menu.popup
2018-01-01 16:42:23 +09:00
Cheng Zhao
7b01a8b860
Add callback parameter to Menu.popup
2018-01-01 16:26:19 +09:00
Cheng Zhao
2e3d940749
Fix "test.py -g Menu" not working
2018-01-01 15:46:39 +09:00
Cheng Zhao
d7bc127c60
mac: Correctly close popup menu
2018-01-01 15:40:15 +09:00
Felix Rieseberg
5f4b62b6c8
feat: Allow testing of single spec modules ( #11409 )
...
* 🔧 ES6 for the spec
* 👷 Allow testing of single modules
* ❤️ Implement feedback
* 📝 Add a testing doc
* 📝 Link to it
* 📝 Cleanup
2017-12-28 06:18:33 -05:00
Cheng Zhao
a161f6e368
Merge pull request #11527 from electron/fix-buffer-crash-master
...
master: Fix crash when using crypto module
2017-12-27 21:45:32 +09:00
Cheng Zhao
e45a125f65
Update node: Fix crash when doing crypto operation
2017-12-27 20:37:04 +09:00
Cheng Zhao
75ac7d9ff2
spec: Add test for crypto operation
2017-12-27 20:37:04 +09:00
Charles Kerr
0cafc3cf52
Merge pull request #11511 from HayateLaTech/patch-1
...
Update browser-window.md
2017-12-22 09:05:38 -06:00
Cheng Zhao
fe16e24406
Merge pull request #11510 from electron/gin-use-node-platform
...
Use Node's V8Platform instead of gin's
2017-12-22 23:40:19 +09:00
HayateLaTech
f2e32791b1
Update browser-window.md
2017-12-22 15:13:12 +01:00
Cheng Zhao
c0c2461245
Do not create duplicate V8Platform in NodeDebugger
2017-12-22 20:29:09 +09:00
Cheng Zhao
00afeaba9a
Use Node's V8Platform instead of gin's
2017-12-22 20:29:08 +09:00
Charles Kerr
a0ebde0181
Merge pull request #11504 from kylecorry31/master
...
Add Support for Pop!_OS GNOME Session
2017-12-21 22:57:54 -06:00
Kyle Corry
5aac091f40
Add Support for Pop!_OS GNOME Session
...
Similar to this PR: https://github.com/electron/electron/pull/10355 , Pop!_OS suffers from the same problem. Using Ubuntu AppIndicator will not show the icon currently unless the XDG_CURRENT_DESKTOP variable is modified. This commit will add support for pop so that this workaround is not needed.
Ref: https://github.com/pop-os/pop/issues/84
2017-12-21 14:16:15 -05:00
Cheng Zhao
65871cd567
Merge pull request #11238 from electron/spellchecker_iframe_patch
...
fix: manually set spellchecker for sub frames
2017-12-21 17:00:01 +09:00
Cheng Zhao
06e1fb923b
Merge pull request #11495 from electron/libcc-latency-histogram-macros-patch
...
win: Correctly close popup menu
2017-12-21 16:59:47 +09:00
Cheng Zhao
7a8864063b
mac: Handle the case when closing all menu runners
2017-12-21 15:57:27 +09:00
Cheng Zhao
088042841d
win: Correctly close popup menu
2017-12-21 15:26:32 +09:00
Cheng Zhao
459db92052
Merge pull request #11493 from electron/libcc-latency-histogram-macros-patch
...
Update libcc for latency_histogram_macros.patch
2017-12-21 11:52:53 +09:00
Cheng Zhao
05bd5f456a
Update libcc for latency_histogram_macros.patch
2017-12-21 11:20:03 +09:00
Charles Kerr
d3eeb84208
Merge pull request #11466 from electron/cppcheck-diff-mode
...
add changed-files-only mode to cpplint
2017-12-20 10:55:49 -06:00
Cheng Zhao
a6228b97cd
Merge pull request #11264 from brenca/flash-menu-fix
...
Fix flash context menu
2017-12-20 19:37:44 +09:00
Cheng Zhao
e4770c7604
Coding style fixes
2017-12-20 18:48:09 +09:00
deepak1556
83d2917363
fix: manually set spellchecker for sub frames
2017-12-20 12:48:02 +05:30
Heilig Benedek
5bf16c2495
remove async:true from menu tests
2017-12-20 15:41:12 +09:00
Heilig Benedek
ef7357dedc
update tests for menu closed event and call cancel on closePopup
2017-12-20 15:40:07 +09:00
Heilig Benedek
14b65467d8
add test for menu closed event
2017-12-20 15:40:07 +09:00
Heilig Benedek
bcef6eb3df
document menu closed event and fix styling issue
2017-12-20 15:40:07 +09:00
Heilig Benedek
c586806609
fix flash menu being unresponsive to commands
2017-12-20 15:40:07 +09:00
Cheng Zhao
85ef42d99e
Merge pull request #11233 from brenca/devtools-fix
...
Small devtools fixes
2017-12-20 15:35:09 +09:00
Cheng Zhao
0d9ff95526
Revert "dont change window background after devtools is closed"
...
This reverts commit fdcac8552f
2017-12-20 15:18:26 +09:00
Heilig Benedek
fdcac8552f
dont change window background after devtools is closed
2017-12-20 12:57:02 +09:00
Heilig Benedek
d5ab691fdb
fix osr devtools crash introduced during merge
2017-12-20 12:57:02 +09:00
Cheng Zhao
5a9221e1dc
Merge pull request #11092 from electron/provide-scheme-with-open-external-request
...
Give user access to the URL that is attempting to be openExternal'ed
2017-12-20 12:56:00 +09:00
Cheng Zhao
b2e6340622
Reduce the number of helpers
2017-12-20 10:49:49 +09:00
Cheng Zhao
4fd8b04329
Better field names for details object
2017-12-20 10:25:31 +09:00
Samuel Attard
4d7b85bd01
Appease the linter
2017-12-20 10:21:38 +09:00
Samuel Attard
98e9311669
Give user access to the URL that is attempting to be openExternal'ed
2017-12-20 10:21:38 +09:00
Cheng Zhao
39ec40b901
Merge pull request #11470 from electron/update-node-upgrade-doc
...
Update branching steps in upgrading-node.md
2017-12-20 10:08:09 +09:00
Charles Kerr
d36e451301
make IGNORE_FILES more readable
2017-12-19 18:37:02 -06:00
Charles Kerr
0521302940
add atom/node/osfhandle.cc to the do-not-lint list
2017-12-19 17:41:34 -06:00
