Charles Kerr
0d7becff87
Use the appname as the tray icon's default tooltip ( #12388 )
...
This makes an upstream DCHECK happy in AppIndicatorIcon::SetToolTip.
Empty tooltip strings are discouraged, as discussed in commit log
b6c510aa543193337041517c2d70113840189b06.
Fixes #12386 .
2018-03-21 12:15:30 -05:00
deepak1556
e24c0dda5d
add features module to detect availability of build time features at runtime
2018-03-20 10:13:17 +03:00
deepak1556
4b39d17e5f
move pdf viewer behind feature flag
2018-03-20 10:13:17 +03:00
Shelley Vohr
9599615b23
Fix nil tray title crash ( #12352 )
...
* Add check for title_ being nil
* remove print stub
2018-03-19 10:49:39 -05:00
Charles Kerr
558ef7352d
Better GTK+ Menu color support ( #12300 )
...
* Better GTK+ Menu color support
* Fix 'invisible menu' issue (#12275 )
* Now updates menu text color when focus changes!
* Better caching of colors when system theme changes
* Removed all GTK+ deprecation warnings from menubar
* Don't highlight menu text on mouseover in GTK+
* Fix textColor declaration scope error
* Simplify FocusManager connection management a bit
* Make the linter happy
* Decouple MenuBar view recoloring from rebuilding
This way we don't need to rebuild the subview each time a recolor
is needed, e.g. when window focus changes or the system theme changes
* Don't iterate child views if we don't need to
* Move variable declaration outside of a loop
* More efficient iteration of MenuBar children
* Cleaner MenuButton bounds testing
* Fix oops
* Add a nullptr check in MenuBar::GetItemCount()
* Simplify iteration in MenuBar::RebuildChildren()
* Make the linter happy
* Fix signed-unsigned comparison
* Remove declarations of nonexistent methods
* Make SubmenuButton accessor const
* Cleaner accelerator iteration
* Windows fixes
2018-03-17 06:37:36 +09:00
Cheng Zhao
f7786a9e48
Merge pull request #11230 from electron/upgrade-to-chromium-62
...
Upgrade to Chromium 62
2018-02-26 14:20:21 +09:00
kaylie
da9f12d1e2
restore old cb
2018-02-25 14:19:40 -08:00
Aleksei Kuzmin
9fa08fdbc0
Merge views::CustomButton into views::Button.
...
https://chromium-review.googlesource.com/617407
2018-02-23 10:21:24 +09:00
deepak1556
25d966110e
FIXME: PDF component IPC should be converted to Mojo.
...
https://codereview.chromium.org/2455543002
2018-02-23 10:21:23 +09:00
Charles Kerr
56859531cd
fix floating reference glib warning ( #11948 )
...
use gtk_widget_destroy() rather than g_object_unref() on the floating temporary menubar widget that we use to calculate colors
2018-02-19 00:12:54 -06:00
John Kleinschmidt
78ccfa0612
Merge pull request #11879 from electron/fix-gtk-deprecations
...
Fix GTK+ 3 deprecations
2018-02-16 10:01:01 -05:00
Charles Kerr
5e7a5ce3a9
run clang-format on changed sources
2018-02-15 15:20:55 -06:00
Charles Kerr
381ed2e2b2
remove GTK+ 2 specific code
2018-02-15 14:57:45 -06:00
acheronfail
d1d50a4c92
Implement App-Scoped Security scoped bookmarks ( #11711 )
...
* implementation of security scoped bookmarks
* option is now only available on mas builds
2018-02-12 13:25:06 -05:00
Samuel Attard
66b57858b8
Fix child touch bar items not updating ( #11812 )
...
* Fix child touch bar items not updating
Deep children of a TouchBar didn't cause the top level touch bar to update, now they do
Fixes #11761 .
* Remove unused newValue property in TB setter
2018-02-12 12:53:04 -05:00
Shelley Vohr
36cf548114
change weak ptr ref to strong
2018-02-10 21:04:26 -05:00
Shelley Vohr
3085c78bcf
implement selectFormat selector
2018-02-09 21:38:21 -05:00
Charles Kerr
3710e0e38b
make the linter happier
2018-02-09 19:34:37 -06:00
Charles Kerr
4b766d26df
make the linter happy
2018-02-09 19:29:32 -06:00
Charles Kerr
3f5ce6d74f
fix gtk3 deprecation warnings setting menubar colors
2018-02-09 19:04:59 -06:00
Charles Kerr
b107d3f440
remove icons from messageboxes on gtk
...
Icons are deprecated in GtkMessageBoxes as of GTK+ 3.12. The GNOME HIG no longer shows icons in example dialogs; see https://developer.gnome.org/hig/stable/dialogs.html.en and https://developer.gnome.org/gtk3/stable/GtkMessageDialog.html
2018-02-09 17:53:02 -06:00
Charles Kerr
ffff400236
fix 'GTK_STOCK_*' deprecation warnings
2018-02-09 17:45:34 -06:00
Charles Kerr
e5eeab6e29
fix 'GTK_STOCK_*' deprecation warnings
2018-02-09 09:57:39 -06:00
Shelley Vohr
0fff336481
add accessory view for format picker
2018-02-09 09:08:04 -05:00
Shelley Vohr
3399480304
first pass at menu event emission
2018-01-27 09:35:58 -05:00
Nitish Sakhawalkar
2b4cc0a525
Fix macos Full Screen Toggle menu item label ( #11633 )
2018-01-19 09:27:36 -05:00
Heilig Benedek
f36fda3f5d
don't dereference tooltip_controller if it's null
2018-01-18 20:35:19 +01:00
Heilig Benedek
8d8b8c590d
update calls to use new namespaces
2018-01-18 15:23:38 +01:00
Heilig Benedek
5e198d9dc6
add todo comment
2018-01-18 15:23:38 +01:00
Heilig Benedek
8233890e39
lint fix
2018-01-18 15:23:38 +01:00
Heilig Benedek
c6c618acdb
explicitly hide tooltip on window deactivation
2018-01-18 15:23:38 +01:00
shelley vohr
4f0e1826e5
properly check checkbox state on callback ( #11658 )
2018-01-17 08:51:49 -05:00
Matt Way
5504294a6a
Replaces tracking removal with proper mem management
2018-01-10 10:24:37 +09:00
Matt Way
8df4402722
removed unnecessary braces
2018-01-10 10:24:13 +09:00
Matt Way
638d8219c4
Removed tracking area when removing icon to prevent mouse exit race condition crash
2018-01-10 10:24:11 +09:00
Cheng Zhao
1043f07b42
Fix compilation on Windows
2018-01-02 16:37:11 +09:00
deepak1556
0df464e16a
address review comments
2018-01-02 16:37:09 +09:00
deepak1556
d29c27dc78
REVIEW: obtain mime type from file path only on IO allowed sequence
2018-01-02 16:37:09 +09:00
deepak1556
e072213923
FIXME: dbus ObjectProxy methods should only be invoked on IO allowed sequence
2018-01-02 16:37:09 +09:00
deepak1556
a1592446da
REVIEW: access GetApplicationLocale on sequence that allows IO
2018-01-02 16:37:08 +09:00
Cheng Zhao
c3eadd5b63
mac: Call callback when menu is programmely closed
2018-01-01 16:49:25 +09:00
Cheng Zhao
d7bc127c60
mac: Correctly close popup menu
2018-01-01 15:40:15 +09:00
Cheng Zhao
81527b71ba
Merge pull request #11279 from sethlu/openrecent
...
Update submenu's title at replacement
2017-12-19 15:28:02 +09:00
Ales Pergl
8357a33d81
Don't leak the taskbar object, reuse it instead
2017-12-01 17:55:21 +01:00
Zhuo Lu
c274312a3a
Update submenu's title
2017-11-28 19:38:07 -08:00
Cheng Zhao
0dc094fffc
Do not change logic on highlighing
2017-11-28 17:37:58 +09:00
Cheng Zhao
d1ebce0395
Remove unused methods
2017-11-28 17:31:13 +09:00
Cheng Zhao
590578c187
Cache the attributed string
2017-11-28 17:26:09 +09:00
Cheng Zhao
eab3342065
Fix the detection of ANSI code
2017-11-28 16:36:07 +09:00
Cheng Zhao
c9acccaddc
Fix memory leak in ANSCI parsing code
...
We do not have ARC enabled.
2017-11-28 16:36:07 +09:00