Rajdeep Chatterjee 
								
							 
						 
						
							
							
								
							
							
	
	
	dd80952877 
 
						 
						
							
							
								
								
								docs: Added loadFile instead of loadURL in BrowserWindow documentation example ( #28829 )  
							
							... 
							
							
							
							* Added loadFile instead of loadURL in the example
For loading a local file the loadFile API is a better way to load any html file in the Renderer process.
Have changed it in the example.
* Changed backticks to single quote to correct for linting error
In order to correct the linting error reported by the bot, I have changed backticks to single quote in the example. 
							
						 
						
							2021-05-03 13:56:33 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Erick Zhao 
								
							 
						 
						
							
							
								
							
							
	
	
	c17f5a783c 
 
						 
						
							
							
								
								
								docs: remove reference to global Electron install ( #28945 )  
							
							... 
							
							
							
							* docs: remove reference to global Electron install
This is a pattern that we actively want to discourage.
* docs: update as per review suggestion 
							
						 
						
							2021-05-03 16:25:34 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Erick Zhao 
								
							 
						 
						
							
							
								
							
							
	
	
	18a76c6b9d 
 
						 
						
							
							
								
								
								docs: uniformize module API doc format ( #28920 )  
							
							... 
							
							
							
							This PR ensures that all API modules are present in the README doc,
as there were a couple missing. It also formats all modules to contain
a level-1 heading and a blockquote description. 
							
						 
						
							2021-04-29 09:56:31 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Michael Kozakov 
								
							 
						 
						
							
							
								
							
							
	
	
	c37c9adbe2 
 
						 
						
							
							
								
								
								docs: Add clarification for Visual Zoom behavior ( #28860 )  
							
							... 
							
							
							
							* Add clarification for visual zoom documentation 
							
						 
						
							2021-04-28 17:20:47 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Erick Zhao 
								
							 
						 
						
							
							
								
							
							
	
	
	0b42316803 
 
						 
						
							
							
								
								
								docs: remove api/locales page ( #28911 )  
							
							... 
							
							
							
							This page is just a table writing out the contents of an array in
the Chromium source code. We don't actively maintain it, and
it's only referenced in one API, so it makes sense to just
link directly to the code here. 
							
						 
						
							2021-04-28 13:11:50 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	3879e9e065 
 
						 
						
							
							
								
								
								build: remove the vendor directory ( #28883 )  
							
							... 
							
							
							
							The `vendor` directory is a remnant of times long since gone when we had
brightray and libchromiumcontent (never forget).  It is currently the
hope to a single header file that afaics we do not need anymore and
randomly pyyaml gets cloned there but that is easily movable.
This commit removes all references to the vendor directory from scripts,
docs, helpers, etc. and removes the directory itself. 
							
						 
						
							2021-04-28 00:38:08 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	ea6d3fae98 
 
						 
						
							
							
								
								
								docs: the tools folder does not exist anymore ( #28882 )  
							
							
							
						 
						
							2021-04-28 00:36:53 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Juan Cruz Viotti 
								
							 
						 
						
							
							
								
							
							
	
	
	5ec3e02d13 
 
						 
						
							
							
								
								
								docs: Remove mentions of the old external_binaries directory ( #28859 )  
							
							... 
							
							
							
							This functionality was removed in
https://github.com/electron/electron/pull/26701 .
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com> 
							
						 
						
							2021-04-27 20:11:22 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	fa61e3b119 
 
						 
						
							
							
								
								
								feat: add session.storagePath to get path on disk for session data ( #28665 )  
							
							
							
						 
						
							2021-04-27 09:54:28 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Rose 
								
							 
						 
						
							
							
								
							
							
	
	
	583660a85a 
 
						 
						
							
							
								
								
								docs: fix unintentional emoji in win.getMediaSourceId description ( #28767 )  
							
							
							
						 
						
							2021-04-22 10:56:25 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Maddock 
								
							 
						 
						
							
							
								
							
							
	
	
	43d27cc4d1 
 
						 
						
							
							
								
								
								feat: add WebFrameMain.visibilityState ( #28706 )  
							
							... 
							
							
							
							* feat: add WebFrameMain.visibilityState
* docs: mention other page visibility APIs
* test: delay visibilityState check after hiding
* test: add waitForTrue to avoid flaky visibilityState test
* refactor: waitForTrue -> waitUntil 
							
						 
						
							2021-04-22 12:00:58 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	79077f6df9 
 
						 
						
							
							
								
								
								chore: remove app.allowRendererProcessReuse ( #26874 )  
							
							
							
						 
						
							2021-04-21 13:59:11 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Rose 
								
							 
						 
						
							
							
								
							
							
	
	
	4ca518468d 
 
						 
						
							
							
								
								
								feat: remove BrowserWindow option inheritance ( #28550 )  
							
							
							
						 
						
							2021-04-21 10:55:17 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	11199d8824 
 
						 
						
							
							
								
								
								feat: add BrowserWindow.isFocusable() ( #28642 )  
							
							
							
						 
						
							2021-04-21 12:32:19 +02:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Rose 
								
							 
						 
						
							
							
								
							
							
	
	
	e12a3cb59c 
 
						 
						
							
							
								
								
								feat: remove deprecated additionalFeatures ( #28548 )  
							
							
							
						 
						
							2021-04-19 15:46:54 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	400d7c4bce 
 
						 
						
							
							
								
								
								chore: update ts parser for description comment fixes and generic types ( #28709 )  
							
							... 
							
							
							
							* chore: update ts parser for description comment fixes
* docs: strongly type the getUserDefault API
* spec: add getUserMedia type assertions to smoke run 
							
						 
						
							2021-04-19 11:44:58 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Mark Lee 
								
							 
						 
						
							
							
								
							
							
	
	
	99fc054ce9 
 
						 
						
							
							
								
								
								docs(build-instructions): clarify that these are for building Electron itself ( #28674 )  
							
							
							
						 
						
							2021-04-19 11:50:00 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Electron Bot 
								
							 
						 
						
							
							
								
							
							
	
	
	22a70eb803 
 
						 
						
							
							
								
								
								chore: bump chromium to 92.0.4475.0 (master) ( #28462 )  
							
							... 
							
							
							
							* chore: bump chromium in DEPS to 91.0.4464.0
* chore: rebuild chromium/dcheck.patch with import-patches -3
Mechanical only; no code changes
* chore: remove content_browser_main_loop.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153 
The function being patched (BrowserMainLoop::MainMessageLoopRun()) no
longer exists.
NB: if removing this introduces regressions the likely fix will be to
add a similar patch for ShellBrowserMainParts::WillRunMainMessageLoop()
which has similar code and was added at the same time this was removed.
* chore: rebuild chromium/put_back_deleted_colors_for_autofill.patch with import-patches -3
Mechanical only; no code changes
* chore: rebuild chromium/disable_color_correct_rendering.patch with import-patches -3
Mechanical only; no code changes
* chore: rebuild chromium/eat_allow_disabling_blink_scheduler_throttling_per_renderview.patch with patch
Mechanical only; no code changes
* chore: rebuild chromium/gpu_notify_when_dxdiag_request_fails.patch with import-patches -3
Mechanical only; no code changes
* chore: rebuild chromium/ui_gtk_public_header.patch manually
no code changes
* chore: rebuild chromium/web_contents.patch with import-patches -3
Mechanical only; no code changes
* chore: remove v8/skip_global_registration_of_shared_arraybuffer_backing_stores.patch
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2763874 
This patch has been merged upstream
* chore: export patches
* chore: update add_trustedauthclient_to_urlloaderfactory.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2757969 
Sync with removal of render_frame_id_
* chore: sync chromium/put_back_deleted_colors_for_autofill.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2785841 
SkColorFromColorId() no longer takes theme, scheme args
* chore: sync chromium/put_back_deleted_colors_for_autofill.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2772143 
Change new calls to GetDarkSchemeColor to fit our patched call signature
* chore: update add_trustedauthclient_to_urlloaderfactory.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2757969 
Sync with removal of render_frame_id_ in our mojom
* chore: update chromium/frame_host_manager.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2740008 
UrlInfo ctor now takes UrlInfo::OriginIsolationRequest instead of a bool
* chore: update chromium/revert_remove_contentrendererclient_shouldfork.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2755314 
Upstream has removed `history_list_length_` which we were comparing to 0
to calculate our `is_initial_navigation` bool when calling ShouldFork().
ShouldFork() is ours and none of the code paths actually use that param,
so this commit removes it altogether.
* chore: update permissions_to_register
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2789074 
Replace all uses of APIPermission::ID enum with Mojo type
* refactor: update return type of PreMainMessageLoopRun()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153 
Used to return void; now returns an int errorcode.
Note: 2725153 also has some nice doc updates about Browser's "stages"
* refactor: sync ElectronBrowserMainParts to MainParts changes
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153 
RunMainMessageLoopParts has been replaced with WillRunMainMessageLoop
so `BrowserMainLoop::result_code_` is no longer available to us for our
exit_code_ pointer.
This variable held a dual role: (1) of course, hold the exit code, but
also (2) was a nullptr before the message loop was ready, indicating to
anyone calling SetExitCode() that we were still in startup and could
just exit() without any extra steps. exit_code_ still fulfills these two
roles but is now a base::Optional.
* chore: update ElectronBrowserMainParts::PreDefaultMainMessageLoopRun
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153 
BrowserMainParts::BrowsePreDefaultMainMesssageLoopRun() has been
removed; move that work to the new WillRunMainMessageLoop().
* refactor: stop using CallbackList; it has been removed.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2785973 
* refactor: update use of threadpools.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2773408 
The upstream code is still in flux (e.g. reverts and re-lands) but the
tl;dr for this commit is (1) include thread_pool.h if you're using it
and (2) don't instantiate pools directly.
* refactor: remove routing_id from CreateLoaderAndStart
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2762858 
NB: One logic branch in ProxyingURLLoaderFactory::CreateLoaderAndStart
calls std::make_unique<InProgressRequest>, which needs a routing_id.
This PR uses the member field `routing_id_` since there's no longer one
being passed into CreateLoaderAndStart.
* refactor: sync to upstream ParittionOptions churn
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771318 
PartitionOptions' enums have changed.
* refactor: update Manifest::Location usage
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771320 
tldr: s/Manifest::FOO/ManifestLocation::kFoo/
* chore: bump chromium in DEPS to 91.0.4465.0
* update patches
* refactor: update extensions::Manifest to upstream
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771320 
-  extensions::Manifest::COMPONENT
+  extensions::mojom::ManifestLocation::kExternalComponent
* refactor: sync with upstream UrlInfo ctor changes
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2740008 
UrlInfo ctor now takes UrlInfo::OriginIsolationRequest instead of a bool
* chore: update invocation of convert_protocol_to_json.py
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2792623 
python3 is being used in parts of the upstream build, but the copy of
convert_protocol_to_json.py invoked in v8/third_party/inspector_protocol
is not python3-friendly. Node has a py2+3-friendly version of it in its
tools directory, so call it instead.
* chore: use extensions::mojom::APIPermissionID
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2791122 
tldr:
- extensions::APIPermission::kFoo
+ extensions::mojom::APIPermissionID::kFoo
* chore: Remove support for TLS1.0/1.1 in SSLVersionMin policy
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2765737 
Remove TLS v1.0 & 1.1 from our SSLProtocolVersionFromString() function.
This is the same change made upstream at
https://chromium-review.googlesource.com/c/chromium/src/+/2765737/8/chrome/browser/ssl/ssl_config_service_manager_pref.cc 
* fixup! chore: update ElectronBrowserMainParts::PreDefaultMainMessageLoopRun
* chore: Use IDType for permission change subscriptions.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2791431 
tldr: {Subscribe,Unsubscribe}PermissionStatusChange's tag type used to
be an int; now it's the new SubscriptionId type (which is an IdType64).
* chore: sync PowerMonitor code to upstream refactor
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2752635 
tldr: PowerMonitor has been split into PowerStateObserver,
PowerSuspendObserver, and PowerThermalObserver to reduce number of tasks
posted to consumers who only need notifications for one of those things
instead of all of them.
* chore: use PartitionOptions's new Cookies field
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771318 
* Revert "refactor: remove routing_id from CreateLoaderAndStart"
This reverts commit 8c9773b87a3c84f9073a47089eb2b6889d745245.
8c9773b was only a partial fix; reverting to start & try again.
* update patches
* chore: bump chromium in DEPS to 91.0.4466.0
* chore: update chromium/accelerator.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2795472 
tldr: sync patch with upstream renamed variable & macro names.
* chore: update chromium/gtk_visibility.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2796200 
tldr: no code changes; just updating the diff to apply cleanly.
note: ooh upstream Wayland hacking!
* chore: update chromium/picture-in-picture.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2710023 
tldr: no code changes; just updating the diff to apply cleanly.
* chore: update chromium/worker_feat_add_hook_to_notify_script_ready.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2775573 
tldr: no code changes; just updating the diff to apply cleanly.
* chore: export_all_patches
* chore: update chromium/feat_add_set_theme_source_to_allow_apps_to.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2796511 
tldr: NotifyObservers has been renamed to NotifyOnNativeThemeUpdated,
so update the invocation in our patch.
* chore: update ElectronBrowserClient w/upstream API
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2797454 
tldr: GetDevToolsManagerDelegate() was returning an owned raw pointer.
Replaced it with CreateDevToolsManagerDelegate() which uses unique_ptr<>.
* chore: handle new content::PermissionType::FILE_HANDLING in toV8()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2762201 
`file-handling` string confirmed in https://chromium-review.googlesource.com/c/chromium/src/+/2762201/18/chrome/browser/ui/webui/settings/site_settings_helper.cc 
* refactor: remove routing_id from CreateLoaderAndStart pt 1
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2762858 
Part 1: the easiest ones
* 2796724: Support Python3
https://chromium-review.googlesource.com/c/infra/luci/python-adb/+/2796724 
* chore: bump chromium in DEPS to 91.0.4468.0
* 2668974: WebShare: Implement SharingServicePicker
https://chromium-review.googlesource.com/c/chromium/src/+/2668974 
* 2802766: Apply modernize-make-unique to media/
https://chromium-review.googlesource.com/c/chromium/src/+/2802766 
* 2802823: Apply modernize-make-unique to gpu/
https://chromium-review.googlesource.com/c/chromium/src/+/2802823 
* 2803041: Apply modernize-make-unique to remaining files
https://chromium-review.googlesource.com/c/chromium/src/+/2803041 
* 2798873: Convert GtkKeyBindingsHandler build checks to runtime checks
https://chromium-review.googlesource.com/c/chromium/src/+/2798873 
* 2733595: [ch-r] Parse ACCEPT_CH H2/3 frame and restart with new headers if needed
https://chromium-review.googlesource.com/c/chromium/src/+/2733595 
* chore: update patch indices
* 2795107: Remove unused PermissionRequest IDs.
https://chromium-review.googlesource.com/c/chromium/src/+/2795107 
* chore: bump chromium in DEPS to 91.0.4469.0
* chore: fixup patch indices
* chore: bump chromium in DEPS to 91.0.4469.5
* PiP 1.5: Add microphone, camera, and hang up buttons to the PiP window
https://chromium-review.googlesource.com/c/chromium/src/+/2710023 
* fixup! refactor: remove routing_id from CreateLoaderAndStart
* refactor: use URLLoaderNetworkServiceObserver for auth requests from SimpleURLLoader
* fixup! chore: fixup patch indices
* 2724817: Expand scope of wasm-eval to all URLs
https://chromium-review.googlesource.com/c/chromium/src/+/2724817 
* Fixup patch after rebase
* chore: bump chromium in DEPS to 91.0.4472.0
* 2797341: [ozone/x11] Enabled the global shortcut listener.
https://chromium-review.googlesource.com/c/chromium/src/+/2797341 
* 2805553: Reland Add GTK ColorMixers to ColorPipeline P1
https://chromium-review.googlesource.com/c/chromium/src/+/2805553 
* 2804366https://chromium-review.googlesource.com/c/chromium/src/+/2804366 
* 2784730: Fix crash on AX mode change in NativeViewHost without a Widget
https://chromium-review.googlesource.com/c/chromium/src/+/2784730 
* chore: update patch indices
* 2810174: Add PdfAnnotationsEnabled policy.
https://chromium-review.googlesource.com/c/chromium/src/+/2810174 
* 2807829: Allow capturers to indicate if they want a WakeLock or not.
https://chromium-review.googlesource.com/c/chromium/src/+/2807829 
* chore: bump chromium in DEPS to 92.0.4473.0
* chore: bump chromium in DEPS to 92.0.4474.0
* chore: bump chromium in DEPS to 92.0.4475.0
* chore: update patches
* chore: updates patches
* chore: update is_media_key patch to handle new ozone impl
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2797341 
* fix: ExecuteJavascript requests now need to be flagged as non-bf-aware
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2787195 
* chore: icon_util_x11 is now icon_util_linux
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2791362 
* build: update sysroots
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2628496 
* build: fix missing symbols on linux build
* use_ozone and use_x11 are not exclusive
* new button view to build for pip
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2797341 
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2804366 
* chore: fix broken gtk_util color patch
* chore: remove patch conflict
* build: update linux manifests
* chore: build bttlb on all platforms for pip
* chore: add thread_pool include for views delegate win
* chore: fix lint
* chore: add node patches for V8 changes
* build: add missing base include on windows
* fix: update frame host manager patch for new state transitions
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2714464 
* chore: update windows zip manifests
* chore: update mac zip manifests
* chore: fix patch linting
* refactor: implement missing URLLoaderNetworkServiceObserver methods
It is against The Mojo Rules to leave hanging callbacks.  These always
have to be called.
Refs: 186528aab92622e91c4493077afbfbhttps://github.com/electron/electron/pull/28462/commits/4e33ee0ad35a710bd34641cb0376bdee6aea2d1f 
* chore: fix gn check
* chore: remove stray .rej files in patch
* chore: add mojo error code to url loader failure
* build: ensure CI is truthy in arm test env
* fix: handle windowCaptureMacV2 being enabled when fetching media source id
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2709931 
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com> 
							
						 
						
							2021-04-15 10:44:35 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Rose 
								
							 
						 
						
							
							
								
							
							
	
	
	f8bdef5349 
 
						 
						
							
							
								
								
								feat: enable nativeWindowOpen by default ( #28552 )  
							
							... 
							
							
							
							* feat: enable nativeWindowOpen by default
* set nativeWindowOpen: false on spec/ main window
* update snapshots
* fix tests
* fix test
* fix webview test missing allowpopups
* fix other test
* update default 
							
						 
						
							2021-04-13 15:36:38 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Rose 
								
							 
						 
						
							
							
								
							
							
	
	
	dba4df9326 
 
						 
						
							
							
								
								
								feat: add more info in setWindowOpenHandler details ( #28518 )  
							
							... 
							
							
							
							* fix: invoke the window open handler for _blank links
* feat: add disposition to setWindowOpenHandler details
* fix: pass postData to new-window event
* postData can be heterogeneous
* fix type of postBody
* fix type of UploadFile and UploadRawData to be discriminated unions
* exclude the empty string from additionalFeatures
* add a test
* add postBody and referrer to setWindowOpenHandler args
* appease typescript
* Update api-browser-window-spec.ts
* update snapshots 
							
						 
						
							2021-04-13 15:35:27 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Maddock 
								
							 
						 
						
							
							
								
							
							
	
	
	ef4954fa1f 
 
						 
						
							
							
								
								
								docs: systemPreferences.subscribeWorkspaceNotification return type ( #28588 )  
							
							
							
						 
						
							2021-04-11 14:02:58 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									KSneijders 
								
							 
						 
						
							
							
								
							
							
	
	
	f755c521eb 
 
						 
						
							
							
								
								
								Defined the name of the preload script ( #28597 )  
							
							
							
						 
						
							2021-04-11 14:01:36 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	da8c35e3b2 
 
						 
						
							
							
								
								
								chore: remove deprecated worldSafeExecuteJavaScript option ( #28456 )  
							
							
							
						 
						
							2021-04-08 12:03:57 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Rose 
								
							 
						 
						
							
							
								
							
							
	
	
	c428ec5cd5 
 
						 
						
							
							
								
								
								docs: note that new-window event is deprecated ( #28549 )  
							
							... 
							
							
							
							* docs: note that new-window event is deprecated
* Update breaking-changes.md
* Update docs/breaking-changes.md 
							
						 
						
							2021-04-08 10:52:14 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Rose 
								
							 
						 
						
							
							
								
							
							
	
	
	17a44895dd 
 
						 
						
							
							
								
								
								docs: fix typo in breaking-changes.md ( #28551 )  
							
							
							
						 
						
							2021-04-07 10:32:32 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Germain 
								
							 
						 
						
							
							
								
							
							
	
	
	2865d161b7 
 
						 
						
							
							
								
								
								docs: remove checkbox options in dialog.showMessageBoxSync ( #28418 )  
							
							
							
						 
						
							2021-04-07 00:18:19 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	7d04f729d8 
 
						 
						
							
							
								
								
								fix: beforeunload and unload firing in BrowserViews ( #28382 )  
							
							... 
							
							
							
							* fix: beforeunload and unload firing in BrowserViews
* Ensure UserGesture is sent for BV webContents
* spec: add tests
* refactor: clean up logic
* spec: fixup specs
* docs: document event behavior for BrowserViews 
							
						 
						
							2021-04-07 00:16:10 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Rose 
								
							 
						 
						
							
							
								
							
							
	
	
	77dcf1020a 
 
						 
						
							
							
								
								
								fix: pass postData to new-window event ( #28513 )  
							
							
							
						 
						
							2021-04-06 09:54:05 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Rose 
								
							 
						 
						
							
							
								
							
							
	
	
	1fcd6e2740 
 
						 
						
							
							
								
								
								docs: Remove GoDaddy from Windows code signing options ( #28494 )  
							
							
							
						 
						
							2021-04-05 17:13:29 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Michaela Laurencin 
								
							 
						 
						
							
							
								
							
							
	
	
	19d7a6b761 
 
						 
						
							
							
								
								
								fix: enable system maximization for frameless windows except if transparent ( #28207 )  
							
							... 
							
							
							
							* fix: move widget maximization check
* fix linting error
* change workaround to only effect transparent windows
* disable menu maximize and restore for transparent windows
* disable double clicking title bar max/unmax for transparent windows
* add docs change and address review 
							
						 
						
							2021-04-06 08:53:59 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									SushiJackal 
								
							 
						 
						
							
							
								
							
							
	
	
	82ea8ea68c 
 
						 
						
							
							
								
								
								fix: reject task append to JumpList when description exceeds 260 characters ( #28485 )  
							
							... 
							
							
							
							* fix: reject task when description exceeds 260 characters
* Switched out wcslen() for size() [linear -> constant time]
* Included comment describing the need for the additional check
* Added information about character limit to documentation
* Added newline character to end of jump-list-category.md 
							
						 
						
							2021-04-06 08:50:39 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	c280d770dc 
 
						 
						
							
							
								
								
								docs: the minimum supported version of macOS is now 10.11 ( #28480 )  
							
							... 
							
							
							
							* chore: the minimum supported version is now 10.11
Chromium bumped this version back in December
* Update support.md 
							
						 
						
							2021-04-05 12:18:12 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Michaela Laurencin 
								
							 
						 
						
							
							
								
							
							
	
	
	2a55ae4b85 
 
						 
						
							
							
								
								
								docs: add frameName note for window.open ( #28435 )  
							
							
							
						 
						
							2021-03-31 13:57:39 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Saúl Ibarra Corretgé 
								
							 
						 
						
							
							
								
							
							
	
	
	2632564ccf 
 
						 
						
							
							
								
								
								feat: initialize field trials from command line arguments ( #28305 )  
							
							... 
							
							
							
							Fixes : #27877  
						
							2021-03-26 09:49:00 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Alexander Prinzhorn 
								
							 
						 
						
							
							
								
							
							
	
	
	521146f71e 
 
						 
						
							
							
								
								
								docs: add missing line in web-contents.md ( #28376 )  
							
							... 
							
							
							
							* Update web-contents.md
The text block was rendered as part of the `features` property, not the `handler`
* fix linting 
							
						 
						
							2021-03-26 09:46:59 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									liulun 
								
							 
						 
						
							
							
								
							
							
	
	
	3d2b740d9e 
 
						 
						
							
							
								
								
								doc: desktopCapturer menu position ( #28315 )  
							
							... 
							
							
							
							desktopCapturer can be used in both main process and renderer process 
							
						 
						
							2021-03-24 10:10:12 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Will Anderson 
								
							 
						 
						
							
							
								
							
							
	
	
	8c3165434a 
 
						 
						
							
							
								
								
								docs: update Node global symbols example to use contextBridge ( #28245 )  
							
							... 
							
							
							
							* docs: update Node global symbols example to use contextBridge
* Trigger Build
* docs: change Node API example to show how to expose a crypto API
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
* docs: Fix lint warning for crypto code sample
* docs: update node API example description to emphasize APIs instead of symbols
Co-authored-by: Jeremy Rose <nornagon@nornagon.net> 
							
						 
						
							2021-03-22 11:01:12 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Rose 
								
							 
						 
						
							
							
								
							
							
	
	
	502d4c19ce 
 
						 
						
							
							
								
								
								feat: allow omitting submitURL when uploadToServer is false ( #28105 )  
							
							
							
						 
						
							2021-03-18 14:15:19 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	f35fc93080 
 
						 
						
							
							
								
								
								chore: rename process.contextIsolation to process.contextIsolated ( #28259 )  
							
							... 
							
							
							
							* chore: rename process.contextIsolation to process.contextIsolated
* thing 
							
						 
						
							2021-03-18 14:00:19 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Karel Braeckman 
								
							 
						 
						
							
							
								
							
							
	
	
	8476bed36e 
 
						 
						
							
							
								
								
								Change example to work with latest versions of selenium-webdriver ( #28231 )  
							
							... 
							
							
							
							See https://github.com/SeleniumHQ/selenium/issues/9286 
The existing snippet works with selenium-webdriver <= 3.6.0, but any more recent version seems to require using 'goog:chromeOptions' and forBrowser('chrome'). 
							
						 
						
							2021-03-18 13:35:04 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Will Anderson 
								
							 
						 
						
							
							
								
							
							
	
	
	14acf00ba9 
 
						 
						
							
							
								
								
								docs: add missing curly brace to quick start example code ( #28253 )  
							
							
							
						 
						
							2021-03-18 00:58:03 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	fc7f2042ec 
 
						 
						
							
							
								
								
								feat: add process.contextIsolation property ( #28030 )  
							
							
							
						 
						
							2021-03-17 11:23:29 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	
	
	485fa5bea9 
 
						 
						
							
							
								
								
								feat: add process.contextId used by @electron/remote ( #28007 )  
							
							
							
						 
						
							2021-03-17 11:23:03 -07:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Will Anderson 
								
							 
						 
						
							
							
								
							
							
	
	
	b6ff12ef7f 
 
						 
						
							
							
								
								
								docs: update Quick Start Guide for Electron 12  ( #28223 )  
							
							... 
							
							
							
							* docs: Update Quick Start Guide for Electron 12
With `contextIsolation` enabled by default in Electron 12, the Getting Started Guide no longer works as it is written. In order for the basic example to display values from `process.versions`, we need to add a `preload.js` to the example.
* fix: annotate preload code block with a language
* docs: update quick-start Fiddle example to use preload to provide version info
* fix: ensure example files end in a newline
* docs: add security warning to instructions for turning off contextIsolation
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
* docs: treat preload as an adjective instead of a noun
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com> 
							
						 
						
							2021-03-16 19:45:38 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									John Kleinschmidt 
								
							 
						 
						
							
							
								
							
							
	
	
	29dc5a2f83 
 
						 
						
							
							
								
								
								docs: remove no longer relevant link ( #28196 )  
							
							
							
						 
						
							2021-03-16 11:41:49 -04:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	b045d42b0e 
 
						 
						
							
							
								
								
								docs: document the parameter structure of hookWindowMessage ( #28189 )  
							
							... 
							
							
							
							Fixes  #28178  
						
							2021-03-16 17:54:41 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Gerrit Niezen 
								
							 
						 
						
							
							
								
							
							
	
	
	45c4dd529f 
 
						 
						
							
							
								
								
								docs: remove unnecessary enableBlinkFeatures ( #28129 )  
							
							... 
							
							
							
							* docs: remove unnecessary enableBlinkFeatures
* docs: remove trailing comma 
							
						 
						
							2021-03-15 10:29:10 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Binyamin Aron Green 
								
							 
						 
						
							
							
								
							
							
	
	
	a442f11574 
 
						 
						
							
							
								
								
								fixed typo in docs/api/window-open.md ( #28117 )  
							
							
							
						 
						
							2021-03-13 10:47:33 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Mark Lee 
								
							 
						 
						
							
							
								
							
							
	
	
	40d779a7f3 
 
						 
						
							
							
								
								
								docs(breaking-changes): contextIsolation disables require in renderer  ( #28087 )  
							
							... 
							
							
							
							* docs(breaking-changes): contextIsolation disables require in renderer
* docs: consistency 
							
						 
						
							2021-03-12 16:42:15 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Mark Lee 
								
							 
						 
						
							
							
								
							
							
	
	
	6bce814736 
 
						 
						
							
							
								
								
								docs(quick-start): make import command npm 7-compatible ( #28077 )  
							
							... 
							
							
							
							With npm 7, just running `npx @electron-forge/cli import` results in:
```
npm ERR! could not determine executable to run
``` 
							
						 
						
							2021-03-12 16:38:58 +09:00