mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: always initialize api::Protocol (#21009)

Browse source
This commit is contained in:
Jeremy Apthorp 2019-11-07 15:35:12 -08:00 • committed by GitHub
parent b06a479240
commit fd70ac1173
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
shell/browser/api/atom_api_session.cc
View file

@ -226,6 +226,8 @@ Session::Session(v8::Isolate* isolate, AtomBrowserContext* browser_context)
new SessionPreferences(browser_context); new SessionPreferences(browser_context);
protocol_.Reset(isolate, Protocol::Create(isolate, browser_context).ToV8());
Init(isolate); Init(isolate);
AttachAsUserData(browser_context); AttachAsUserData(browser_context);
} }
@ -609,11 +611,6 @@ v8::Local<v8::Value> Session::Cookies(v8::Isolate* isolate) {
} }
v8::Local<v8::Value> Session::Protocol(v8::Isolate* isolate) { v8::Local<v8::Value> Session::Protocol(v8::Isolate* isolate) {
if (protocol_.IsEmpty()) {
v8::Local<v8::Value> handle;
handle = Protocol::Create(isolate, browser_context()).ToV8();
protocol_.Reset(isolate, handle);
}
return v8::Local<v8::Value>::New(isolate, protocol_); return v8::Local<v8::Value>::New(isolate, protocol_);
} }