From fd70ac117394bee04296295462c4edeb15f2b314 Mon Sep 17 00:00:00 2001
From: Jeremy Apthorp <jeremya@chromium.org>
Date: Thu, 7 Nov 2019 15:35:12 -0800
Subject: [PATCH] refactor: always initialize api::Protocol (#21009)

---
 shell/browser/api/atom_api_session.cc | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/shell/browser/api/atom_api_session.cc b/shell/browser/api/atom_api_session.cc
index ed7c527d4017..33fb72519c56 100644
--- a/shell/browser/api/atom_api_session.cc
+++ b/shell/browser/api/atom_api_session.cc
@@ -226,6 +226,8 @@ Session::Session(v8::Isolate* isolate, AtomBrowserContext* browser_context)
 
   new SessionPreferences(browser_context);
 
+  protocol_.Reset(isolate, Protocol::Create(isolate, browser_context).ToV8());
+
   Init(isolate);
   AttachAsUserData(browser_context);
 }
@@ -609,11 +611,6 @@ v8::Local<v8::Value> Session::Cookies(v8::Isolate* isolate) {
 }
 
 v8::Local<v8::Value> Session::Protocol(v8::Isolate* isolate) {
-  if (protocol_.IsEmpty()) {
-    v8::Local<v8::Value> handle;
-    handle = Protocol::Create(isolate, browser_context()).ToV8();
-    protocol_.Reset(isolate, handle);
-  }
   return v8::Local<v8::Value>::New(isolate, protocol_);
 }