mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Provide WebContents::CreateParams to tab helpers.

Browse source 
https://codereview.chromium.org/2894973002
This commit is contained in:
Aleksei Kuzmin 2017-08-08 00:09:01 +03:00 committed by Cheng Zhao
parent c402658c08
commit f2bcdab037
2 changed files with 18 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
atom/browser/api/atom_api_web_contents.cc
View file

@ -500,12 +500,14 @@ void WebContents::OnCreateWindow(
Emit("new-window", target_url, frame_name, disposition, features); Emit("new-window", target_url, frame_name, disposition, features);
} }
void WebContents::WebContentsCreated(content::WebContents* source_contents, void WebContents::WebContentsCreated(
int opener_render_process_id, content::WebContents* source_contents,
int opener_render_frame_id, int opener_render_process_id,
const std::string& frame_name, int opener_render_frame_id,
const GURL& target_url, const std::string& frame_name,
content::WebContents* new_contents) { const GURL& target_url,
content::WebContents* new_contents,
const base::Optional<content::WebContents::CreateParams>& create_params) {
v8::Locker locker(isolate()); v8::Locker locker(isolate());
v8::HandleScope handle_scope(isolate()); v8::HandleScope handle_scope(isolate());
auto api_web_contents = CreateFrom(isolate(), new_contents, BROWSER_WINDOW); auto api_web_contents = CreateFrom(isolate(), new_contents, BROWSER_WINDOW);

16
atom/browser/api/atom_api_web_contents.h
View file

@ -15,6 +15,7 @@
#include "atom/browser/ui/autofill_popup.h" #include "atom/browser/ui/autofill_popup.h"
#include "content/common/cursors/webcursor.h" #include "content/common/cursors/webcursor.h"
#include "content/public/browser/keyboard_event_processing_result.h" #include "content/public/browser/keyboard_event_processing_result.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_observer.h" #include "content/public/browser/web_contents_observer.h"
#include "content/public/common/favicon_url.h" #include "content/public/common/favicon_url.h"
#include "native_mate/handle.h" #include "native_mate/handle.h"
@ -247,12 +248,15 @@ class WebContents : public mate::TrackableObject<WebContents>,
const base::string16& message, const base::string16& message,
int32_t line_no, int32_t line_no,
const base::string16& source_id) override; const base::string16& source_id) override;
void WebContentsCreated(content::WebContents* source_contents, void WebContentsCreated(
int opener_render_process_id, content::WebContents* source_contents,
int opener_render_frame_id, int opener_render_process_id,
const std::string& frame_name, int opener_render_frame_id,
const GURL& target_url, const std::string& frame_name,
content::WebContents* new_contents) override; const GURL& target_url,
content::WebContents* new_contents,
const base::Optional<content::WebContents::CreateParams>& create_params)
override;
void AddNewContents(content::WebContents* source, void AddNewContents(content::WebContents* source,
content::WebContents* new_contents, content::WebContents* new_contents,
WindowOpenDisposition disposition, WindowOpenDisposition disposition,