From f2bcdab037f34609bb95d35bb6776a32e1bb6476 Mon Sep 17 00:00:00 2001 From: Aleksei Kuzmin Date: Tue, 8 Aug 2017 00:09:01 +0300 Subject: [PATCH] Provide WebContents::CreateParams to tab helpers. https://codereview.chromium.org/2894973002 --- atom/browser/api/atom_api_web_contents.cc | 14 ++++++++------ atom/browser/api/atom_api_web_contents.h | 16 ++++++++++------ 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/atom/browser/api/atom_api_web_contents.cc b/atom/browser/api/atom_api_web_contents.cc index c5f5bff23500..b57212797006 100644 --- a/atom/browser/api/atom_api_web_contents.cc +++ b/atom/browser/api/atom_api_web_contents.cc @@ -500,12 +500,14 @@ void WebContents::OnCreateWindow( Emit("new-window", target_url, frame_name, disposition, features); } -void WebContents::WebContentsCreated(content::WebContents* source_contents, - int opener_render_process_id, - int opener_render_frame_id, - const std::string& frame_name, - const GURL& target_url, - content::WebContents* new_contents) { +void WebContents::WebContentsCreated( + content::WebContents* source_contents, + int opener_render_process_id, + int opener_render_frame_id, + const std::string& frame_name, + const GURL& target_url, + content::WebContents* new_contents, + const base::Optional& create_params) { v8::Locker locker(isolate()); v8::HandleScope handle_scope(isolate()); auto api_web_contents = CreateFrom(isolate(), new_contents, BROWSER_WINDOW); diff --git a/atom/browser/api/atom_api_web_contents.h b/atom/browser/api/atom_api_web_contents.h index 23e3cccc308f..c5f122470c31 100644 --- a/atom/browser/api/atom_api_web_contents.h +++ b/atom/browser/api/atom_api_web_contents.h @@ -15,6 +15,7 @@ #include "atom/browser/ui/autofill_popup.h" #include "content/common/cursors/webcursor.h" #include "content/public/browser/keyboard_event_processing_result.h" +#include "content/public/browser/web_contents.h" #include "content/public/browser/web_contents_observer.h" #include "content/public/common/favicon_url.h" #include "native_mate/handle.h" @@ -247,12 +248,15 @@ class WebContents : public mate::TrackableObject, const base::string16& message, int32_t line_no, const base::string16& source_id) override; - void WebContentsCreated(content::WebContents* source_contents, - int opener_render_process_id, - int opener_render_frame_id, - const std::string& frame_name, - const GURL& target_url, - content::WebContents* new_contents) override; + void WebContentsCreated( + content::WebContents* source_contents, + int opener_render_process_id, + int opener_render_frame_id, + const std::string& frame_name, + const GURL& target_url, + content::WebContents* new_contents, + const base::Optional& create_params) + override; void AddNewContents(content::WebContents* source, content::WebContents* new_contents, WindowOpenDisposition disposition,