mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Merge pull request #9290 from electron/coerce-history-go-offset-to-number

Browse source 
Coerce window.history.go offset argument to number in renderer process
This commit is contained in:
Kevin Sawicki 2017-04-26 13:02:53 -07:00 • committed by GitHub
commit eabe7b9dce
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/renderer/window-setup.js
View file

@ -164,7 +164,7 @@ module.exports = (ipcRenderer, guestInstanceId, openerId, hiddenPage) => {
} }
window.history.go = function (offset) { window.history.go = function (offset) {
sendHistoryOperation(ipcRenderer, 'goToOffset', offset) sendHistoryOperation(ipcRenderer, 'goToOffset', +offset)
} }
defineProperty(window.history, 'length', { defineProperty(window.history, 'length', {

8
spec/chromium-spec.js
View file

@ -989,4 +989,12 @@ describe('chromium feature', function () {
}, /Cannot convert object to primitive value/) }, /Cannot convert object to primitive value/)
}) })
}) })
describe('window.history.go(offset)', function () {
it('throws an exception when the argumnet cannot be converted to a string', function () {
assert.throws(function () {
window.history.go({toString: null})
}, /Cannot convert object to primitive value/)
})
})
}) })