diff --git a/lib/renderer/window-setup.js b/lib/renderer/window-setup.js index 5ccb6fec463d..99f7aef54237 100644 --- a/lib/renderer/window-setup.js +++ b/lib/renderer/window-setup.js @@ -164,7 +164,7 @@ module.exports = (ipcRenderer, guestInstanceId, openerId, hiddenPage) => { } window.history.go = function (offset) { - sendHistoryOperation(ipcRenderer, 'goToOffset', offset) + sendHistoryOperation(ipcRenderer, 'goToOffset', +offset) } defineProperty(window.history, 'length', { diff --git a/spec/chromium-spec.js b/spec/chromium-spec.js index 700983bb5ae9..d5d1b3f4782a 100644 --- a/spec/chromium-spec.js +++ b/spec/chromium-spec.js @@ -989,4 +989,12 @@ describe('chromium feature', function () { }, /Cannot convert object to primitive value/) }) }) + + describe('window.history.go(offset)', function () { + it('throws an exception when the argumnet cannot be converted to a string', function () { + assert.throws(function () { + window.history.go({toString: null}) + }, /Cannot convert object to primitive value/) + }) + }) })