mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: re-enable disabled ScriptOrModule specs (#33702)

Browse source
This commit is contained in:
Shelley Vohr 2022-04-12 12:00:42 +02:00 • committed by GitHub
parent c9fd255093
commit e8ed9cb4b5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
spec-main/api-web-contents-spec.ts
View file

@ -1857,8 +1857,7 @@ describe('webContents module', () => {
} }
}); });
// TODO(codebytere): Re-enable after Chromium fixes upstream v8_scriptormodule_legacy_lifetime crash. describe('using a large document', () => {
xdescribe('using a large document', () => {
beforeEach(async () => { beforeEach(async () => {
w = new BrowserWindow({ show: false, webPreferences: { sandbox: true } }); w = new BrowserWindow({ show: false, webPreferences: { sandbox: true } });
await w.loadFile(path.join(__dirname, 'fixtures', 'api', 'print-to-pdf.html')); await w.loadFile(path.join(__dirname, 'fixtures', 'api', 'print-to-pdf.html'));

3
spec-main/chromium-spec.ts
View file

@ -238,8 +238,7 @@ describe('web security', () => {
await p; await p;
}); });
// TODO(codebytere): Re-enable after Chromium fixes upstream v8_scriptormodule_legacy_lifetime crash. it('bypasses CORB when web security is disabled', async () => {
xit('bypasses CORB when web security is disabled', async () => {
const w = new BrowserWindow({ show: false, webPreferences: { webSecurity: false, nodeIntegration: true, contextIsolation: false } }); const w = new BrowserWindow({ show: false, webPreferences: { webSecurity: false, nodeIntegration: true, contextIsolation: false } });
const p = emittedOnce(ipcMain, 'success'); const p = emittedOnce(ipcMain, 'success');
await w.loadURL(`data:text/html, await w.loadURL(`data:text/html,