From e8ed9cb4b507e120de8b396b1d8d88e554b7d395 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Tue, 12 Apr 2022 12:00:42 +0200 Subject: [PATCH] test: re-enable disabled ScriptOrModule specs (#33702) --- spec-main/api-web-contents-spec.ts | 3 +-- spec-main/chromium-spec.ts | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/spec-main/api-web-contents-spec.ts b/spec-main/api-web-contents-spec.ts index 3d04494a50d1..c2f6151fd2d4 100644 --- a/spec-main/api-web-contents-spec.ts +++ b/spec-main/api-web-contents-spec.ts @@ -1857,8 +1857,7 @@ describe('webContents module', () => { } }); - // TODO(codebytere): Re-enable after Chromium fixes upstream v8_scriptormodule_legacy_lifetime crash. - xdescribe('using a large document', () => { + describe('using a large document', () => { beforeEach(async () => { w = new BrowserWindow({ show: false, webPreferences: { sandbox: true } }); await w.loadFile(path.join(__dirname, 'fixtures', 'api', 'print-to-pdf.html')); diff --git a/spec-main/chromium-spec.ts b/spec-main/chromium-spec.ts index 80920d99b631..31d7bb759962 100644 --- a/spec-main/chromium-spec.ts +++ b/spec-main/chromium-spec.ts @@ -238,8 +238,7 @@ describe('web security', () => { await p; }); - // TODO(codebytere): Re-enable after Chromium fixes upstream v8_scriptormodule_legacy_lifetime crash. - xit('bypasses CORB when web security is disabled', async () => { + it('bypasses CORB when web security is disabled', async () => { const w = new BrowserWindow({ show: false, webPreferences: { webSecurity: false, nodeIntegration: true, contextIsolation: false } }); const p = emittedOnce(ipcMain, 'success'); await w.loadURL(`data:text/html,