mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix linting

Browse source
This commit is contained in:
Gabriel Handford 2016-10-14 12:38:55 -07:00 committed by Cheng Zhao
parent c78567aba6
commit cfd2a029ad
4 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
atom/common/api/atom_api_shell.cc
View file

@ -60,7 +60,8 @@ bool OpenExternal(
if (args->Length() >= 3) { if (args->Length() >= 3) {
v8::Local<v8::Value> peek = args->PeekNext(); v8::Local<v8::Value> peek = args->PeekNext();
platform_util::OpenExternalCallback callback; platform_util::OpenExternalCallback callback;
if (mate::Converter<platform_util::OpenExternalCallback>::FromV8(args->isolate(), peek, &callback)) { if (mate::Converter<platform_util::OpenExternalCallback>::FromV8(
args->isolate(), peek, &callback)) {
return platform_util::OpenExternal(url, activate, callback); return platform_util::OpenExternal(url, activate, callback);
} }
return false; return false;

2
atom/common/platform_util.h
View file

@ -5,8 +5,8 @@
#ifndef ATOM_COMMON_PLATFORM_UTIL_H_ #ifndef ATOM_COMMON_PLATFORM_UTIL_H_
#define ATOM_COMMON_PLATFORM_UTIL_H_ #define ATOM_COMMON_PLATFORM_UTIL_H_
#include "build/build_config.h"
#include "base/callback_forward.h" #include "base/callback_forward.h"
#include "build/build_config.h"
#if defined(OS_WIN) #if defined(OS_WIN)
#include "base/strings/string16.h" #include "base/strings/string16.h"

5
atom/common/platform_util_linux.cc
View file

@ -88,8 +88,9 @@ bool OpenExternal(const GURL& url, bool activate) {
return XDGOpen(url.spec(), false); return XDGOpen(url.spec(), false);
} }
bool OpenExternal(const GURL& url, bool activate, const OpenExternalCallback& callback) { bool OpenExternal(const GURL& url, bool activate,
// TODO: Implement async open if callback is specified const OpenExternalCallback& callback) {
// TODO(gabriel): Implement async open if callback is specified
bool opened = OpenExternal(url, activate); bool opened = OpenExternal(url, activate);
callback.Run(opened); callback.Run(opened);
return opened; return opened;

5
atom/common/platform_util_win.cc
View file

@ -316,8 +316,9 @@ bool OpenExternal(const base::string16& url, bool activate) {
return true; return true;
} }
bool OpenExternal(const base::string16& url, bool activate, const OpenExternalCallback& callback) { bool OpenExternal(const base::string16& url, bool activate,
// TODO: Implement async open if callback is specified const OpenExternalCallback& callback) {
// // TODO(gabriel): Implement async open if callback is specified
bool opened = OpenExternal(url, activate); bool opened = OpenExternal(url, activate);
callback.Run(opened); callback.Run(opened);
return opened; return opened;