mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Notifications should emit close on close, not eventual GC

Browse source
This commit is contained in:
Matt Crocker 2017-10-23 22:37:03 -07:00
parent e2d5aaf0f3
commit ca8f45a501
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/api/atom_api_notification.cc
View file

@ -169,10 +169,10 @@ void Notification::NotificationDisplayed() {
} }
void Notification::NotificationDestroyed() { void Notification::NotificationDestroyed() {
Emit("close");
} }
void Notification::NotificationClosed() { void Notification::NotificationClosed() {
Emit("close");
} }
// Showing notifications // Showing notifications

2
docs/api/notification.md
View file

@ -74,7 +74,7 @@ Returns:
Emitted when the notification is closed by manual intervention from the user. Emitted when the notification is closed by manual intervention from the user.
This event is not guarunteed to be emitted in all cases where the notification This event is not guaranteed to be emitted in all cases where the notification
is closed. is closed.
#### Event: 'reply' _macOS_ #### Event: 'reply' _macOS_