From ca8f45a5019432fbe76f03390eae6b969e603bd2 Mon Sep 17 00:00:00 2001 From: Matt Crocker Date: Mon, 23 Oct 2017 22:37:03 -0700 Subject: [PATCH] Notifications should emit close on close, not eventual GC --- atom/browser/api/atom_api_notification.cc | 2 +- docs/api/notification.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/atom/browser/api/atom_api_notification.cc b/atom/browser/api/atom_api_notification.cc index ef5b9ce1296a..7db7dbf38acc 100644 --- a/atom/browser/api/atom_api_notification.cc +++ b/atom/browser/api/atom_api_notification.cc @@ -169,10 +169,10 @@ void Notification::NotificationDisplayed() { } void Notification::NotificationDestroyed() { - Emit("close"); } void Notification::NotificationClosed() { + Emit("close"); } // Showing notifications diff --git a/docs/api/notification.md b/docs/api/notification.md index 402bbb69db71..9c041a76cef1 100644 --- a/docs/api/notification.md +++ b/docs/api/notification.md @@ -74,7 +74,7 @@ Returns: Emitted when the notification is closed by manual intervention from the user. -This event is not guarunteed to be emitted in all cases where the notification +This event is not guaranteed to be emitted in all cases where the notification is closed. #### Event: 'reply' _macOS_