mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Merge pull request #7295 from electron/native-image-bad-path-docs

Browse source 
Mention createFromPath bad path return value
This commit is contained in:
Cheng Zhao 2016-09-22 14:14:15 +09:00 • committed by GitHub
commit c9a3ab3a81
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
docs/api/native-image.md
View file

@ -120,7 +120,9 @@ Creates an empty `NativeImage` instance.
* `path` String * `path` String
Creates a new `NativeImage` instance from a file located at `path`. Creates a new `NativeImage` instance from a file located at `path`. This method
returns an empty image if the `path` does not exist, cannot be read, or is not
a valid image.
```javascript ```javascript
const nativeImage = require('electron').nativeImage const nativeImage = require('electron').nativeImage

2
spec/api-native-image-spec.js
View file

@ -10,6 +10,8 @@ describe('nativeImage module', () => {
assert(nativeImage.createFromPath('').isEmpty()) assert(nativeImage.createFromPath('').isEmpty())
assert(nativeImage.createFromPath('does-not-exist.png').isEmpty()) assert(nativeImage.createFromPath('does-not-exist.png').isEmpty())
assert(nativeImage.createFromPath('does-not-exist.ico').isEmpty()) assert(nativeImage.createFromPath('does-not-exist.ico').isEmpty())
assert(nativeImage.createFromPath(__dirname).isEmpty())
assert(nativeImage.createFromPath(__filename).isEmpty())
}) })
it('loads images from paths relative to the current working directory', () => { it('loads images from paths relative to the current working directory', () => {