From 546c0e7822e875030d5436701af864359a9e1d3f Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Wed, 21 Sep 2016 10:48:01 -0700 Subject: [PATCH 1/2] Mention createFromPath failure cases --- docs/api/native-image.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/api/native-image.md b/docs/api/native-image.md index 0e16e30ee1e..108d7e92730 100644 --- a/docs/api/native-image.md +++ b/docs/api/native-image.md @@ -120,7 +120,9 @@ Creates an empty `NativeImage` instance. * `path` String -Creates a new `NativeImage` instance from a file located at `path`. +Creates a new `NativeImage` instance from a file located at `path`. This method +returns an empty image if the `path` does not exist, cannot be read, or is not +a valid image. ```javascript const nativeImage = require('electron').nativeImage From f8236c1a6514d012510d8d8cab4617b853c0fb03 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Wed, 21 Sep 2016 10:48:24 -0700 Subject: [PATCH 2/2] Add more failure asserts for nativeImage.createFromPath --- spec/api-native-image-spec.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spec/api-native-image-spec.js b/spec/api-native-image-spec.js index 7e49cbf78e5..4fcd710766c 100644 --- a/spec/api-native-image-spec.js +++ b/spec/api-native-image-spec.js @@ -10,6 +10,8 @@ describe('nativeImage module', () => { assert(nativeImage.createFromPath('').isEmpty()) assert(nativeImage.createFromPath('does-not-exist.png').isEmpty()) assert(nativeImage.createFromPath('does-not-exist.ico').isEmpty()) + assert(nativeImage.createFromPath(__dirname).isEmpty()) + assert(nativeImage.createFromPath(__filename).isEmpty()) }) it('loads images from paths relative to the current working directory', () => {