mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

chore: don't delete nightly tag after draft (#22588)

Browse source
This commit is contained in:
Shelley Vohr 2020-03-10 03:13:10 +00:00 • committed by GitHub
parent 8075a55815
commit c0374b5796
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
script/release/release-artifact-cleanup.js
View file

@ -44,7 +44,6 @@ async function deleteDraft (releaseId, targetRepo) {
repo: targetRepo, repo: targetRepo,
release_id: parseInt(releaseId, 10) release_id: parseInt(releaseId, 10)
}) })
console.log(result)
if (!result.data.draft) { if (!result.data.draft) {
console.log(`${fail} published releases cannot be deleted.`) console.log(`${fail} published releases cannot be deleted.`)
return false return false
@ -85,15 +84,11 @@ async function cleanReleaseArtifacts () {
if (releaseId) { if (releaseId) {
if (isNightly) { if (isNightly) {
const deletedNightlyDraft = await deleteDraft(releaseId, 'nightlies') await deleteDraft(releaseId, 'nightlies')
// don't delete tag unless draft deleted successfully // We only need to delete the Electron tag since the
if (deletedNightlyDraft) { // nightly tag is only created at publish-time.
await Promise.all([ await deleteTag(args.tag, 'electron')
deleteTag(args.tag, 'electron'),
deleteTag(args.tag, 'nightlies')
])
}
} else { } else {
const deletedElectronDraft = await deleteDraft(releaseId, 'electron') const deletedElectronDraft = await deleteDraft(releaseId, 'electron')
// don't delete tag unless draft deleted successfully // don't delete tag unless draft deleted successfully