From c0374b57960f08256d9318527166e209b8de2093 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Tue, 10 Mar 2020 03:13:10 +0000 Subject: [PATCH] chore: don't delete nightly tag after draft (#22588) --- script/release/release-artifact-cleanup.js | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/script/release/release-artifact-cleanup.js b/script/release/release-artifact-cleanup.js index 561ecbf12d54..d68354b089b5 100755 --- a/script/release/release-artifact-cleanup.js +++ b/script/release/release-artifact-cleanup.js @@ -44,7 +44,6 @@ async function deleteDraft (releaseId, targetRepo) { repo: targetRepo, release_id: parseInt(releaseId, 10) }) - console.log(result) if (!result.data.draft) { console.log(`${fail} published releases cannot be deleted.`) return false @@ -85,15 +84,11 @@ async function cleanReleaseArtifacts () { if (releaseId) { if (isNightly) { - const deletedNightlyDraft = await deleteDraft(releaseId, 'nightlies') + await deleteDraft(releaseId, 'nightlies') - // don't delete tag unless draft deleted successfully - if (deletedNightlyDraft) { - await Promise.all([ - deleteTag(args.tag, 'electron'), - deleteTag(args.tag, 'nightlies') - ]) - } + // We only need to delete the Electron tag since the + // nightly tag is only created at publish-time. + await deleteTag(args.tag, 'electron') } else { const deletedElectronDraft = await deleteDraft(releaseId, 'electron') // don't delete tag unless draft deleted successfully