mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

docs: note reason for is_cfi = false (#33749)

Browse source
This commit is contained in:
Jeremy Rose 2022-04-12 21:00:03 -07:00 • committed by GitHub
parent d804cd5de2
commit bfa5b21044
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
build/args/all.gn
View file

@ -29,8 +29,6 @@ dawn_enable_vulkan_validation_layers = false
# See https://chromium-review.googlesource.com/c/chromium/src/+/2774898. # See https://chromium-review.googlesource.com/c/chromium/src/+/2774898.
enable_pseudolocales = false enable_pseudolocales = false
is_cfi = false
# Make application name configurable at runtime for cookie crypto # Make application name configurable at runtime for cookie crypto
allow_runtime_configurable_key_storage = true allow_runtime_configurable_key_storage = true
@ -38,3 +36,9 @@ allow_runtime_configurable_key_storage = true
# enabling this flag causes main process crashes where CET is enabled # enabling this flag causes main process crashes where CET is enabled
# Ref: https://source.chromium.org/chromium/chromium/src/+/45fba672185aae233e75d6ddc81ea1e0b30db050:v8/BUILD.gn;l=357 # Ref: https://source.chromium.org/chromium/chromium/src/+/45fba672185aae233e75d6ddc81ea1e0b30db050:v8/BUILD.gn;l=357
enable_cet_shadow_stack = false enable_cet_shadow_stack = false
# For similar reasons, disable CFI, which is not well supported in V8.
# Chromium doesn't have any problems with this because they do not run
# V8 in the browser process.
# Ref: https://source.chromium.org/chromium/chromium/src/+/45fba672185aae233e75d6ddc81ea1e0b30db050:v8/BUILD.gn;l=281
is_cfi = false