From bfa5b2104494f4f1f1ea78e697ad85ae4ba74654 Mon Sep 17 00:00:00 2001 From: Jeremy Rose Date: Tue, 12 Apr 2022 21:00:03 -0700 Subject: [PATCH] docs: note reason for is_cfi = false (#33749) --- build/args/all.gn | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/build/args/all.gn b/build/args/all.gn index b0e8dda791c5..b0400b0951ee 100644 --- a/build/args/all.gn +++ b/build/args/all.gn @@ -29,8 +29,6 @@ dawn_enable_vulkan_validation_layers = false # See https://chromium-review.googlesource.com/c/chromium/src/+/2774898. enable_pseudolocales = false -is_cfi = false - # Make application name configurable at runtime for cookie crypto allow_runtime_configurable_key_storage = true @@ -38,3 +36,9 @@ allow_runtime_configurable_key_storage = true # enabling this flag causes main process crashes where CET is enabled # Ref: https://source.chromium.org/chromium/chromium/src/+/45fba672185aae233e75d6ddc81ea1e0b30db050:v8/BUILD.gn;l=357 enable_cet_shadow_stack = false + +# For similar reasons, disable CFI, which is not well supported in V8. +# Chromium doesn't have any problems with this because they do not run +# V8 in the browser process. +# Ref: https://source.chromium.org/chromium/chromium/src/+/45fba672185aae233e75d6ddc81ea1e0b30db050:v8/BUILD.gn;l=281 +is_cfi = false