mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

feat: allow http-parser NODE_OPTION in packaged apps (#21694)

Browse source
This commit is contained in:
Shelley Vohr 2020-01-09 08:09:14 -08:00 committed by GitHub
parent 75e39be916
commit bb054716c9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
docs/api/environment-variables.md
View file

@ -48,6 +48,7 @@ Unsupported options are:
```sh ```sh
--max-http-header-size --max-http-header-size
--http-parser
``` ```
### `GOOGLE_API_KEY` ### `GOOGLE_API_KEY`

3
shell/common/node_bindings.cc
View file

@ -144,7 +144,8 @@ void SetNodeOptions(base::Environment* env) {
"--force-fips", "--enable-fips"}; "--force-fips", "--enable-fips"};
// Subset of options allowed in packaged apps // Subset of options allowed in packaged apps
const std::set<std::string> allowed_in_packaged = {"--max-http-header-size"}; const std::set<std::string> allowed_in_packaged = {"--max-http-header-size",
"--http-parser"};
if (env->HasVar("NODE_OPTIONS")) { if (env->HasVar("NODE_OPTIONS")) {
std::string options; std::string options;