From bb054716c9bd18602824f151d010c9ab3f082a20 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Thu, 9 Jan 2020 08:09:14 -0800 Subject: [PATCH] feat: allow http-parser NODE_OPTION in packaged apps (#21694) --- docs/api/environment-variables.md | 1 + shell/common/node_bindings.cc | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/api/environment-variables.md b/docs/api/environment-variables.md index 16797bfd954..1a445a13e67 100644 --- a/docs/api/environment-variables.md +++ b/docs/api/environment-variables.md @@ -48,6 +48,7 @@ Unsupported options are: ```sh --max-http-header-size +--http-parser ``` ### `GOOGLE_API_KEY` diff --git a/shell/common/node_bindings.cc b/shell/common/node_bindings.cc index ebc9725a96a..57a3de0c265 100644 --- a/shell/common/node_bindings.cc +++ b/shell/common/node_bindings.cc @@ -144,7 +144,8 @@ void SetNodeOptions(base::Environment* env) { "--force-fips", "--enable-fips"}; // Subset of options allowed in packaged apps - const std::set allowed_in_packaged = {"--max-http-header-size"}; + const std::set allowed_in_packaged = {"--max-http-header-size", + "--http-parser"}; if (env->HasVar("NODE_OPTIONS")) { std::string options;