mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

build: remove unused enable_tts build flag (#38420)

Browse source 
chore: remove unused enable_tts build flag

Co-authored-by: Milan Burda <miburda@microsoft.com>
This commit is contained in:
Milan Burda 2023-05-24 10:18:43 +02:00 • committed by GitHub
parent dec9a1d9db
commit b6ef4a3929
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 1 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

1
buildflags/BUILD.gn
View file

@ -14,7 +14,6 @@ buildflag_header("buildflags") {
"ENABLE_OSR=$enable_osr", "ENABLE_OSR=$enable_osr",
"ENABLE_VIEWS_API=$enable_views_api", "ENABLE_VIEWS_API=$enable_views_api",
"ENABLE_PDF_VIEWER=$enable_pdf_viewer", "ENABLE_PDF_VIEWER=$enable_pdf_viewer",
"ENABLE_TTS=$enable_tts",
"ENABLE_COLOR_CHOOSER=$enable_color_chooser", "ENABLE_COLOR_CHOOSER=$enable_color_chooser",
"ENABLE_ELECTRON_EXTENSIONS=$enable_electron_extensions", "ENABLE_ELECTRON_EXTENSIONS=$enable_electron_extensions",
"ENABLE_BUILTIN_SPELLCHECKER=$enable_builtin_spellchecker", "ENABLE_BUILTIN_SPELLCHECKER=$enable_builtin_spellchecker",

2
buildflags/buildflags.gni
View file

@ -14,8 +14,6 @@ declare_args() {
enable_pdf_viewer = true enable_pdf_viewer = true
enable_tts = true
enable_color_chooser = true enable_color_chooser = true
enable_picture_in_picture = true enable_picture_in_picture = true

5
shell/common/api/features.cc
View file

@ -38,10 +38,6 @@ bool IsViewApiEnabled() {
return BUILDFLAG(ENABLE_VIEWS_API); return BUILDFLAG(ENABLE_VIEWS_API);
} }
bool IsTtsEnabled() {
return BUILDFLAG(ENABLE_TTS);
}
bool IsPrintingEnabled() { bool IsPrintingEnabled() {
return BUILDFLAG(ENABLE_PRINTING); return BUILDFLAG(ENABLE_PRINTING);
} }
@ -75,7 +71,6 @@ void Initialize(v8::Local<v8::Object> exports,
dict.SetMethod("isFakeLocationProviderEnabled", dict.SetMethod("isFakeLocationProviderEnabled",
&IsFakeLocationProviderEnabled); &IsFakeLocationProviderEnabled);
dict.SetMethod("isViewApiEnabled", &IsViewApiEnabled); dict.SetMethod("isViewApiEnabled", &IsViewApiEnabled);
dict.SetMethod("isTtsEnabled", &IsTtsEnabled);
dict.SetMethod("isPrintingEnabled", &IsPrintingEnabled); dict.SetMethod("isPrintingEnabled", &IsPrintingEnabled);
dict.SetMethod("isPictureInPictureEnabled", &IsPictureInPictureEnabled); dict.SetMethod("isPictureInPictureEnabled", &IsPictureInPictureEnabled);
dict.SetMethod("isComponentBuild", &IsComponentBuild); dict.SetMethod("isComponentBuild", &IsComponentBuild);

2
spec/chromium-spec.ts
View file

@ -2225,7 +2225,7 @@ describe('chromium features', () => {
// [FATAL:speech_synthesis.mojom-shared.h(237)] The outgoing message will // [FATAL:speech_synthesis.mojom-shared.h(237)] The outgoing message will
// trigger VALIDATION_ERROR_UNEXPECTED_NULL_POINTER at the receiving side // trigger VALIDATION_ERROR_UNEXPECTED_NULL_POINTER at the receiving side
// (null text in SpeechSynthesisUtterance struct). // (null text in SpeechSynthesisUtterance struct).
ifdescribe(features.isTtsEnabled())('SpeechSynthesis', () => { describe('SpeechSynthesis', () => {
itremote('should emit lifecycle events', async () => { itremote('should emit lifecycle events', async () => {
const sentence = `long sentence which will take at least a few seconds to const sentence = `long sentence which will take at least a few seconds to
utter so that it's possible to pause and resume before the end`; utter so that it's possible to pause and resume before the end`;

1
typings/internal-ambient.d.ts vendored
View file

@ -22,7 +22,6 @@ declare namespace NodeJS {
isRunAsNodeEnabled(): boolean; isRunAsNodeEnabled(): boolean;
isFakeLocationProviderEnabled(): boolean; isFakeLocationProviderEnabled(): boolean;
isViewApiEnabled(): boolean; isViewApiEnabled(): boolean;
isTtsEnabled(): boolean;
isPrintingEnabled(): boolean; isPrintingEnabled(): boolean;
isPictureInPictureEnabled(): boolean; isPictureInPictureEnabled(): boolean;
isExtensionsEnabled(): boolean; isExtensionsEnabled(): boolean;