From b6ef4a3929ec5505269ec89c4fc393c6acf7ce7d Mon Sep 17 00:00:00 2001 From: Milan Burda Date: Wed, 24 May 2023 10:18:43 +0200 Subject: [PATCH] build: remove unused enable_tts build flag (#38420) chore: remove unused enable_tts build flag Co-authored-by: Milan Burda --- buildflags/BUILD.gn | 1 - buildflags/buildflags.gni | 2 -- shell/common/api/features.cc | 5 ----- spec/chromium-spec.ts | 2 +- typings/internal-ambient.d.ts | 1 - 5 files changed, 1 insertion(+), 10 deletions(-) diff --git a/buildflags/BUILD.gn b/buildflags/BUILD.gn index a37d752dba36..4d0fbdf26e83 100644 --- a/buildflags/BUILD.gn +++ b/buildflags/BUILD.gn @@ -14,7 +14,6 @@ buildflag_header("buildflags") { "ENABLE_OSR=$enable_osr", "ENABLE_VIEWS_API=$enable_views_api", "ENABLE_PDF_VIEWER=$enable_pdf_viewer", - "ENABLE_TTS=$enable_tts", "ENABLE_COLOR_CHOOSER=$enable_color_chooser", "ENABLE_ELECTRON_EXTENSIONS=$enable_electron_extensions", "ENABLE_BUILTIN_SPELLCHECKER=$enable_builtin_spellchecker", diff --git a/buildflags/buildflags.gni b/buildflags/buildflags.gni index 6a6a7d59fefe..22918b3de790 100644 --- a/buildflags/buildflags.gni +++ b/buildflags/buildflags.gni @@ -14,8 +14,6 @@ declare_args() { enable_pdf_viewer = true - enable_tts = true - enable_color_chooser = true enable_picture_in_picture = true diff --git a/shell/common/api/features.cc b/shell/common/api/features.cc index 19cbfd3e1d44..a753a5a07e6e 100644 --- a/shell/common/api/features.cc +++ b/shell/common/api/features.cc @@ -38,10 +38,6 @@ bool IsViewApiEnabled() { return BUILDFLAG(ENABLE_VIEWS_API); } -bool IsTtsEnabled() { - return BUILDFLAG(ENABLE_TTS); -} - bool IsPrintingEnabled() { return BUILDFLAG(ENABLE_PRINTING); } @@ -75,7 +71,6 @@ void Initialize(v8::Local exports, dict.SetMethod("isFakeLocationProviderEnabled", &IsFakeLocationProviderEnabled); dict.SetMethod("isViewApiEnabled", &IsViewApiEnabled); - dict.SetMethod("isTtsEnabled", &IsTtsEnabled); dict.SetMethod("isPrintingEnabled", &IsPrintingEnabled); dict.SetMethod("isPictureInPictureEnabled", &IsPictureInPictureEnabled); dict.SetMethod("isComponentBuild", &IsComponentBuild); diff --git a/spec/chromium-spec.ts b/spec/chromium-spec.ts index 79c5b65d1c65..88f5e9238fd7 100644 --- a/spec/chromium-spec.ts +++ b/spec/chromium-spec.ts @@ -2225,7 +2225,7 @@ describe('chromium features', () => { // [FATAL:speech_synthesis.mojom-shared.h(237)] The outgoing message will // trigger VALIDATION_ERROR_UNEXPECTED_NULL_POINTER at the receiving side // (null text in SpeechSynthesisUtterance struct). - ifdescribe(features.isTtsEnabled())('SpeechSynthesis', () => { + describe('SpeechSynthesis', () => { itremote('should emit lifecycle events', async () => { const sentence = `long sentence which will take at least a few seconds to utter so that it's possible to pause and resume before the end`; diff --git a/typings/internal-ambient.d.ts b/typings/internal-ambient.d.ts index ab6a18001f2e..805236ddd620 100644 --- a/typings/internal-ambient.d.ts +++ b/typings/internal-ambient.d.ts @@ -22,7 +22,6 @@ declare namespace NodeJS { isRunAsNodeEnabled(): boolean; isFakeLocationProviderEnabled(): boolean; isViewApiEnabled(): boolean; - isTtsEnabled(): boolean; isPrintingEnabled(): boolean; isPictureInPictureEnabled(): boolean; isExtensionsEnabled(): boolean;