mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: remove unused v8::Isolate* arg from GlobalShortcut constructor (#45795)

Browse source 
refactor: remove unused isolate arg from GlobalShortcut constructor

has not been used since f1a0d5e811 (#22755)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2025-02-25 00:06:07 -06:00 • committed by GitHub
parent aa584714cd
commit a9c535d900
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/api/electron_api_global_shortcut.cc
View file

@ -44,7 +44,7 @@ namespace electron::api {
gin::WrapperInfo GlobalShortcut::kWrapperInfo = {gin::kEmbedderNativeGin};
GlobalShortcut::GlobalShortcut(v8::Isolate* isolate) {}
GlobalShortcut::GlobalShortcut() {}
GlobalShortcut::~GlobalShortcut() {
UnregisterAll();
@ -153,7 +153,7 @@ void GlobalShortcut::UnregisterAll() {
// static
gin::Handle<GlobalShortcut> GlobalShortcut::Create(v8::Isolate* isolate) {
return gin::CreateHandle(isolate, new GlobalShortcut(isolate));
return gin::CreateHandle(isolate, new GlobalShortcut());
}
// static

2
shell/browser/api/electron_api_global_shortcut.h
View file

@ -37,7 +37,7 @@ class GlobalShortcut final : private ui::GlobalAcceleratorListener::Observer,
GlobalShortcut& operator=(const GlobalShortcut&) = delete;
protected:
explicit GlobalShortcut(v8::Isolate* isolate);
GlobalShortcut();
~GlobalShortcut() override;
private: