From a9c535d900b83faca63a24e7e22afd203c01b689 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Tue, 25 Feb 2025 00:06:07 -0600 Subject: [PATCH] refactor: remove unused `v8::Isolate*` arg from `GlobalShortcut` constructor (#45795) refactor: remove unused isolate arg from GlobalShortcut constructor has not been used since f1a0d5e811 (#22755) Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/browser/api/electron_api_global_shortcut.cc | 4 ++-- shell/browser/api/electron_api_global_shortcut.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/shell/browser/api/electron_api_global_shortcut.cc b/shell/browser/api/electron_api_global_shortcut.cc index 1486b09bebe1..5c2fd1b5795b 100644 --- a/shell/browser/api/electron_api_global_shortcut.cc +++ b/shell/browser/api/electron_api_global_shortcut.cc @@ -44,7 +44,7 @@ namespace electron::api { gin::WrapperInfo GlobalShortcut::kWrapperInfo = {gin::kEmbedderNativeGin}; -GlobalShortcut::GlobalShortcut(v8::Isolate* isolate) {} +GlobalShortcut::GlobalShortcut() {} GlobalShortcut::~GlobalShortcut() { UnregisterAll(); @@ -153,7 +153,7 @@ void GlobalShortcut::UnregisterAll() { // static gin::Handle GlobalShortcut::Create(v8::Isolate* isolate) { - return gin::CreateHandle(isolate, new GlobalShortcut(isolate)); + return gin::CreateHandle(isolate, new GlobalShortcut()); } // static diff --git a/shell/browser/api/electron_api_global_shortcut.h b/shell/browser/api/electron_api_global_shortcut.h index fb084bea8586..1bb42190be10 100644 --- a/shell/browser/api/electron_api_global_shortcut.h +++ b/shell/browser/api/electron_api_global_shortcut.h @@ -37,7 +37,7 @@ class GlobalShortcut final : private ui::GlobalAcceleratorListener::Observer, GlobalShortcut& operator=(const GlobalShortcut&) = delete; protected: - explicit GlobalShortcut(v8::Isolate* isolate); + GlobalShortcut(); ~GlobalShortcut() override; private: