mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use the user-visible version number in our user agent string

Browse source 
I.e., use CFBundleShortVersionString instead of CFBundleVersion on OS X and
ProductVersion instead of FileVersion on Windows.

This is generally more useful (although slightly lower granularity) than the
machine-readable version number.
This commit is contained in:
Adam Roben 2013-05-28 15:42:52 -04:00
parent 54419bbbb1
commit a24c390318
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
brightray/common/application_info_mac.mm
View file

@ -9,8 +9,12 @@ namespace brightray {
namespace {
std::string ApplicationInfoDictionaryValue(NSString* key) {
return base::SysNSStringToUTF8([MainApplicationBundle().infoDictionary objectForKey:key]);
}
std::string ApplicationInfoDictionaryValue(CFStringRef key) {
return base::SysNSStringToUTF8([MainApplicationBundle().infoDictionary objectForKey:base::mac::CFToNSCast(key)]);
return ApplicationInfoDictionaryValue(base::mac::CFToNSCast(key));
}
}
@ -20,7 +24,7 @@ std::string GetApplicationName() {
}
std::string GetApplicationVersion() {
return ApplicationInfoDictionaryValue(kCFBundleVersionKey);
return ApplicationInfoDictionaryValue(@"CFBundleShortVersionString");
}
}

2
brightray/common/application_info_win.cc
View file

@ -13,7 +13,7 @@ std::string GetApplicationName() {
std::string GetApplicationVersion() {
auto info = make_scoped_ptr(FileVersionInfo::CreateFileVersionInfoForModule(GetModuleHandle(nullptr)));
return UTF16ToUTF8(info->file_version());
return UTF16ToUTF8(info->product_version());
}
}