mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

chore: prefer empty() check for readability (#29360)

Browse source
This commit is contained in:
David Sanders 2021-05-27 13:08:30 -07:00 • committed by GitHub
parent 77ecc7d432
commit 9bb7051f54
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/api/message_port.cc
View file

@ -177,7 +177,7 @@ std::vector<blink::MessagePortChannel> MessagePort::DisentanglePorts(
v8::Isolate* isolate, v8::Isolate* isolate,
const std::vector<gin::Handle<MessagePort>>& ports, const std::vector<gin::Handle<MessagePort>>& ports,
bool* threw_exception) { bool* threw_exception) {
if (!ports.size()) if (ports.empty())
return std::vector<blink::MessagePortChannel>(); return std::vector<blink::MessagePortChannel>();
std::unordered_set<MessagePort*> visited; std::unordered_set<MessagePort*> visited;

2
shell/browser/extensions/electron_extension_loader.cc
View file

@ -54,7 +54,7 @@ std::pair<scoped_refptr<const Extension>, std::string> LoadUnpacked(
std::string warnings; std::string warnings;
// Log warnings. // Log warnings.
if (extension->install_warnings().size()) { if (!extension->install_warnings().empty()) {
warnings += "Warnings loading extension at " + warnings += "Warnings loading extension at " +
base::UTF16ToUTF8(extension_dir.LossyDisplayName()) + ":\n"; base::UTF16ToUTF8(extension_dir.LossyDisplayName()) + ":\n";
for (const auto& warning : extension->install_warnings()) { for (const auto& warning : extension->install_warnings()) {

3
shell/browser/file_select_helper.cc
View file

@ -162,8 +162,7 @@ void FileSelectHelper::OnOpenDialogDone(gin_helper::Dictionary result) {
std::vector<ui::SelectedFileInfo> files = std::vector<ui::SelectedFileInfo> files =
ui::FilePathListToSelectedFileInfoList(paths); ui::FilePathListToSelectedFileInfoList(paths);
// If we are uploading a folder we need to enumerate its contents // If we are uploading a folder we need to enumerate its contents
if (mode_ == FileChooserParams::Mode::kUploadFolder && if (mode_ == FileChooserParams::Mode::kUploadFolder && !paths.empty()) {
paths.size() >= 1) {
lister_base_dir_ = paths[0]; lister_base_dir_ = paths[0];
EnumerateDirectory(); EnumerateDirectory();
} else { } else {

4
shell/common/asar/archive.cc
View file

@ -58,7 +58,7 @@ bool GetChildNode(const base::DictionaryValue* root,
const std::string& name, const std::string& name,
const base::DictionaryValue* dir, const base::DictionaryValue* dir,
const base::DictionaryValue** out) { const base::DictionaryValue** out) {
if (name == "") { if (name.empty()) {
*out = root; *out = root;
return true; return true;
} }
@ -72,7 +72,7 @@ bool GetChildNode(const base::DictionaryValue* root,
bool GetNodeFromPath(std::string path, bool GetNodeFromPath(std::string path,
const base::DictionaryValue* root, const base::DictionaryValue* root,
const base::DictionaryValue** out) { const base::DictionaryValue** out) {
if (path == "") { if (path.empty()) {
*out = root; *out = root;
return true; return true;
} }