diff --git a/shell/browser/api/message_port.cc b/shell/browser/api/message_port.cc index 68cc46a1faf2..d261a9066f09 100644 --- a/shell/browser/api/message_port.cc +++ b/shell/browser/api/message_port.cc @@ -177,7 +177,7 @@ std::vector MessagePort::DisentanglePorts( v8::Isolate* isolate, const std::vector>& ports, bool* threw_exception) { - if (!ports.size()) + if (ports.empty()) return std::vector(); std::unordered_set visited; diff --git a/shell/browser/extensions/electron_extension_loader.cc b/shell/browser/extensions/electron_extension_loader.cc index 21e6351ad48d..0c85a4440bab 100644 --- a/shell/browser/extensions/electron_extension_loader.cc +++ b/shell/browser/extensions/electron_extension_loader.cc @@ -54,7 +54,7 @@ std::pair, std::string> LoadUnpacked( std::string warnings; // Log warnings. - if (extension->install_warnings().size()) { + if (!extension->install_warnings().empty()) { warnings += "Warnings loading extension at " + base::UTF16ToUTF8(extension_dir.LossyDisplayName()) + ":\n"; for (const auto& warning : extension->install_warnings()) { diff --git a/shell/browser/file_select_helper.cc b/shell/browser/file_select_helper.cc index 37e5e645f62a..e574960a8f59 100644 --- a/shell/browser/file_select_helper.cc +++ b/shell/browser/file_select_helper.cc @@ -162,8 +162,7 @@ void FileSelectHelper::OnOpenDialogDone(gin_helper::Dictionary result) { std::vector files = ui::FilePathListToSelectedFileInfoList(paths); // If we are uploading a folder we need to enumerate its contents - if (mode_ == FileChooserParams::Mode::kUploadFolder && - paths.size() >= 1) { + if (mode_ == FileChooserParams::Mode::kUploadFolder && !paths.empty()) { lister_base_dir_ = paths[0]; EnumerateDirectory(); } else { diff --git a/shell/common/asar/archive.cc b/shell/common/asar/archive.cc index 89c5a8d418c9..ad191a6f53a6 100644 --- a/shell/common/asar/archive.cc +++ b/shell/common/asar/archive.cc @@ -58,7 +58,7 @@ bool GetChildNode(const base::DictionaryValue* root, const std::string& name, const base::DictionaryValue* dir, const base::DictionaryValue** out) { - if (name == "") { + if (name.empty()) { *out = root; return true; } @@ -72,7 +72,7 @@ bool GetChildNode(const base::DictionaryValue* root, bool GetNodeFromPath(std::string path, const base::DictionaryValue* root, const base::DictionaryValue** out) { - if (path == "") { + if (path.empty()) { *out = root; return true; }