mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Merge pull request #19 from electron/get-wrapper-const

Browse source 
GetWrapper should be const
This commit is contained in:
Cheng Zhao 2018-02-20 10:07:55 +09:00 committed by GitHub
commit 99d9e262eb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
native_mate/wrappable.cc
View file

@ -23,7 +23,7 @@ WrappableBase::~WrappableBase() {
wrapper_.Reset(); wrapper_.Reset();
} }
v8::Local<v8::Object> WrappableBase::GetWrapper() { v8::Local<v8::Object> WrappableBase::GetWrapper() const {
if (!wrapper_.IsEmpty()) if (!wrapper_.IsEmpty())
return v8::Local<v8::Object>::New(isolate_, wrapper_); return v8::Local<v8::Object>::New(isolate_, wrapper_);
else else

2
native_mate/wrappable_base.h
View file

@ -31,7 +31,7 @@ class WrappableBase {
virtual ~WrappableBase(); virtual ~WrappableBase();
// Retrieve the v8 wrapper object cooresponding to this object. // Retrieve the v8 wrapper object cooresponding to this object.
v8::Local<v8::Object> GetWrapper(); v8::Local<v8::Object> GetWrapper() const;
// Returns the Isolate this object is created in. // Returns the Isolate this object is created in.
v8::Isolate* isolate() const { return isolate_; } v8::Isolate* isolate() const { return isolate_; }