Merge pull request #18 from electron/upgrade-to-chromium-63

virtual members need a virtual destructor
This commit is contained in:
Cheng Zhao 2017-12-19 10:25:22 +09:00 committed by GitHub
commit a38fb5df41
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -35,7 +35,7 @@ class Dictionary {
public:
Dictionary();
Dictionary(v8::Isolate* isolate, v8::Local<v8::Object> object);
~Dictionary();
virtual ~Dictionary();
static Dictionary CreateEmpty(v8::Isolate* isolate);