mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: remove public method BrowserWindow::GetWeakPtr() (#46797)

Browse source 
refactor: remove public method electron::api::BrowserWindow::GetWeakPtr()

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2025-04-25 18:10:50 -05:00 • committed by GitHub
parent 96db57f36f
commit 8e5735e499
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/api/electron_api_browser_window.cc
View file

@ -132,7 +132,7 @@ void BrowserWindow::OnActivateContents() {
void BrowserWindow::OnPageTitleUpdated(const std::u16string& title, void BrowserWindow::OnPageTitleUpdated(const std::u16string& title,
bool explicit_set) { bool explicit_set) {
// Change window title to page title. // Change window title to page title.
auto self = GetWeakPtr(); auto self = weak_factory_.GetWeakPtr();
if (!Emit("page-title-updated", title, explicit_set)) { if (!Emit("page-title-updated", title, explicit_set)) {
// |this| might be deleted, or marked as destroyed by close(). // |this| might be deleted, or marked as destroyed by close().
if (self && !IsDestroyed()) if (self && !IsDestroyed())

4
shell/browser/api/electron_api_browser_window.h
View file

@ -32,10 +32,6 @@ class BrowserWindow : public BaseWindow,
static v8::Local<v8::Value> From(v8::Isolate* isolate, static v8::Local<v8::Value> From(v8::Isolate* isolate,
NativeWindow* native_window); NativeWindow* native_window);
base::WeakPtr<BrowserWindow> GetWeakPtr() {
return weak_factory_.GetWeakPtr();
}
// disable copy // disable copy
BrowserWindow(const BrowserWindow&) = delete; BrowserWindow(const BrowserWindow&) = delete;
BrowserWindow& operator=(const BrowserWindow&) = delete; BrowserWindow& operator=(const BrowserWindow&) = delete;