From 8e5735e499a0fd6c4273f194ce32b46524c2091f Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Fri, 25 Apr 2025 18:10:50 -0500 Subject: [PATCH] refactor: remove public method `BrowserWindow::GetWeakPtr()` (#46797) refactor: remove public method electron::api::BrowserWindow::GetWeakPtr() Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/browser/api/electron_api_browser_window.cc | 2 +- shell/browser/api/electron_api_browser_window.h | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/shell/browser/api/electron_api_browser_window.cc b/shell/browser/api/electron_api_browser_window.cc index 742ca07976da..a40566ea47a9 100644 --- a/shell/browser/api/electron_api_browser_window.cc +++ b/shell/browser/api/electron_api_browser_window.cc @@ -132,7 +132,7 @@ void BrowserWindow::OnActivateContents() { void BrowserWindow::OnPageTitleUpdated(const std::u16string& title, bool explicit_set) { // Change window title to page title. - auto self = GetWeakPtr(); + auto self = weak_factory_.GetWeakPtr(); if (!Emit("page-title-updated", title, explicit_set)) { // |this| might be deleted, or marked as destroyed by close(). if (self && !IsDestroyed()) diff --git a/shell/browser/api/electron_api_browser_window.h b/shell/browser/api/electron_api_browser_window.h index f3d4b352c67c..4e8822e487cf 100644 --- a/shell/browser/api/electron_api_browser_window.h +++ b/shell/browser/api/electron_api_browser_window.h @@ -32,10 +32,6 @@ class BrowserWindow : public BaseWindow, static v8::Local From(v8::Isolate* isolate, NativeWindow* native_window); - base::WeakPtr GetWeakPtr() { - return weak_factory_.GetWeakPtr(); - } - // disable copy BrowserWindow(const BrowserWindow&) = delete; BrowserWindow& operator=(const BrowserWindow&) = delete;