mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: use =default for default constructors/destructors (#29511)

Browse source
This commit is contained in:
David Sanders 2021-06-03 21:16:13 -07:00 • committed by GitHub
parent b1d1ac6524
commit 81c5da5221
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
44 changed files with 68 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

8
shell/browser/extensions/api/management/electron_management_api_delegate.cc
View file

@ -42,7 +42,7 @@ class ManagementSetEnabledFunctionInstallPromptDelegate
base::OnceCallback<void(bool)> callback) {
// TODO(sentialx): emit event
}
~ManagementSetEnabledFunctionInstallPromptDelegate() override {}
~ManagementSetEnabledFunctionInstallPromptDelegate() override = default;
private:
base::WeakPtrFactory<ManagementSetEnabledFunctionInstallPromptDelegate>
@ -61,7 +61,7 @@ class ManagementUninstallFunctionUninstallDialogDelegate
// TODO(sentialx): emit event
}
~ManagementUninstallFunctionUninstallDialogDelegate() override {}
~ManagementUninstallFunctionUninstallDialogDelegate() override = default;
private:
DISALLOW_COPY_AND_ASSIGN(ManagementUninstallFunctionUninstallDialogDelegate);
@ -69,9 +69,9 @@ class ManagementUninstallFunctionUninstallDialogDelegate
} // namespace
ElectronManagementAPIDelegate::ElectronManagementAPIDelegate() {}
ElectronManagementAPIDelegate::ElectronManagementAPIDelegate() = default;
ElectronManagementAPIDelegate::~ElectronManagementAPIDelegate() {}
ElectronManagementAPIDelegate::~ElectronManagementAPIDelegate() = default;
void ElectronManagementAPIDelegate::LaunchAppFunctionDelegate(
const extensions::Extension* extension,

6
shell/browser/extensions/api/resources_private/resources_private_api.cc
View file

@ -79,9 +79,11 @@ void AddAdditionalDataForPdf(base::DictionaryValue* dict) {
namespace get_strings = api::resources_private::GetStrings;
ResourcesPrivateGetStringsFunction::ResourcesPrivateGetStringsFunction() {}
ResourcesPrivateGetStringsFunction::ResourcesPrivateGetStringsFunction() =
default;
ResourcesPrivateGetStringsFunction::~ResourcesPrivateGetStringsFunction() {}
ResourcesPrivateGetStringsFunction::~ResourcesPrivateGetStringsFunction() =
default;
ExtensionFunction::ResponseAction ResourcesPrivateGetStringsFunction::Run() {
std::unique_ptr<get_strings::Params> params(

2
shell/browser/extensions/api/tabs/tabs_api.cc
View file

@ -57,7 +57,7 @@ void ZoomModeToZoomSettings(WebContentsZoomController::ZoomMode zoom_mode,
ExecuteCodeInTabFunction::ExecuteCodeInTabFunction() : execute_tab_id_(-1) {}
ExecuteCodeInTabFunction::~ExecuteCodeInTabFunction() {}
ExecuteCodeInTabFunction::~ExecuteCodeInTabFunction() = default;
ExecuteCodeFunction::InitResult ExecuteCodeInTabFunction::Init() {
if (init_result_)

2
shell/browser/extensions/electron_component_extension_resource_manager.cc
View file

@ -47,7 +47,7 @@ ElectronComponentExtensionResourceManager::
}
ElectronComponentExtensionResourceManager::
~ElectronComponentExtensionResourceManager() {}
~ElectronComponentExtensionResourceManager() = default;
bool ElectronComponentExtensionResourceManager::IsComponentExtensionResource(
const base::FilePath& extension_path,

4
shell/browser/extensions/electron_extension_host_delegate.cc
View file

@ -17,9 +17,9 @@
namespace extensions {
ElectronExtensionHostDelegate::ElectronExtensionHostDelegate() {}
ElectronExtensionHostDelegate::ElectronExtensionHostDelegate() = default;
ElectronExtensionHostDelegate::~ElectronExtensionHostDelegate() {}
ElectronExtensionHostDelegate::~ElectronExtensionHostDelegate() = default;
void ElectronExtensionHostDelegate::OnExtensionHostCreated(
content::WebContents* web_contents) {

2
shell/browser/extensions/electron_extension_system_factory.cc
View file

@ -31,7 +31,7 @@ ElectronExtensionSystemFactory::ElectronExtensionSystemFactory()
DependsOn(ExtensionRegistryFactory::GetInstance());
}
ElectronExtensionSystemFactory::~ElectronExtensionSystemFactory() {}
ElectronExtensionSystemFactory::~ElectronExtensionSystemFactory() = default;
KeyedService* ElectronExtensionSystemFactory::BuildServiceInstanceFor(
BrowserContext* context) const {

3
shell/browser/extensions/electron_extension_web_contents_observer.cc
View file

@ -10,7 +10,8 @@ ElectronExtensionWebContentsObserver::ElectronExtensionWebContentsObserver(
content::WebContents* web_contents)
: ExtensionWebContentsObserver(web_contents) {}
ElectronExtensionWebContentsObserver::~ElectronExtensionWebContentsObserver() {}
ElectronExtensionWebContentsObserver::~ElectronExtensionWebContentsObserver() =
default;
void ElectronExtensionWebContentsObserver::CreateForWebContents(
content::WebContents* web_contents) {

4
shell/browser/extensions/electron_extensions_api_client.cc
View file

@ -51,8 +51,8 @@ class ElectronGuestViewManagerDelegate
class ElectronMimeHandlerViewGuestDelegate
: public MimeHandlerViewGuestDelegate {
public:
ElectronMimeHandlerViewGuestDelegate() {}
~ElectronMimeHandlerViewGuestDelegate() override {}
ElectronMimeHandlerViewGuestDelegate() = default;
~ElectronMimeHandlerViewGuestDelegate() override = default;
// MimeHandlerViewGuestDelegate.
bool HandleContextMenu(content::WebContents* web_contents,

2
shell/browser/extensions/electron_extensions_browser_client.cc
View file

@ -72,7 +72,7 @@ ElectronExtensionsBrowserClient::ElectronExtensionsBrowserClient()
std::make_unique<extensions::ElectronExtensionsBrowserAPIProvider>());
}
ElectronExtensionsBrowserClient::~ElectronExtensionsBrowserClient() {}
ElectronExtensionsBrowserClient::~ElectronExtensionsBrowserClient() = default;
bool ElectronExtensionsBrowserClient::IsShuttingDown() {
return electron::Browser::Get()->is_shutting_down();

4
shell/browser/extensions/electron_kiosk_delegate.cc
View file

@ -6,9 +6,9 @@
namespace electron {
ElectronKioskDelegate::ElectronKioskDelegate() {}
ElectronKioskDelegate::ElectronKioskDelegate() = default;
ElectronKioskDelegate::~ElectronKioskDelegate() {}
ElectronKioskDelegate::~ElectronKioskDelegate() = default;
bool ElectronKioskDelegate::IsAutoLaunchedKioskApp(
const extensions::ExtensionId& id) const {

4
shell/browser/extensions/electron_navigation_ui_data.cc
View file

@ -11,7 +11,7 @@
namespace extensions {
ElectronNavigationUIData::ElectronNavigationUIData() {}
ElectronNavigationUIData::ElectronNavigationUIData() = default;
ElectronNavigationUIData::ElectronNavigationUIData(
content::NavigationHandle* navigation_handle) {
@ -20,7 +20,7 @@ ElectronNavigationUIData::ElectronNavigationUIData(
extension_misc::kUnknownWindowId);
}
ElectronNavigationUIData::~ElectronNavigationUIData() {}
ElectronNavigationUIData::~ElectronNavigationUIData() = default;
std::unique_ptr<content::NavigationUIData> ElectronNavigationUIData::Clone() {
std::unique_ptr<ElectronNavigationUIData> copy =