diff --git a/shell/app/electron_crash_reporter_client.cc b/shell/app/electron_crash_reporter_client.cc index 3c2c9b5309e5..a02ea8fa18af 100644 --- a/shell/app/electron_crash_reporter_client.cc +++ b/shell/app/electron_crash_reporter_client.cc @@ -92,9 +92,9 @@ void ElectronCrashReporterClient::SetGlobalAnnotations( global_annotations_ = annotations; } -ElectronCrashReporterClient::ElectronCrashReporterClient() {} +ElectronCrashReporterClient::ElectronCrashReporterClient() = default; -ElectronCrashReporterClient::~ElectronCrashReporterClient() {} +ElectronCrashReporterClient::~ElectronCrashReporterClient() = default; #if defined(OS_LINUX) void ElectronCrashReporterClient::SetCrashReporterClientIdFromGUID( diff --git a/shell/browser/api/electron_api_in_app_purchase.cc b/shell/browser/api/electron_api_in_app_purchase.cc index f2f18f0d74f4..e4ccf4020b82 100644 --- a/shell/browser/api/electron_api_in_app_purchase.cc +++ b/shell/browser/api/electron_api_in_app_purchase.cc @@ -105,9 +105,9 @@ const char* InAppPurchase::GetTypeName() { return "InAppPurchase"; } -InAppPurchase::InAppPurchase() {} +InAppPurchase::InAppPurchase() = default; -InAppPurchase::~InAppPurchase() {} +InAppPurchase::~InAppPurchase() = default; v8::Local InAppPurchase::PurchaseProduct( const std::string& product_id, diff --git a/shell/browser/api/event.cc b/shell/browser/api/event.cc index 648e1a280e2a..f1b845b5c04a 100644 --- a/shell/browser/api/event.cc +++ b/shell/browser/api/event.cc @@ -16,7 +16,7 @@ namespace gin_helper { gin::WrapperInfo Event::kWrapperInfo = {gin::kEmbedderNativeGin}; -Event::Event() {} +Event::Event() = default; Event::~Event() { if (callback_) { diff --git a/shell/browser/api/views/electron_api_image_view.cc b/shell/browser/api/views/electron_api_image_view.cc index f6f5f94ada5a..3e26fa70d17c 100644 --- a/shell/browser/api/views/electron_api_image_view.cc +++ b/shell/browser/api/views/electron_api_image_view.cc @@ -18,7 +18,7 @@ ImageView::ImageView() : View(new views::ImageView()) { view()->set_owned_by_client(); } -ImageView::~ImageView() {} +ImageView::~ImageView() = default; void ImageView::SetImage(const gfx::Image& image) { image_view()->SetImage(image.AsImageSkia()); diff --git a/shell/browser/badging/badge_manager_factory.cc b/shell/browser/badging/badge_manager_factory.cc index a4e5e193c5bd..28e4e4eae0af 100644 --- a/shell/browser/badging/badge_manager_factory.cc +++ b/shell/browser/badging/badge_manager_factory.cc @@ -31,7 +31,7 @@ BadgeManagerFactory::BadgeManagerFactory() "BadgeManager", BrowserContextDependencyManager::GetInstance()) {} -BadgeManagerFactory::~BadgeManagerFactory() {} +BadgeManagerFactory::~BadgeManagerFactory() = default; KeyedService* BadgeManagerFactory::BuildServiceInstanceFor( content::BrowserContext* context) const { diff --git a/shell/browser/child_web_contents_tracker.cc b/shell/browser/child_web_contents_tracker.cc index 51cfb8ba9cd2..9a6113481e3a 100644 --- a/shell/browser/child_web_contents_tracker.cc +++ b/shell/browser/child_web_contents_tracker.cc @@ -9,7 +9,7 @@ namespace electron { ChildWebContentsTracker::ChildWebContentsTracker( content::WebContents* web_contents) {} -ChildWebContentsTracker::~ChildWebContentsTracker() {} +ChildWebContentsTracker::~ChildWebContentsTracker() = default; WEB_CONTENTS_USER_DATA_KEY_IMPL(ChildWebContentsTracker) diff --git a/shell/browser/electron_javascript_dialog_manager.cc b/shell/browser/electron_javascript_dialog_manager.cc index b78d5c5f4247..f1a5d61e5c70 100644 --- a/shell/browser/electron_javascript_dialog_manager.cc +++ b/shell/browser/electron_javascript_dialog_manager.cc @@ -27,7 +27,7 @@ constexpr int kUserWantsNoMoreDialogs = -1; } // namespace -ElectronJavaScriptDialogManager::ElectronJavaScriptDialogManager() {} +ElectronJavaScriptDialogManager::ElectronJavaScriptDialogManager() = default; ElectronJavaScriptDialogManager::~ElectronJavaScriptDialogManager() = default; void ElectronJavaScriptDialogManager::RunJavaScriptDialog( diff --git a/shell/browser/electron_pdf_web_contents_helper_client.cc b/shell/browser/electron_pdf_web_contents_helper_client.cc index 202a873743cb..7d8bf09bb7b3 100644 --- a/shell/browser/electron_pdf_web_contents_helper_client.cc +++ b/shell/browser/electron_pdf_web_contents_helper_client.cc @@ -4,7 +4,8 @@ #include "shell/browser/electron_pdf_web_contents_helper_client.h" -ElectronPDFWebContentsHelperClient::ElectronPDFWebContentsHelperClient() {} +ElectronPDFWebContentsHelperClient::ElectronPDFWebContentsHelperClient() = + default; ElectronPDFWebContentsHelperClient::~ElectronPDFWebContentsHelperClient() = default; diff --git a/shell/browser/extensions/api/management/electron_management_api_delegate.cc b/shell/browser/extensions/api/management/electron_management_api_delegate.cc index 1d61240427bb..17669e9bad48 100644 --- a/shell/browser/extensions/api/management/electron_management_api_delegate.cc +++ b/shell/browser/extensions/api/management/electron_management_api_delegate.cc @@ -42,7 +42,7 @@ class ManagementSetEnabledFunctionInstallPromptDelegate base::OnceCallback callback) { // TODO(sentialx): emit event } - ~ManagementSetEnabledFunctionInstallPromptDelegate() override {} + ~ManagementSetEnabledFunctionInstallPromptDelegate() override = default; private: base::WeakPtrFactory @@ -61,7 +61,7 @@ class ManagementUninstallFunctionUninstallDialogDelegate // TODO(sentialx): emit event } - ~ManagementUninstallFunctionUninstallDialogDelegate() override {} + ~ManagementUninstallFunctionUninstallDialogDelegate() override = default; private: DISALLOW_COPY_AND_ASSIGN(ManagementUninstallFunctionUninstallDialogDelegate); @@ -69,9 +69,9 @@ class ManagementUninstallFunctionUninstallDialogDelegate } // namespace -ElectronManagementAPIDelegate::ElectronManagementAPIDelegate() {} +ElectronManagementAPIDelegate::ElectronManagementAPIDelegate() = default; -ElectronManagementAPIDelegate::~ElectronManagementAPIDelegate() {} +ElectronManagementAPIDelegate::~ElectronManagementAPIDelegate() = default; void ElectronManagementAPIDelegate::LaunchAppFunctionDelegate( const extensions::Extension* extension, diff --git a/shell/browser/extensions/api/resources_private/resources_private_api.cc b/shell/browser/extensions/api/resources_private/resources_private_api.cc index 2b0bcbdd70d9..fdee6fb2515f 100644 --- a/shell/browser/extensions/api/resources_private/resources_private_api.cc +++ b/shell/browser/extensions/api/resources_private/resources_private_api.cc @@ -79,9 +79,11 @@ void AddAdditionalDataForPdf(base::DictionaryValue* dict) { namespace get_strings = api::resources_private::GetStrings; -ResourcesPrivateGetStringsFunction::ResourcesPrivateGetStringsFunction() {} +ResourcesPrivateGetStringsFunction::ResourcesPrivateGetStringsFunction() = + default; -ResourcesPrivateGetStringsFunction::~ResourcesPrivateGetStringsFunction() {} +ResourcesPrivateGetStringsFunction::~ResourcesPrivateGetStringsFunction() = + default; ExtensionFunction::ResponseAction ResourcesPrivateGetStringsFunction::Run() { std::unique_ptr params( diff --git a/shell/browser/extensions/api/tabs/tabs_api.cc b/shell/browser/extensions/api/tabs/tabs_api.cc index 21b2f1597802..3625ac3238a6 100644 --- a/shell/browser/extensions/api/tabs/tabs_api.cc +++ b/shell/browser/extensions/api/tabs/tabs_api.cc @@ -57,7 +57,7 @@ void ZoomModeToZoomSettings(WebContentsZoomController::ZoomMode zoom_mode, ExecuteCodeInTabFunction::ExecuteCodeInTabFunction() : execute_tab_id_(-1) {} -ExecuteCodeInTabFunction::~ExecuteCodeInTabFunction() {} +ExecuteCodeInTabFunction::~ExecuteCodeInTabFunction() = default; ExecuteCodeFunction::InitResult ExecuteCodeInTabFunction::Init() { if (init_result_) diff --git a/shell/browser/extensions/electron_component_extension_resource_manager.cc b/shell/browser/extensions/electron_component_extension_resource_manager.cc index 76a8c1caf7d1..85ce840ee88f 100644 --- a/shell/browser/extensions/electron_component_extension_resource_manager.cc +++ b/shell/browser/extensions/electron_component_extension_resource_manager.cc @@ -47,7 +47,7 @@ ElectronComponentExtensionResourceManager:: } ElectronComponentExtensionResourceManager:: - ~ElectronComponentExtensionResourceManager() {} + ~ElectronComponentExtensionResourceManager() = default; bool ElectronComponentExtensionResourceManager::IsComponentExtensionResource( const base::FilePath& extension_path, diff --git a/shell/browser/extensions/electron_extension_host_delegate.cc b/shell/browser/extensions/electron_extension_host_delegate.cc index 1aa8cc73e5bd..ada5337f863c 100644 --- a/shell/browser/extensions/electron_extension_host_delegate.cc +++ b/shell/browser/extensions/electron_extension_host_delegate.cc @@ -17,9 +17,9 @@ namespace extensions { -ElectronExtensionHostDelegate::ElectronExtensionHostDelegate() {} +ElectronExtensionHostDelegate::ElectronExtensionHostDelegate() = default; -ElectronExtensionHostDelegate::~ElectronExtensionHostDelegate() {} +ElectronExtensionHostDelegate::~ElectronExtensionHostDelegate() = default; void ElectronExtensionHostDelegate::OnExtensionHostCreated( content::WebContents* web_contents) { diff --git a/shell/browser/extensions/electron_extension_system_factory.cc b/shell/browser/extensions/electron_extension_system_factory.cc index b284f8f21b44..cb430fc9643f 100644 --- a/shell/browser/extensions/electron_extension_system_factory.cc +++ b/shell/browser/extensions/electron_extension_system_factory.cc @@ -31,7 +31,7 @@ ElectronExtensionSystemFactory::ElectronExtensionSystemFactory() DependsOn(ExtensionRegistryFactory::GetInstance()); } -ElectronExtensionSystemFactory::~ElectronExtensionSystemFactory() {} +ElectronExtensionSystemFactory::~ElectronExtensionSystemFactory() = default; KeyedService* ElectronExtensionSystemFactory::BuildServiceInstanceFor( BrowserContext* context) const { diff --git a/shell/browser/extensions/electron_extension_web_contents_observer.cc b/shell/browser/extensions/electron_extension_web_contents_observer.cc index 4d7a2cebd5c7..edd811d57143 100644 --- a/shell/browser/extensions/electron_extension_web_contents_observer.cc +++ b/shell/browser/extensions/electron_extension_web_contents_observer.cc @@ -10,7 +10,8 @@ ElectronExtensionWebContentsObserver::ElectronExtensionWebContentsObserver( content::WebContents* web_contents) : ExtensionWebContentsObserver(web_contents) {} -ElectronExtensionWebContentsObserver::~ElectronExtensionWebContentsObserver() {} +ElectronExtensionWebContentsObserver::~ElectronExtensionWebContentsObserver() = + default; void ElectronExtensionWebContentsObserver::CreateForWebContents( content::WebContents* web_contents) { diff --git a/shell/browser/extensions/electron_extensions_api_client.cc b/shell/browser/extensions/electron_extensions_api_client.cc index bd8f631f154f..704eb2df39c3 100644 --- a/shell/browser/extensions/electron_extensions_api_client.cc +++ b/shell/browser/extensions/electron_extensions_api_client.cc @@ -51,8 +51,8 @@ class ElectronGuestViewManagerDelegate class ElectronMimeHandlerViewGuestDelegate : public MimeHandlerViewGuestDelegate { public: - ElectronMimeHandlerViewGuestDelegate() {} - ~ElectronMimeHandlerViewGuestDelegate() override {} + ElectronMimeHandlerViewGuestDelegate() = default; + ~ElectronMimeHandlerViewGuestDelegate() override = default; // MimeHandlerViewGuestDelegate. bool HandleContextMenu(content::WebContents* web_contents, diff --git a/shell/browser/extensions/electron_extensions_browser_client.cc b/shell/browser/extensions/electron_extensions_browser_client.cc index e7362fd38976..5de1aa938ae5 100644 --- a/shell/browser/extensions/electron_extensions_browser_client.cc +++ b/shell/browser/extensions/electron_extensions_browser_client.cc @@ -72,7 +72,7 @@ ElectronExtensionsBrowserClient::ElectronExtensionsBrowserClient() std::make_unique()); } -ElectronExtensionsBrowserClient::~ElectronExtensionsBrowserClient() {} +ElectronExtensionsBrowserClient::~ElectronExtensionsBrowserClient() = default; bool ElectronExtensionsBrowserClient::IsShuttingDown() { return electron::Browser::Get()->is_shutting_down(); diff --git a/shell/browser/extensions/electron_kiosk_delegate.cc b/shell/browser/extensions/electron_kiosk_delegate.cc index 35106a392d45..3afe982dbe4f 100644 --- a/shell/browser/extensions/electron_kiosk_delegate.cc +++ b/shell/browser/extensions/electron_kiosk_delegate.cc @@ -6,9 +6,9 @@ namespace electron { -ElectronKioskDelegate::ElectronKioskDelegate() {} +ElectronKioskDelegate::ElectronKioskDelegate() = default; -ElectronKioskDelegate::~ElectronKioskDelegate() {} +ElectronKioskDelegate::~ElectronKioskDelegate() = default; bool ElectronKioskDelegate::IsAutoLaunchedKioskApp( const extensions::ExtensionId& id) const { diff --git a/shell/browser/extensions/electron_navigation_ui_data.cc b/shell/browser/extensions/electron_navigation_ui_data.cc index eac7e275c67b..2f59dd7c98d9 100644 --- a/shell/browser/extensions/electron_navigation_ui_data.cc +++ b/shell/browser/extensions/electron_navigation_ui_data.cc @@ -11,7 +11,7 @@ namespace extensions { -ElectronNavigationUIData::ElectronNavigationUIData() {} +ElectronNavigationUIData::ElectronNavigationUIData() = default; ElectronNavigationUIData::ElectronNavigationUIData( content::NavigationHandle* navigation_handle) { @@ -20,7 +20,7 @@ ElectronNavigationUIData::ElectronNavigationUIData( extension_misc::kUnknownWindowId); } -ElectronNavigationUIData::~ElectronNavigationUIData() {} +ElectronNavigationUIData::~ElectronNavigationUIData() = default; std::unique_ptr ElectronNavigationUIData::Clone() { std::unique_ptr copy = diff --git a/shell/browser/native_browser_view_mac.mm b/shell/browser/native_browser_view_mac.mm index 8a6ad5b1b736..e42342c96580 100644 --- a/shell/browser/native_browser_view_mac.mm +++ b/shell/browser/native_browser_view_mac.mm @@ -225,7 +225,7 @@ NativeBrowserViewMac::NativeBrowserViewMac( view.autoresizingMask = kDefaultAutoResizingMask; } -NativeBrowserViewMac::~NativeBrowserViewMac() {} +NativeBrowserViewMac::~NativeBrowserViewMac() = default; void NativeBrowserViewMac::SetAutoResizeFlags(uint8_t flags) { NSAutoresizingMaskOptions autoresizing_mask = kDefaultAutoResizingMask; diff --git a/shell/browser/native_window_mac.mm b/shell/browser/native_window_mac.mm index fc47a7ae0354..9c8b3438184a 100644 --- a/shell/browser/native_window_mac.mm +++ b/shell/browser/native_window_mac.mm @@ -450,7 +450,7 @@ NativeWindowMac::NativeWindowMac(const gin_helper::Dictionary& options, original_level_ = [window_ level]; } -NativeWindowMac::~NativeWindowMac() {} +NativeWindowMac::~NativeWindowMac() = default; void NativeWindowMac::SetContentView(views::View* view) { views::View* root_view = GetContentsView(); diff --git a/shell/browser/net/asar/asar_url_loader.cc b/shell/browser/net/asar/asar_url_loader.cc index 10746c09dbb3..e976ec816bce 100644 --- a/shell/browser/net/asar/asar_url_loader.cc +++ b/shell/browser/net/asar/asar_url_loader.cc @@ -83,7 +83,7 @@ class AsarURLLoader : public network::mojom::URLLoader { void ResumeReadingBodyFromNet() override {} private: - AsarURLLoader() {} + AsarURLLoader() = default; ~AsarURLLoader() override = default; void Start(const network::ResourceRequest& request, diff --git a/shell/browser/notifications/win/notification_presenter_win.cc b/shell/browser/notifications/win/notification_presenter_win.cc index e1f7fbdf3a6d..0ba3a7ce7ec2 100644 --- a/shell/browser/notifications/win/notification_presenter_win.cc +++ b/shell/browser/notifications/win/notification_presenter_win.cc @@ -63,9 +63,9 @@ NotificationPresenter* NotificationPresenter::Create() { return presenter.release(); } -NotificationPresenterWin::NotificationPresenterWin() {} +NotificationPresenterWin::NotificationPresenterWin() = default; -NotificationPresenterWin::~NotificationPresenterWin() {} +NotificationPresenterWin::~NotificationPresenterWin() = default; bool NotificationPresenterWin::Init() { base::ThreadRestrictions::ScopedAllowIO allow_io; diff --git a/shell/browser/notifications/win/windows_toast_notification.cc b/shell/browser/notifications/win/windows_toast_notification.cc index 3e6fd53b6620..63774add9dfb 100644 --- a/shell/browser/notifications/win/windows_toast_notification.cc +++ b/shell/browser/notifications/win/windows_toast_notification.cc @@ -596,7 +596,7 @@ bool WindowsToastNotification::RemoveCallbacks( ToastEventHandler::ToastEventHandler(Notification* notification) : notification_(notification->GetWeakPtr()) {} -ToastEventHandler::~ToastEventHandler() {} +ToastEventHandler::~ToastEventHandler() = default; IFACEMETHODIMP ToastEventHandler::Invoke( ABI::Windows::UI::Notifications::IToastNotification* sender, diff --git a/shell/browser/printing/print_view_manager_electron.cc b/shell/browser/printing/print_view_manager_electron.cc index 27fed09fce61..d33a9e396087 100644 --- a/shell/browser/printing/print_view_manager_electron.cc +++ b/shell/browser/printing/print_view_manager_electron.cc @@ -14,7 +14,7 @@ PrintViewManagerElectron::PrintViewManagerElectron( content::WebContents* web_contents) : PrintViewManagerBase(web_contents) {} -PrintViewManagerElectron::~PrintViewManagerElectron() {} +PrintViewManagerElectron::~PrintViewManagerElectron() = default; void PrintViewManagerElectron::SetupScriptedPrintPreview( SetupScriptedPrintPreviewCallback callback) { diff --git a/shell/browser/protocol_registry.cc b/shell/browser/protocol_registry.cc index f462a19111a4..637facb0968d 100644 --- a/shell/browser/protocol_registry.cc +++ b/shell/browser/protocol_registry.cc @@ -16,7 +16,7 @@ ProtocolRegistry* ProtocolRegistry::FromBrowserContext( return static_cast(context)->protocol_registry(); } -ProtocolRegistry::ProtocolRegistry() {} +ProtocolRegistry::ProtocolRegistry() = default; ProtocolRegistry::~ProtocolRegistry() = default; diff --git a/shell/browser/serial/serial_chooser_context_factory.cc b/shell/browser/serial/serial_chooser_context_factory.cc index 58cd1b0e31c5..6fbe6a520da0 100644 --- a/shell/browser/serial/serial_chooser_context_factory.cc +++ b/shell/browser/serial/serial_chooser_context_factory.cc @@ -14,7 +14,7 @@ SerialChooserContextFactory::SerialChooserContextFactory() "SerialChooserContext", BrowserContextDependencyManager::GetInstance()) {} -SerialChooserContextFactory::~SerialChooserContextFactory() {} +SerialChooserContextFactory::~SerialChooserContextFactory() = default; KeyedService* SerialChooserContextFactory::BuildServiceInstanceFor( content::BrowserContext* context) const { diff --git a/shell/browser/ui/cocoa/delayed_native_view_host.cc b/shell/browser/ui/cocoa/delayed_native_view_host.cc index 6c606c6c76d3..5efe09686c7c 100644 --- a/shell/browser/ui/cocoa/delayed_native_view_host.cc +++ b/shell/browser/ui/cocoa/delayed_native_view_host.cc @@ -9,7 +9,7 @@ namespace electron { DelayedNativeViewHost::DelayedNativeViewHost(gfx::NativeView native_view) : native_view_(native_view) {} -DelayedNativeViewHost::~DelayedNativeViewHost() {} +DelayedNativeViewHost::~DelayedNativeViewHost() = default; void DelayedNativeViewHost::ViewHierarchyChanged( const views::ViewHierarchyChangedDetails& details) { diff --git a/shell/browser/ui/cocoa/electron_native_widget_mac.mm b/shell/browser/ui/cocoa/electron_native_widget_mac.mm index 21b5afe1b30d..4247a45229f9 100644 --- a/shell/browser/ui/cocoa/electron_native_widget_mac.mm +++ b/shell/browser/ui/cocoa/electron_native_widget_mac.mm @@ -16,7 +16,7 @@ ElectronNativeWidgetMac::ElectronNativeWidgetMac( shell_(shell), style_mask_(style_mask) {} -ElectronNativeWidgetMac::~ElectronNativeWidgetMac() {} +ElectronNativeWidgetMac::~ElectronNativeWidgetMac() = default; NativeWidgetMacNSWindow* ElectronNativeWidgetMac::CreateNSWindow( const remote_cocoa::mojom::CreateWindowParams* params) { diff --git a/shell/browser/ui/cocoa/root_view_mac.mm b/shell/browser/ui/cocoa/root_view_mac.mm index 75bae1092dcf..c94e42d752c6 100644 --- a/shell/browser/ui/cocoa/root_view_mac.mm +++ b/shell/browser/ui/cocoa/root_view_mac.mm @@ -12,7 +12,7 @@ RootViewMac::RootViewMac(NativeWindow* window) : window_(window) { set_owned_by_client(); } -RootViewMac::~RootViewMac() {} +RootViewMac::~RootViewMac() = default; void RootViewMac::Layout() { if (!window_->content_view()) // Not ready yet. diff --git a/shell/browser/ui/cocoa/views_delegate_mac.mm b/shell/browser/ui/cocoa/views_delegate_mac.mm index 593dfda7f3f8..169707b4c16c 100644 --- a/shell/browser/ui/cocoa/views_delegate_mac.mm +++ b/shell/browser/ui/cocoa/views_delegate_mac.mm @@ -9,9 +9,9 @@ namespace electron { -ViewsDelegateMac::ViewsDelegateMac() {} +ViewsDelegateMac::ViewsDelegateMac() = default; -ViewsDelegateMac::~ViewsDelegateMac() {} +ViewsDelegateMac::~ViewsDelegateMac() = default; void ViewsDelegateMac::OnBeforeWidgetInit( views::Widget::InitParams* params, diff --git a/shell/browser/ui/views/win_frame_view.cc b/shell/browser/ui/views/win_frame_view.cc index 55119cf1e422..5f48f9653631 100644 --- a/shell/browser/ui/views/win_frame_view.cc +++ b/shell/browser/ui/views/win_frame_view.cc @@ -13,9 +13,9 @@ namespace electron { const char WinFrameView::kViewClassName[] = "WinFrameView"; -WinFrameView::WinFrameView() {} +WinFrameView::WinFrameView() = default; -WinFrameView::~WinFrameView() {} +WinFrameView::~WinFrameView() = default; gfx::Rect WinFrameView::GetWindowBoundsForClientBounds( const gfx::Rect& client_bounds) const { diff --git a/shell/browser/ui/win/electron_desktop_window_tree_host_win.cc b/shell/browser/ui/win/electron_desktop_window_tree_host_win.cc index 852de00a52b4..03d0846c7f8f 100644 --- a/shell/browser/ui/win/electron_desktop_window_tree_host_win.cc +++ b/shell/browser/ui/win/electron_desktop_window_tree_host_win.cc @@ -23,7 +23,7 @@ ElectronDesktopWindowTreeHostWin::ElectronDesktopWindowTreeHostWin( desktop_native_widget_aura), native_window_view_(native_window_view) {} -ElectronDesktopWindowTreeHostWin::~ElectronDesktopWindowTreeHostWin() {} +ElectronDesktopWindowTreeHostWin::~ElectronDesktopWindowTreeHostWin() = default; bool ElectronDesktopWindowTreeHostWin::PreHandleMSG(UINT message, WPARAM w_param, diff --git a/shell/browser/ui/win/taskbar_host.cc b/shell/browser/ui/win/taskbar_host.cc index 59682f9bf481..b20a4aa969a8 100644 --- a/shell/browser/ui/win/taskbar_host.cc +++ b/shell/browser/ui/win/taskbar_host.cc @@ -55,9 +55,9 @@ TaskbarHost::ThumbarButton::ThumbarButton(const TaskbarHost::ThumbarButton&) = default; TaskbarHost::ThumbarButton::~ThumbarButton() = default; -TaskbarHost::TaskbarHost() {} +TaskbarHost::TaskbarHost() = default; -TaskbarHost::~TaskbarHost() {} +TaskbarHost::~TaskbarHost() = default; bool TaskbarHost::SetThumbarButtons(HWND window, const std::vector& buttons) { diff --git a/shell/browser/win/scoped_hstring.cc b/shell/browser/win/scoped_hstring.cc index 0cf95d484ba1..343032b8cc13 100644 --- a/shell/browser/win/scoped_hstring.cc +++ b/shell/browser/win/scoped_hstring.cc @@ -16,7 +16,7 @@ ScopedHString::ScopedHString(const std::wstring& source) { Reset(source); } -ScopedHString::ScopedHString() {} +ScopedHString::ScopedHString() = default; ScopedHString::~ScopedHString() { Reset(); diff --git a/shell/common/api/electron_bindings.cc b/shell/common/api/electron_bindings.cc index 85fba109a1c8..7561c0c076e6 100644 --- a/shell/common/api/electron_bindings.cc +++ b/shell/common/api/electron_bindings.cc @@ -38,7 +38,7 @@ ElectronBindings::ElectronBindings(uv_loop_t* loop) { metrics_ = base::ProcessMetrics::CreateCurrentProcessMetrics(); } -ElectronBindings::~ElectronBindings() {} +ElectronBindings::~ElectronBindings() = default; // static void ElectronBindings::BindProcess(v8::Isolate* isolate, diff --git a/shell/common/extensions/electron_extensions_client.cc b/shell/common/extensions/electron_extensions_client.cc index 803a78dda160..7130a098340a 100644 --- a/shell/common/extensions/electron_extensions_client.cc +++ b/shell/common/extensions/electron_extensions_client.cc @@ -30,8 +30,8 @@ namespace { class ElectronPermissionMessageProvider : public extensions::PermissionMessageProvider { public: - ElectronPermissionMessageProvider() {} - ~ElectronPermissionMessageProvider() override {} + ElectronPermissionMessageProvider() = default; + ~ElectronPermissionMessageProvider() override = default; // PermissionMessageProvider implementation. extensions::PermissionMessages GetPermissionMessages( @@ -70,7 +70,7 @@ ElectronExtensionsClient::ElectronExtensionsClient() AddAPIProvider(std::make_unique()); } -ElectronExtensionsClient::~ElectronExtensionsClient() {} +ElectronExtensionsClient::~ElectronExtensionsClient() = default; void ElectronExtensionsClient::Initialize() { // TODO(jamescook): Do we need to whitelist any extensions? diff --git a/shell/common/node_bindings_mac.cc b/shell/common/node_bindings_mac.cc index b77e2016ca63..e5163f700615 100644 --- a/shell/common/node_bindings_mac.cc +++ b/shell/common/node_bindings_mac.cc @@ -17,7 +17,7 @@ namespace electron { NodeBindingsMac::NodeBindingsMac(BrowserEnvironment browser_env) : NodeBindings(browser_env) {} -NodeBindingsMac::~NodeBindingsMac() {} +NodeBindingsMac::~NodeBindingsMac() = default; void NodeBindingsMac::RunMessageLoop() { // Get notified when libuv's watcher queue changes. diff --git a/shell/common/node_bindings_win.cc b/shell/common/node_bindings_win.cc index c3deea628e6b..2356c523e361 100644 --- a/shell/common/node_bindings_win.cc +++ b/shell/common/node_bindings_win.cc @@ -27,7 +27,7 @@ NodeBindingsWin::NodeBindingsWin(BrowserEnvironment browser_env) } } -NodeBindingsWin::~NodeBindingsWin() {} +NodeBindingsWin::~NodeBindingsWin() = default; void NodeBindingsWin::PollEvents() { // If there are other kinds of events pending, uv_backend_timeout will diff --git a/shell/renderer/api/context_bridge/object_cache.cc b/shell/renderer/api/context_bridge/object_cache.cc index cb672d29c777..928124bab451 100644 --- a/shell/renderer/api/context_bridge/object_cache.cc +++ b/shell/renderer/api/context_bridge/object_cache.cc @@ -14,7 +14,7 @@ namespace api { namespace context_bridge { -ObjectCache::ObjectCache() {} +ObjectCache::ObjectCache() = default; ObjectCache::~ObjectCache() = default; void ObjectCache::CacheProxiedObject(v8::Local from, diff --git a/shell/renderer/electron_renderer_pepper_host_factory.cc b/shell/renderer/electron_renderer_pepper_host_factory.cc index e4c097a4ef64..9d3d0c54cc09 100644 --- a/shell/renderer/electron_renderer_pepper_host_factory.cc +++ b/shell/renderer/electron_renderer_pepper_host_factory.cc @@ -79,7 +79,8 @@ ElectronRendererPepperHostFactory::ElectronRendererPepperHostFactory( content::RendererPpapiHost* host) : host_(host) {} -ElectronRendererPepperHostFactory::~ElectronRendererPepperHostFactory() {} +ElectronRendererPepperHostFactory::~ElectronRendererPepperHostFactory() = + default; std::unique_ptr ElectronRendererPepperHostFactory::CreateResourceHost( diff --git a/shell/renderer/extensions/electron_extensions_dispatcher_delegate.cc b/shell/renderer/extensions/electron_extensions_dispatcher_delegate.cc index 8ffa262b2409..4e3e510e919e 100644 --- a/shell/renderer/extensions/electron_extensions_dispatcher_delegate.cc +++ b/shell/renderer/extensions/electron_extensions_dispatcher_delegate.cc @@ -18,9 +18,11 @@ using extensions::NativeHandler; -ElectronExtensionsDispatcherDelegate::ElectronExtensionsDispatcherDelegate() {} +ElectronExtensionsDispatcherDelegate::ElectronExtensionsDispatcherDelegate() = + default; -ElectronExtensionsDispatcherDelegate::~ElectronExtensionsDispatcherDelegate() {} +ElectronExtensionsDispatcherDelegate::~ElectronExtensionsDispatcherDelegate() = + default; void ElectronExtensionsDispatcherDelegate::RegisterNativeHandlers( extensions::Dispatcher* dispatcher, diff --git a/shell/renderer/extensions/electron_extensions_renderer_client.cc b/shell/renderer/extensions/electron_extensions_renderer_client.cc index b0c51f4226c1..1d3c047ca930 100644 --- a/shell/renderer/extensions/electron_extensions_renderer_client.cc +++ b/shell/renderer/extensions/electron_extensions_renderer_client.cc @@ -21,7 +21,7 @@ ElectronExtensionsRendererClient::ElectronExtensionsRendererClient() dispatcher_->OnRenderThreadStarted(content::RenderThread::Get()); } -ElectronExtensionsRendererClient::~ElectronExtensionsRendererClient() {} +ElectronExtensionsRendererClient::~ElectronExtensionsRendererClient() = default; bool ElectronExtensionsRendererClient::IsIncognitoProcess() const { // app_shell doesn't support off-the-record contexts. diff --git a/shell/renderer/pepper_helper.cc b/shell/renderer/pepper_helper.cc index c00e27db8101..1bed62a2b9b2 100644 --- a/shell/renderer/pepper_helper.cc +++ b/shell/renderer/pepper_helper.cc @@ -15,7 +15,7 @@ PepperHelper::PepperHelper(content::RenderFrame* render_frame) : RenderFrameObserver(render_frame) {} -PepperHelper::~PepperHelper() {} +PepperHelper::~PepperHelper() = default; void PepperHelper::DidCreatePepperPlugin(content::RendererPpapiHost* host) { // TODO(brettw) figure out how to hook up the host factory. It needs some