mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: use v8::String::Empty() when creating empty strings (#46371)

Browse source 
refactor: use v8::String::Empty() when creating empty strings

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2025-03-31 10:39:48 +02:00 • committed by GitHub
commit 7e80e8f610
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/api/electron_api_app.cc
View file

@ -164,7 +164,7 @@ struct Converter<JumpListItem::Type> {
if (item_val == val) if (item_val == val)
return gin::ConvertToV8(isolate, name); return gin::ConvertToV8(isolate, name);
return gin::ConvertToV8(isolate, ""); return v8::String::Empty(isolate);
} }
private: private:
@ -255,7 +255,7 @@ struct Converter<JumpListCategory::Type> {
if (type_val == val) if (type_val == val)
return gin::ConvertToV8(isolate, name); return gin::ConvertToV8(isolate, name);
return gin::ConvertToV8(isolate, ""); return v8::String::Empty(isolate);
} }
private: private:

2
shell/browser/ui/cocoa/electron_bundle_mover.mm
View file

@ -30,7 +30,7 @@ struct Converter<electron::BundlerMoverConflictType> {
case electron::BundlerMoverConflictType::kExistsAndRunning: case electron::BundlerMoverConflictType::kExistsAndRunning:
return gin::StringToV8(isolate, "existsAndRunning"); return gin::StringToV8(isolate, "existsAndRunning");
default: default:
return gin::StringToV8(isolate, ""); return v8::String::Empty(isolate);
} }
} }
}; };

2
shell/common/gin_converters/guid_converter.h
View file

@ -70,7 +70,7 @@ struct Converter<UUID> {
#if BUILDFLAG(IS_WIN) #if BUILDFLAG(IS_WIN)
const GUID GUID_NULL = {}; const GUID GUID_NULL = {};
if (val == GUID_NULL) { if (val == GUID_NULL) {
return StringToV8(isolate, ""); return v8::String::Empty(isolate);
} else { } else {
std::wstring uid = base::win::WStringFromGUID(val); std::wstring uid = base::win::WStringFromGUID(val);
return StringToV8(isolate, base::SysWideToUTF8(uid)); return StringToV8(isolate, base::SysWideToUTF8(uid));