diff --git a/shell/browser/api/electron_api_app.cc b/shell/browser/api/electron_api_app.cc index 61238f86da14..3c19d191720b 100644 --- a/shell/browser/api/electron_api_app.cc +++ b/shell/browser/api/electron_api_app.cc @@ -164,7 +164,7 @@ struct Converter { if (item_val == val) return gin::ConvertToV8(isolate, name); - return gin::ConvertToV8(isolate, ""); + return v8::String::Empty(isolate); } private: @@ -255,7 +255,7 @@ struct Converter { if (type_val == val) return gin::ConvertToV8(isolate, name); - return gin::ConvertToV8(isolate, ""); + return v8::String::Empty(isolate); } private: diff --git a/shell/browser/ui/cocoa/electron_bundle_mover.mm b/shell/browser/ui/cocoa/electron_bundle_mover.mm index 1ea871443cb7..3eb269259444 100644 --- a/shell/browser/ui/cocoa/electron_bundle_mover.mm +++ b/shell/browser/ui/cocoa/electron_bundle_mover.mm @@ -30,7 +30,7 @@ struct Converter { case electron::BundlerMoverConflictType::kExistsAndRunning: return gin::StringToV8(isolate, "existsAndRunning"); default: - return gin::StringToV8(isolate, ""); + return v8::String::Empty(isolate); } } }; diff --git a/shell/common/gin_converters/guid_converter.h b/shell/common/gin_converters/guid_converter.h index ec18678fa2c6..88dd8cf79262 100644 --- a/shell/common/gin_converters/guid_converter.h +++ b/shell/common/gin_converters/guid_converter.h @@ -70,7 +70,7 @@ struct Converter { #if BUILDFLAG(IS_WIN) const GUID GUID_NULL = {}; if (val == GUID_NULL) { - return StringToV8(isolate, ""); + return v8::String::Empty(isolate); } else { std::wstring uid = base::win::WStringFromGUID(val); return StringToV8(isolate, base::SysWideToUTF8(uid));