mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

build: [gn] fix dllimport warnings

Browse source
This commit is contained in:
Jeremy Apthorp 2018-07-11 10:45:21 -07:00
parent 03131c5e77
commit 7bec61bac5
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
BUILD.gn
View file

@ -274,11 +274,6 @@ static_library("electron_lib") {
defines = [ defines = [
# Disable warnings for g_settings_list_schemas. # Disable warnings for g_settings_list_schemas.
"GLIB_DISABLE_DEPRECATION_WARNINGS", "GLIB_DISABLE_DEPRECATION_WARNINGS",
# Import V8 symbols from shared library (node.dll / libnode.so)
"USING_V8_SHARED",
"USING_V8_PLATFORM_SHARED",
"USING_V8_BASE_SHARED",
] ]
include_dirs = [ include_dirs = [
"chromium_src", "chromium_src",
@ -288,6 +283,14 @@ static_library("electron_lib") {
# API of blink, then delete this include dir. # API of blink, then delete this include dir.
"//third_party/WebKit/Source", "//third_party/WebKit/Source",
] ]
if (is_component_build) {
defines += [
# Import V8 symbols from shared library (node.dll / libnode.so)
"USING_V8_SHARED",
"USING_V8_PLATFORM_SHARED",
"USING_V8_BASE_SHARED",
]
}
if (is_linux || is_win) { if (is_linux || is_win) {
deps += [ "//third_party/breakpad:client" ] deps += [ "//third_party/breakpad:client" ]
include_dirs += [ include_dirs += [