From 7bec61bac56fea30f73cc76b0dc9511baabd48a5 Mon Sep 17 00:00:00 2001
From: Jeremy Apthorp <nornagon@nornagon.net>
Date: Wed, 11 Jul 2018 10:45:21 -0700
Subject: [PATCH] build: [gn] fix dllimport warnings

---
 BUILD.gn | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/BUILD.gn b/BUILD.gn
index 6e64bd134c1e..6868679efd43 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -274,11 +274,6 @@ static_library("electron_lib") {
   defines = [
     # Disable warnings for g_settings_list_schemas.
     "GLIB_DISABLE_DEPRECATION_WARNINGS",
-
-    # Import V8 symbols from shared library (node.dll / libnode.so)
-    "USING_V8_SHARED",
-    "USING_V8_PLATFORM_SHARED",
-    "USING_V8_BASE_SHARED",
   ]
   include_dirs = [
     "chromium_src",
@@ -288,6 +283,14 @@ static_library("electron_lib") {
     # API of blink, then delete this include dir.
     "//third_party/WebKit/Source",
   ]
+  if (is_component_build) {
+    defines += [
+      # Import V8 symbols from shared library (node.dll / libnode.so)
+      "USING_V8_SHARED",
+      "USING_V8_PLATFORM_SHARED",
+      "USING_V8_BASE_SHARED",
+    ]
+  }
   if (is_linux || is_win) {
     deps += [ "//third_party/breakpad:client" ]
     include_dirs += [